devcrypto fixes, forcezero on memory after use, RX64 GetHash port fix, blake2 stor64 alignment#10508
Open
JacobBarthelmeh wants to merge 10 commits into
Open
devcrypto fixes, forcezero on memory after use, RX64 GetHash port fix, blake2 stor64 alignment#10508JacobBarthelmeh wants to merge 10 commits into
JacobBarthelmeh wants to merge 10 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bundles several small fixes across hardware/port backends and crypto primitives, mainly addressing correctness in devcrypto parameter setup, sensitive-memory cleanup, and a Renesas RX64 SHA “empty input” edge case.
Changes:
- Fix devcrypto struct initialization/parameter sizing issues (AEAD memset size, RSA n/d bit-size mix-up, ECDSA kop initialization).
- Add/expand sensitive-memory zeroization after use (TropicSquare pairing keys; NXP DCP AES key scratch buffer).
- Add RX64 SHA “GetHash on empty state” handling to return the documented empty-message digest.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| wolfssl/wolfcrypt/blake2-impl.h | Adjusts fast-path load/store selection for alignment-sensitive targets. |
| wolfcrypt/src/rc2.c | Tightens 16-bit word assembly casts when reading input blocks. |
| wolfcrypt/src/port/tropicsquare/tropic01.c | Zeroizes stored pairing keys on deinit. |
| wolfcrypt/src/port/Renesas/renesas_rx64_hw_sha.c | Returns correct empty-message digest in RX64_HashGet for freshly inited hashes. |
| wolfcrypt/src/port/nxp/dcp_port.c | Adds key scratch-buffer zeroization around DCP AES SetKey/Free. |
| wolfcrypt/src/port/devcrypto/wc_devcrypto.c | Fixes AEAD crypt_auth_op memset size. |
| wolfcrypt/src/port/devcrypto/devcrypto_rsa.c | Fixes RSA private op parameter bit-size assignments for n/d. |
| wolfcrypt/src/port/devcrypto/devcrypto_ecdsa.c | Ensures crypt_kop is fully zero-initialized before ioctl. |
| linuxkm/lkcapi_aes_glue.c | Uses Linux errno (-ENOMEM) instead of wolfSSL error code for allocation failure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fenrir fixes