Guard test_wrong_cs_downgrade on SHA-384 cipher suite; enable SHA disables in minimal DTLS os-check build#10539
Draft
julek-wolfssl wants to merge 1 commit into
Draft
Guard test_wrong_cs_downgrade on SHA-384 cipher suite; enable SHA disables in minimal DTLS os-check build#10539julek-wolfssl wants to merge 1 commit into
julek-wolfssl wants to merge 1 commit into
Conversation
…ables in minimal DTLS os-check build
Contributor
There was a problem hiding this comment.
Pull request overview
Updates wolfSSL’s API test gating and CI “os-check” minimal DTLS 1.3 configuration to better align test execution and feature availability when SHA-384 is disabled.
Changes:
- Guard
test_wrong_cs_downgradebehindBUILD_TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384so it’s skipped when the SHA-384-based cipher suite isn’t built. - Update the minimal DTLS 1.3 client-only
os-checkmatrix entry to explicitly disable SHA-224/SHA-384/SHA-512/SHA-3 families.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/api.c |
Adds an additional compile-time guard so the SHA-384 cipher-suite-dependent test is not built/run when unavailable. |
.github/workflows/os-check.yml |
Enables additional --disable-sha* flags for the minimal DTLS 1.3 build variant and updates the accompanying comment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+121
to
+122
| # hash families disabled, leaving only SHA-256 (the hash used by | ||
| # TLS_AES_128_GCM_SHA256). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.