Skip to content

20260527-fixes#10545

Merged
JacobBarthelmeh merged 1 commit into
wolfSSL:masterfrom
douzzer:20260527-fixes
May 27, 2026
Merged

20260527-fixes#10545
JacobBarthelmeh merged 1 commit into
wolfSSL:masterfrom
douzzer:20260527-fixes

Conversation

@douzzer
Copy link
Copy Markdown
Contributor

@douzzer douzzer commented May 27, 2026

tests/api/test_mldsa_legacy.c: fix bugprone-macro-parentheses in MLDSA_LEGACY_SIZE_ASSERT().

wolfssl/wolfcrypt/wc_mldsa.h: move WOLFSSL_MLDSA_NO_CTX setup to precede legacy dilithium.h header, so that the _NO_CTX remap macros are properly gated in.

tested with

wolfssl-multi-test.sh ...
check-source-text
clang-tidy-fips-140-3-dev-all
clang-tidy-fips-140-3-dev-all-crypto-no-sha-1
clang-tidy-fips-140-3-dev-defaults
clang-tidy-fips-140-3-dev-defaults-no-sha-1
linuxkm-defaults-all-quantum-safe-fips-dev-clang-tidy
linuxkm-defaults-all-quantum-safe-fips-dev-noasm-clang-tidy
quantum-safe-wolfssl-all-clang-tidy
quantum-safe-wolfssl-all-noasm-clang-tidy
quantum-safe-wolfssl-all-smallstack-clang-tidy
benchmark-wolfcrypt-intelasm-all-clang
quantum-safe-wolfssl-all-fips204-clang-tidy
quantum-safe-wolfssl-all-no-asm-clang-tidy
quantum-safe-wolfssl-all-linuxkm-defaults-clang-tidy
liboqs-all-clang-tidy
linuxkm-6.15-all-cryptonly-quantum-safe-fips-dev-intelasm-insmod-crypto-fuzzer-kmemleak

…A_LEGACY_SIZE_ASSERT().

wolfssl/wolfcrypt/wc_mldsa.h: move WOLFSSL_MLDSA_NO_CTX setup to precede legacy dilithium.h header, so that the _NO_CTX remap macros are properly gated in.
Copy link
Copy Markdown

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10545

Scan targets checked: wolfcrypt-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

No new issues found in the changed files. ✅

@JacobBarthelmeh JacobBarthelmeh merged commit b0d61c5 into wolfSSL:master May 27, 2026
451 checks passed
@Frauschi
Copy link
Copy Markdown
Contributor

Thanks for handling this @douzzer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants