Ed448: check for public key presence on export

[holtrop-wolfssl]

Description

Ed448: check for public key presence on export

Return PUBLIC_KEY_E for wc_ed25519_export_key if public key is not present.
Return PUBLIC_KEY_E for wc_ed448_export_key if public key is not present.
Rename several inLen parameters to outLen for consistency.

Fix F-4427

Testing

How did you test?

Checklist

• added tests
• updated/added doxygen
• updated appropriate READMEs
• Updated manual and documentation

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[github-actions]

MemBrowse Memory Report

linuxkm-pie

• Data: __patchable_function_entries +16 B (+0.1%, 24,288 B)

linuxkm-standard

• Data: __patchable_function_entries +16 B (+0.0%, 46,000 B)
  No memory changes detected for:
• gcc-arm-cortex-m0plus
• gcc-arm-cortex-m3
• gcc-arm-cortex-m4
• gcc-arm-cortex-m4-baremetal
• gcc-arm-cortex-m4-crypto-only
• gcc-arm-cortex-m4-dtls13
• gcc-arm-cortex-m4-min-ecc
• gcc-arm-cortex-m4-openssl-compat
• gcc-arm-cortex-m4-pkcs7
• gcc-arm-cortex-m4-pq
• gcc-arm-cortex-m4-rsa-only
• gcc-arm-cortex-m4-sp-math
• gcc-arm-cortex-m4-tls12
• gcc-arm-cortex-m4-tls13
• gcc-arm-cortex-m7
• gcc-arm-cortex-m7-pq
• gcc-arm-cortex-m7-tls13
• stm32-sim-stm32h753

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

[dgarske]

Skoll Code Review

Scan type: reviewOverall recommendation: COMMENT
Findings: 2 total — 2 posted, 0 skipped
1 finding(s) posted as inline comments (see file-level comments below)

Posted findings

• [Medium] New PUBLIC_KEY_E return value not documented for wc_ed448_export_public — wolfcrypt/src/ed448.c:1109-1143, doc/dox_comments/header_files/ed448.h:663-667
• [Low] Public-API semantics change to wc_ed25519_export_key (private-only keys now error) — wolfcrypt/src/ed25519.c:1523-1537

Review generated by Skoll

[holtrop-wolfssl]

retest this please (Timeout has been exceeded)

[dgarske]

Skoll Multi-Scan Review

Modes: review + review-securityOverall recommendation: REQUEST_CHANGES
Findings: 6 total — 6 posted, 0 skipped
4 finding(s) posted as inline comments (see file-level comments below)

Posted findings

• [High] [review] Ed448 ToDer test asserts PUBLIC_KEY_E unconditionally; fails under FIPS 7.0.0 — tests/api/test_ed448.c:503-505
• [High] [review] New wolfCrypt export_key tests assert PUBLIC_KEY_E from export_public without FIPS guard — wolfcrypt/test/test.c:44905, 46721
• [Low] Public API behavior change: export now returns PUBLIC_KEY_E for private-only keys — wolfcrypt/src/ed25519.c:1523-1537, wolfcrypt/src/ed448.c:1119-1143
• [Low] New PUBLIC_KEY_E return value not documented for ed448 export functions — wolfcrypt/src/ed448.c:1109-1118
• [Low] [review] New PUBLIC_KEY_E return of wc_ed448_export_public is undocumented — wolfcrypt/src/ed448.c:1115-1135
• [Info] [review-security] Intentional public-API return-contract change in wc_ed25519_export_key (private-only keys now yield PUBLIC_KEY_E) — wolfcrypt/src/ed25519.c:1523-1537

Review generated by Skoll

[dgarske]

See #10656 (review)
And you have smoke test merge conflicts. Are you use git merge (if so don't). Use git rebase master and a force push

[dgarske]

Jenkins retest this please "Build 'PRB-generic-config-parser' failed with result: FAILURE" . resume.test failure.