the examples pem.c --padding flag does not need gated behind WOLFSSL_DER_TO_PEM

[JacobBarthelmeh]

Reproduce with : ./configure --enable-enckeys --enable-des3 && make check

Issue was reported in the nightly CDT enable tests.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR fixes the examples/pem/pem.c --padding CLI option so it’s no longer gated behind WOLFSSL_DER_TO_PEM, aligning behavior with builds that enable encrypted keys but don’t enable DER-to-PEM conversion.

Changes:

• Expose --padding in the usage text whenever encrypted-key support is enabled (and password-based encryption is available).
• Parse --padding outside the WOLFSSL_DER_TO_PEM argument-handling block so the flag is accepted regardless of DER-to-PEM support.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[JacobBarthelmeh]

Retest this please Jenkins. FIPS 140-2 failing test.

[github-actions]

MemBrowse Memory Report

No memory changes detected for:

• gcc-arm-cortex-m0plus
• gcc-arm-cortex-m3
• gcc-arm-cortex-m4
• gcc-arm-cortex-m4-baremetal
• gcc-arm-cortex-m4-crypto-only
• gcc-arm-cortex-m4-dtls13
• gcc-arm-cortex-m4-min-ecc
• gcc-arm-cortex-m4-openssl-compat
• gcc-arm-cortex-m4-pkcs7
• gcc-arm-cortex-m4-pq
• gcc-arm-cortex-m4-rsa-only
• gcc-arm-cortex-m4-sp-math
• gcc-arm-cortex-m4-tls12
• gcc-arm-cortex-m4-tls13
• gcc-arm-cortex-m7
• gcc-arm-cortex-m7-pq
• gcc-arm-cortex-m7-tls13
• linuxkm-pie
• linuxkm-standard
• stm32-sim-stm32h753

[dgarske]

Skoll Code Review

Scan type: reviewOverall recommendation: COMMENT
Findings: 1 total — 1 posted, 0 skipped
1 finding(s) posted as inline comments (see file-level comments below)

Posted findings

• [Low] Adjacent duplicate preprocessor guard for --padding option — examples/pem/pem.c:828-848

Review generated by Skoll