Fix: prevent public SNI from being installed on ctx#10678
Open
sebastian-carpenter wants to merge 1 commit into
Open
Fix: prevent public SNI from being installed on ctx#10678sebastian-carpenter wants to merge 1 commit into
sebastian-carpenter wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts TLS 1.3 ECH SNI-swapping so the public (outer) SNI is never installed onto a shared WOLFSSL_CTX extension list, preventing cross-connection state mutation when the inner SNI was configured at the context level.
Changes:
- Update
TLSX_EchChangeSNI()to avoid mutatingssl->ctx->extensionswhile still ensuring the public SNI is used on the wire for ClientHelloOuter. - Add a regression test that inspects ClientHello(1/2) bytes to validate the plaintext SNI equals
public_nameacross {accept,reject} × {inner SNI on ssl, ctx}. - Move/centralize small ClientHello extension-parsing helpers used by multiple ECH memio tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/tls.c |
Prevents ECH SNI swap from installing the public SNI on the shared ctx extension list. |
tests/api.c |
Adds a memio regression test to validate wire SNI behavior for ECH across multiple branches. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Jenkins retest this please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reworked the changeSNI logic so it never installs the public SNI onto the shared ctx.
Testing
Added a regression test to check the plaintext SNI is always the public_name. Added matrix to verify ctx SNI swap works.
Checklist