fix: add debian/copyright.commercial for commercial .deb builds#10717
Closed
MarkAtwood wants to merge 3 commits into
Closed
fix: add debian/copyright.commercial for commercial .deb builds#10717MarkAtwood wants to merge 3 commits into
MarkAtwood wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a Debian machine-readable copyright file intended for commercial/FIPS .deb builds to avoid shipping GPL metadata, while preserving third‑party license attributions.
Changes:
- Introduces
debian/copyright.commercialas a drop-in replacement for commercial packaging. - Declares commercial wolfSSL licensing and retains upstream licenses for bundled third-party sources.
- Adds attribution for BLAKE2 sources (CC0-1.0, Samuel Neves).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+210
to
+226
| License: BSD-3-Clause | ||
| Redistribution and use in source and binary forms, with or without | ||
| modification, are permitted provided that the following conditions are | ||
| met: | ||
| . | ||
| * Redistributions of source code must retain the above copyright | ||
| notice, this list of conditions and the following disclaimer. | ||
| . | ||
| * Redistributions in binary form must reproduce the above | ||
| copyright notice, this list of conditions and the following disclaimer | ||
| in the documentation and/or other materials provided with the | ||
| distribution. | ||
| . | ||
| * The names of its contributors may not be used to endorse or | ||
| promote products derived from this software without specific prior | ||
| written permission. | ||
| . |
Comment on lines
+6
to
+8
| Files: | ||
| * | ||
| Copyright: |
| Free Software Foundation; either version 3 of the License, or (at your | ||
| option) any later version. | ||
| . | ||
| As a special exception, the respective Autoconf Macro's copyright owner |
| @@ -0,0 +1,243 @@ | |||
| Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ | |||
| Upstream-Name: wolfssl | |||
Contributor
Author
|
Closing -- per Lealem's feedback, commercial packaging metadata should not live in the public wolfssl repo. The files have been moved to wolfSSL/scripts#589 where they live alongside the existing license templates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds commercial-license packaging metadata for .deb and .rpm builds.
The Jenkins packaging jobs run
license.plto replace source headers and COPYING with commercial text, but packaging metadata (debian/copyright, RPM specLicense:field) was left unchanged, shipping GPL references in commercial packages.Files added
debian/copyright.commercial-- DEP-5 format, declareswolfSSL-Commercialfor wolfSSL code, preserves correct third-party attribution (NTT camellia, BLAKE2, Zephyr, m4 macros)rpm/spec.in.commercial--License: LicenseRef-wolfSSL-Commercial(SPDX custom identifier for proprietary), commercial description textBoth are drop-in replacements: the build pipeline copies them over the GPL originals after
license.plruns. Also adds previously missing blake2b.c/blake2s.c attribution (CC0-1.0, Samuel Neves).Test plan
license.plswap logiclicense.plpost-build grep)