Add fips-hash-offline.sh#10749
Open
holtrop-wolfssl wants to merge 1 commit into
Open
Conversation
This script calculates the FIPS integrity hash for an already-linked binary offline at build time.
holtrop-wolfssl
force-pushed
the
add-fips-hash-offline-script
branch
from
dfce905 to
83f46f8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new build-time utility script to compute and patch the wolfCrypt FIPS in-core integrity hash directly into an already-linked binary (intended for static/offline build flows), and documents how it differs from the existing source-patching workflow.
Changes:
- Added
fips-hash-offline.shto compute the in-core integrity HMAC over ELF ranges and patchverifyCore[]in-place in the binary. - Updated
fips-hash.shheader comments to clarify its runtime/scrape-and-patch-source behavior and reference the offline variant. - Listed the new script in
SCRIPTS-LIST.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| SCRIPTS-LIST | Adds an entry for the new offline FIPS hash patching script. |
| fips-hash.sh | Adds documentation explaining purpose and when to use the offline script instead. |
| fips-hash-offline.sh | New script implementing offline hash computation and in-place patching of verifyCore[] in a linked ELF binary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This script calculates the FIPS integrity hash for an already-linked binary offline at build time.
Tested with fips/optest-140-3/static-building/optest-run-static-test.sh
Testing
How did you test?
Checklist