Skip to content

PPC64/PPC32 ASM: AES, SHA-2, SHA-3#10767

Open
SparkiDev wants to merge 1 commit into
wolfSSL:masterfrom
SparkiDev:ppc64_ppc32_asm_1
Open

PPC64/PPC32 ASM: AES, SHA-2, SHA-3#10767
SparkiDev wants to merge 1 commit into
wolfSSL:masterfrom
SparkiDev:ppc64_ppc32_asm_1

Conversation

@SparkiDev

Copy link
Copy Markdown
Contributor

Description

PPC64:

  • Added AES-ECB/CBC/CTR/GCM/XTS using crypto instructions
  • Added SHA-256/512 using base scalar and crypto instructions
  • Added SHA-3 using base scalar and POWER8 VSX
  • Added SHA-3 x2/x3 but disabled compilation.
  • Added CPU id flags.
  • Changed the constant data format to be consistent with other platforms. PPC32:
  • Added AES-ECB/CBC/CTR/GCM/XTS using base scalar
  • Added SHA-256/512 using base scalar
  • Added SHA-3 using base scalar

Testing

Various PPC64 and PPC32 configurations.

@SparkiDev SparkiDev self-assigned this Jun 24, 2026
@SparkiDev

Copy link
Copy Markdown
Contributor Author

Code generated by PR:
https://github.com/wolfSSL/scripts/pull/600

@SparkiDev SparkiDev force-pushed the ppc64_ppc32_asm_1 branch 3 times, most recently from a3e9d23 to 2ca65ae Compare June 24, 2026 20:34
@SparkiDev

SparkiDev commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Jenkins: retest this please

generic: agent offline
FIPS: failed then agent killed

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10767

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

Comment thread wolfcrypt/src/sha256.c
@SparkiDev SparkiDev force-pushed the ppc64_ppc32_asm_1 branch from 2ca65ae to 70c207b Compare June 25, 2026 02:16
Comment thread wolfcrypt/src/sha256.c
@SparkiDev

SparkiDev commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Jenlkins: retest this please

Windows

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10767

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

Comment thread wolfcrypt/src/sha512.c Outdated
PPC64:
  - Added AES-ECB/CBC/CTR/GCM/XTS using crypto instructions
  - Added SHA-256/512 using base scalar and crypto instructions
  - Added SHA-3 using base scalar and POWER8 VSX
  - Added SHA-3 x2/x3 but disabled compilation.
  - Added CPU id flags.
  - Changed the constant data format to be consistent with other platforms.
PPC32:
  - Added AES-ECB/CBC/CTR/GCM/XTS using base scalar
  - Added SHA-256/512 using base scalar
  - Added SHA-3 using base scalar
@SparkiDev SparkiDev force-pushed the ppc64_ppc32_asm_1 branch from 70c207b to 4693ee0 Compare June 25, 2026 06:33
Comment thread wolfcrypt/src/sha512.c Outdated

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10767

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

No new issues found in the changed files. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants