20260630-various-fixes#10829
Merged
Merged
Conversation
* when including kernel headers with gcc-17+, ignore -Wconstant-logical-operand. * when CONFIG_KMSAN, explicitly map memcpy(), memset(), memmove(), strcpy(), strncpy(), and strncat(), to clang builtins, to get proper __msan interception. * genericize WC_SANITIZE_DISABLE() and WC_SANITIZE_ENABLE() to cover both KASAN and KMSAN, and use the generic macros in wc_linuxkm_stack_hwm_prepare() and wc_linuxkm_stack_hwm_measure_rel().
…for authTagSz validation on old FIPS.
…ptBlocks(), AesCbcEncryptBlocks(), AesCbcDecryptBlocks(), and AesCtrEncryptBlocks(), to fix -Wunused-functions in default build with --enable-aesni under clang. * in AesCfbDecrypt_C(), add smallstack implementation for fast inner loop on intelasm/armasm.
douzzer
requested review from
SparkiDev,
philljj,
wolfSSL-Bot and
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10829
Scan targets checked: linuxkm-bugs, linuxkm-src, wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src
Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
linuxkm/linuxkm_wc_port.h: strcpy() takes 2 args. wolfcrypt/src/aes.c: add VECTOR_REGISTERS_PUSH2() and use it to free tmp in smallstack path if the push fails.
dgarske
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linuxkm/linuxkm_wc_port.h:when including kernel headers with gcc-17+, ignore
-Wconstant-logical-operand.when
CONFIG_KMSAN, explicitly mapmemcpy(),memset(),memmove(),strcpy(),strncpy(), andstrncat(), to clang builtins, to get proper__msaninterception.
genericize
WC_SANITIZE_DISABLE()andWC_SANITIZE_ENABLE()to cover both KASANand KMSAN, and use the generic macros in
wc_linuxkm_stack_hwm_prepare()andwc_linuxkm_stack_hwm_measure_rel().wolfcrypt/src/port/kcapi/kcapi_aes.c: add backward-compat code paths forauthTagSzvalidation on old FIPS.wolfcrypt/src/aes.c:add
WC_MAYBE_UNUSEDattribute toAesEcbEncryptBlocks(),AesEcbDecryptBlocks(),AesCbcEncryptBlocks(),AesCbcDecryptBlocks(), andAesCtrEncryptBlocks(), tofix
-Wunused-functions in default build with--enable-aesniunderclang.in
AesCfbDecrypt_C(), add smallstack implementation for fast inner loop onintelasm/armasm.
detected and tested with