Skip to content

hmac: add missing ForceZero for tmp, prk. #9890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
douzzer merged 1 commit into from
Mar 10, 2026
Merged

hmac: add missing ForceZero for tmp, prk. #9890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions wolfcrypt/src/hmac.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1679,6 +1679,7 @@ int wolfSSL_GetHmacMaxSize(void)
n++;
}

ForceZero(tmp, WC_MAX_DIGEST_SIZE);
Comment thread
philljj marked this conversation as resolved.
wc_HmacFree(myHmac);
WC_FREE_VAR_EX(myHmac, NULL, DYNAMIC_TYPE_HMAC);

Expand Down Expand Up @@ -1734,11 +1735,12 @@ int wolfSSL_GetHmacMaxSize(void)

ret = wc_HKDF_Extract_ex(type, salt, saltSz, inKey, inKeySz, prk, heap,
devId);
if (ret != 0)
return ret;

return wc_HKDF_Expand_ex(type, prk, hashSz, info, infoSz, out, outSz,
heap, devId);
if (ret == 0) {
ret = wc_HKDF_Expand_ex(type, prk, hashSz, info, infoSz,
out, outSz, heap, devId);
}
ForceZero(prk, WC_MAX_DIGEST_SIZE);
Comment thread
philljj marked this conversation as resolved.
return ret;
}

int wc_HKDF(int type, const byte* inKey, word32 inKeySz, const byte* salt,
Expand Down