asn: add HAVE_OCSP_RESPONDER guard, to fix wolfboot build.#9959
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an HAVE_OCSP_RESPONDER compile-time guard around the AsnHashesHash/AsnHashesGetHash helpers in asn.c to fix wolfBoot builds against current wolfSSL master.
Changes:
- Wrap
AsnHashesHash()andAsnHashesGetHash()with#ifdef HAVE_OCSP_RESPONDER/#endif.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
Author
|
Retest this please. (Some kind of ocsp-stapling timeout failure in unit test). |
JacobBarthelmeh
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
HAVE_OCSP_RESPONDERdefine guard aroundint AsnHashesHash(and friends inasn.c. These functions are only used with the OCSP responder.Fixes wolfboot build with wolfssl master.
Testing
Build wolfboot sim example with
lib/wolfsslset to master.