Skip to content

Commit 0c086a1

Browse files
committed
set severity to warning
Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
1 parent d973ff2 commit 0c086a1

4 files changed

Lines changed: 19 additions & 13 deletions

File tree

pkg/lint/rules.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ var AllRules = func(l *Linter) Rules { //nolint:gocyclo
459459
{
460460
Name: "valid-version-stream",
461461
Description: "check the provides and tag filter if version stream suffix is passed to package name",
462-
Severity: SeverityError,
462+
Severity: SeverityWarning,
463463
LintFunc: func(c config.Configuration) error {
464464
// This regex captures a string that ends with a semantic version (semver) suffix.
465465
// It returns two groups:

pkg/lint/rules_test.go

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -415,16 +415,16 @@ func TestLinter_Rules(t *testing.T) {
415415
},
416416
{
417417
file: "version-stream-missing-provides-1.2.yaml",
418-
minSeverity: SeverityError,
418+
minSeverity: SeverityWarning,
419419
want: EvalResult{
420420
File: "version-stream-missing-provides-1.2",
421421
Errors: EvalRuleErrors{
422422
{
423423
Rule: Rule{
424424
Name: "valid-version-stream",
425-
Severity: SeverityError,
425+
Severity: SeverityWarning,
426426
},
427-
Error: fmt.Errorf("[valid-version-stream]: package is version streamed but version-stream-missing-provides=${{package.full-version}} is missing on dependencies.provides (ERROR)"),
427+
Error: fmt.Errorf("[valid-version-stream]: package is version streamed but version-stream-missing-provides=${{package.full-version}} is missing on dependencies.provides (WARNING)"),
428428
},
429429
},
430430
},
@@ -433,16 +433,16 @@ func TestLinter_Rules(t *testing.T) {
433433
},
434434
{
435435
file: "version-stream-missing-update-tagfilter-1.2.yaml",
436-
minSeverity: SeverityError,
436+
minSeverity: SeverityWarning,
437437
want: EvalResult{
438438
File: "version-stream-missing-update-tagfilter-1.2",
439439
Errors: EvalRuleErrors{
440440
{
441441
Rule: Rule{
442442
Name: "valid-version-stream",
443-
Severity: SeverityError,
443+
Severity: SeverityWarning,
444444
},
445-
Error: fmt.Errorf("[valid-version-stream]: package is version streamed but tag filter 1.2 is mismatch on update.github (ERROR)"),
445+
Error: fmt.Errorf("[valid-version-stream]: package is version streamed but tag filter 1.2 is mismatch on update.github (WARNING)"),
446446
},
447447
},
448448
},
@@ -451,16 +451,16 @@ func TestLinter_Rules(t *testing.T) {
451451
},
452452
{
453453
file: "version-stream-missing-update-tagfilter-1.2-999.yaml",
454-
minSeverity: SeverityError,
454+
minSeverity: SeverityWarning,
455455
want: EvalResult{
456456
File: "version-stream-missing-update-tagfilter-1.2",
457457
Errors: EvalRuleErrors{
458458
{
459459
Rule: Rule{
460460
Name: "valid-version-stream",
461-
Severity: SeverityError,
461+
Severity: SeverityWarning,
462462
},
463-
Error: fmt.Errorf("[valid-version-stream]: package is version streamed but tag filter 1.2 is mismatch on update.github (ERROR)"),
463+
Error: fmt.Errorf("[valid-version-stream]: package is version streamed but tag filter 1.2 is mismatch on update.github (WARNING)"),
464464
},
465465
},
466466
},
@@ -469,16 +469,16 @@ func TestLinter_Rules(t *testing.T) {
469469
},
470470
{
471471
file: "version-stream-mismatch-version-1.2.yaml",
472-
minSeverity: SeverityError,
472+
minSeverity: SeverityWarning,
473473
want: EvalResult{
474474
File: "version-stream-mismatch-version-1.2",
475475
Errors: EvalRuleErrors{
476476
{
477477
Rule: Rule{
478478
Name: "valid-version-stream",
479-
Severity: SeverityError,
479+
Severity: SeverityWarning,
480480
},
481-
Error: fmt.Errorf("[valid-version-stream]: package is version streamed but package.version 1.7 starts with different than given version stream 1.2 (ERROR)"),
481+
Error: fmt.Errorf("[valid-version-stream]: package is version streamed but package.version 1.7 starts with different than given version stream 1.2 (WARNING)"),
482482
},
483483
},
484484
},

pkg/lint/testdata/files/version-stream-mismatch-version-1.2.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,3 +13,6 @@ pipeline:
1313
test:
1414
pipeline:
1515
- runs: "echo 'test'"
16+
17+
update:
18+
enabled: true

pkg/lint/testdata/files/version-stream-missing-provides-1.2.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,3 +13,6 @@ pipeline:
1313
test:
1414
pipeline:
1515
- runs: "echo 'test'"
16+
17+
update:
18+
enabled: true

0 commit comments

Comments
 (0)