Remove dead OrderStatus view Mode mechanism and redundant custom-status color arm

Author: AdamGrzybkowski

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/aiassistant/AiAssistantOrderCardRenderer.kt

@@ -84,6 +84,5 @@ private fun resolveOrderStatusColor(status: String): Int =
         is Order.Status.Completed -> R.color.tag_bg_completed
         is Order.Status.Failed -> R.color.tag_bg_failed
         is Order.Status.OnHold -> R.color.tag_bg_on_hold
-        is Order.Status.Custom -> R.color.tag_bg_other
         else -> R.color.tag_bg_other
     }

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/creation/OrderCreateEditFormFragment.kt

@@ -89,7 +89,6 @@ import com.woocommerce.android.ui.orders.creation.views.ExpandableProductCard
 import com.woocommerce.android.ui.orders.creation.views.OrderCreateEditSectionView
 import com.woocommerce.android.ui.orders.creation.views.OrderCreateEditSectionView.AddButton
 import com.woocommerce.android.ui.orders.details.OrderStatusSelectorDialog.Companion.KEY_ORDER_STATUS_RESULT
-import com.woocommerce.android.ui.orders.details.views.OrderDetailOrderStatusView
 import com.woocommerce.android.ui.products.selector.ProductSelectorFragment
 import com.woocommerce.android.ui.products.selector.ProductSelectorFragmentArgs
 import com.woocommerce.android.ui.products.selector.ProductSelectorSharedViewModel
@@ -312,7 +311,6 @@ class OrderCreateEditFormFragment :
 
             is Edit -> {
                 orderStatusView.initView(
-                    mode = OrderDetailOrderStatusView.Mode.OrderEdit,
                     editOrderStatusClickListener = {
                         viewModel.orderStatusData.value?.let {
                             viewModel.onEditOrderStatusClicked(it)

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/details/OrderDetailFragment.kt

@@ -79,7 +79,6 @@ import com.woocommerce.android.ui.orders.creation.shipping.ShippingLineDetails
 import com.woocommerce.android.ui.orders.details.adapter.OrderDetailShippingLabelsAdapter.OnShippingLabelClickListener
 import com.woocommerce.android.ui.orders.details.editing.OrderEditingViewModel
 import com.woocommerce.android.ui.orders.details.views.OrderDetailAttributionInfoView
-import com.woocommerce.android.ui.orders.details.views.OrderDetailOrderStatusView.Mode
 import com.woocommerce.android.ui.orders.details.views.OrderDetailWooShippingShipmentListView
 import com.woocommerce.android.ui.orders.fulfill.OrderFulfillViewModel
 import com.woocommerce.android.ui.orders.list.OrderListFragment
@@ -236,7 +235,7 @@ class OrderDetailFragment :
         setupResultHandlers(viewModel)
         setupOrdersCommunicationObservers(communicationViewModel)
 
-        binding.orderDetailOrderStatus.initView(mode = Mode.OrderEdit) {
+        binding.orderDetailOrderStatus.initView {
             viewModel.onEditOrderStatusSelected()
         }
         binding.orderRefreshLayout.apply {

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/details/views/OrderDetailOrderStatusView.kt

@@ -52,31 +52,12 @@ class OrderDetailOrderStatusView @JvmOverloads constructor(
         return "${date.getMediumDate(context)}, ${date.getTimeString(context)}"
     }
 
-    fun initView(mode: Mode, editOrderStatusClickListener: EditStatusClickListener? = null) {
-        when (mode) {
-            Mode.OrderEdit -> {
-                val listener = requireNotNull(editOrderStatusClickListener) {
-                    "editOrderStatusClickListener must be provided when mode is OrderEdit"
-                }
-                binding.orderStatusEditImage.isVisible = true
-                with(binding.orderStatusContainer) {
-                    isClickable = true
-                    isFocusable = true
-                    setOnClickListener(listener)
-                }
-            }
-            Mode.ReadOnly -> {
-                binding.orderStatusEditImage.isVisible = false
-                with(binding.orderStatusContainer) {
-                    isClickable = false
-                    isFocusable = false
-                    setOnClickListener(null)
-                }
-            }
+    fun initView(editOrderStatusClickListener: EditStatusClickListener) {
+        binding.orderStatusEditImage.isVisible = true
+        with(binding.orderStatusContainer) {
+            isClickable = true
+            isFocusable = true
+            setOnClickListener(editOrderStatusClickListener)
         }
     }
-
-    enum class Mode {
-        OrderEdit, ReadOnly
-    }
 }