[WOOMOB-3390] Revert order-status CIAB gating

[AdamGrzybkowski]

Description

Fixes WOOMOB-3390

Sub-task of the CIAB ("Commerce In A Box") retirement on Android. On CIAB sites, order statuses are currently gated in two ways: the full status list is collapsed into a single "Open" status, statuses are shown read-only (non-editable), and status filters are grouped/remapped. This PR reverts that gating so order statuses behave the same on every site — full editable status list, no "Open" collapsing — and removes the now-unused order-status CIAB machinery entirely.

Stacked PR: this targets issue/WOOMOB-3387-revert-ipp-gating (the IPP-gating revert), not trunk. It should merge after that base. It is otherwise independent and safe to ship on its own.

What changed:

• Editing gate removed (always editable). OrderDetailFragment, OrderCreateEditFormFragment, and OrderListFragment no longer branch on CIABAffectedFeature.OrderStatusEditing; the status view is always Mode.OrderEdit and multi-select is always enabled. The ciabSiteGateKeeper field was dropped from these fragments (it was used only for this gate).
• Status-mapper routing removed. Every CIABOrderStatusMapper transform call (mapOrderStatus, mapOrderStatusOptionsList, mapFilterOptions, resolveFilterKeys) was inlined to use the input unchanged, and the injected ciabOrderStatusMapper was removed from OrderListViewModel, OrderDetailViewModel, OrderCreateEditViewModel, DashboardOrdersViewModel, GetOrderStatusFilterOptions, GetWCOrderListDescriptorWithFilters, and GetWCOrderListDescriptorWithFiltersBySiteId.
• CIABOrderStatusMapper deleted. With all transform callers inlined, the class and its remaining static OPEN_KEY references became dead. Removed the class + its test, the three now-dead "Open"-status display branches (OrderStatusTag, AiAssistantOrderCardRenderer, and the DashboardOrdersViewModel status-color helper — a custom "open" status now falls through to the default color like any other custom status), and the now-unused ciab_order_status_open source string. (Translated copies are GlotPress-managed and cleaned up by the translation sync.)
• Enum cleanup. Removed the now-unused OrderStatusEditing value from CIABAffectedFeature (mirrors the base branch removing InPersonPayments).
• Tests. Dropped the ciabOrderStatusMapper mock wiring from the four affected ViewModel tests (they already stubbed it as identity, so behavior is unchanged) and removed the CIAB "open"-status color test from AiAssistantOrderCardRendererTest. Kept the ciabSiteGateKeeper mock in OrderDetailViewModelTest (still used for the unrelated "is CIAB -> fetch fulfillments" logic).

Test Steps

1. Open the Order list — the status filter shows the full set of statuses (Processing, Pending, On hold, Completed, Failed, etc.), not a single "Open" status.
2. Long-press an order in the list — multi-select is available.
3. Open an order's details — tap the order status; the status is editable (opens the status picker) rather than read-only, and shows the real underlying status.
4. Create/edit an order — in edit mode the order status is editable.
5. Open the dashboard Orders card — order rows show their real statuses/colors and the status filter uses the full status list.

Images/gif

N/A

• I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Build Number	768
	Version	25.1-rc-2
	Application ID	com.woocommerce.android.prealpha
	Commit	042bfec
	Installation URL	3tgmcgl7fhnrg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 37.93103% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.14%. Comparing base (54dbaca) to head (042bfec).
⚠️ Report is 10 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...ters/domain/GetWCOrderListDescriptorWithFilters.kt	0.00%	4 Missing ⚠️
...ist/GetWCOrderListDescriptorWithFiltersBySiteId.kt	0.00%	4 Missing ⚠️
...erce/android/ui/orders/list/OrderListRepository.kt	20.00%	4 Missing ⚠️
...ders/filters/domain/GetOrderStatusFilterOptions.kt	0.00%	3 Missing ⚠️
...id/ui/dashboard/orders/DashboardOrdersViewModel.kt	88.88%	0 Missing and 1 partial ⚠️
...oid/ui/orders/creation/OrderCreateEditViewModel.kt	0.00%	1 Missing ⚠️
...merce/android/ui/orders/list/OrderListViewModel.kt	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #16181      +/-   ##
============================================
- Coverage     42.15%   42.14%   -0.02%     
+ Complexity    13492    13476      -16     
============================================
  Files          2474     2473       -1     
  Lines        142821   142750      -71     
  Branches      20650    20639      -11     
============================================
- Hits          60212    60157      -55     
+ Misses        76524    76514      -10     
+ Partials       6085     6079       -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

This PR removes CIAB-specific order-status gating and mapping so order statuses behave consistently across all sites (full editable status list, no “Open” collapsing), and deletes the now-dead CIAB order-status machinery across UI, domain, and tests.

Changes:

• Removed CIABOrderStatusMapper usage throughout orders/dashboard flows and deleted the mapper + its unit tests and related “open” status UI branches/resources.
• Made order-status UI always editable and enabled multi-select unconditionally (removed CIAB feature gating in fragments).
• Simplified dashboard “top orders” filtering in OrderListRepository/DashboardOrdersViewModel from multi-status lists to a single nullable status filter, updating tests accordingly.

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
WooCommerce/src/test/kotlin/com/woocommerce/android/ui/orders/OrderListViewModelTest.kt	Removes CIAB mapper mocking/wiring from order list VM tests.
WooCommerce/src/test/kotlin/com/woocommerce/android/ui/orders/OrderDetailViewModelTest.kt	Removes CIAB mapper mocking/wiring from order detail VM tests.
WooCommerce/src/test/kotlin/com/woocommerce/android/ui/orders/creation/UnifiedOrderEditViewModelTest.kt	Removes CIAB mapper dependency from unified order edit VM test setup.
WooCommerce/src/test/kotlin/com/woocommerce/android/ui/dashboard/orders/DashboardOrdersViewModelTest.kt	Updates mocks/stubs for new nullable single-status filter API on repository calls.
WooCommerce/src/test/kotlin/com/woocommerce/android/ui/aiassistant/AiAssistantOrderCardRendererTest.kt	Removes CIAB “open” status color test expectation.
WooCommerce/src/test/kotlin/com/woocommerce/android/ciab/CIABOrderStatusMapperTest.kt	Deletes mapper tests (mapper removed).
WooCommerce/src/main/res/values/strings.xml	Removes CIAB “Open” status string resource.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/OrderStatusTag.kt	Removes special-case coloring for CIAB “open” status key.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/list/OrderListViewModel.kt	Removes CIAB mapper injection and identity mapping for status options.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/list/OrderListRepository.kt	Changes dashboard top-orders filtering from list-of-statuses to single nullable status.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/list/OrderListFragment.kt	Always enables multi-select (removes CIAB feature gate).
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/list/GetWCOrderListDescriptorWithFiltersBySiteId.kt	Removes CIAB filter-key expansion; passes selected keys through unchanged.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/filters/domain/GetWCOrderListDescriptorWithFilters.kt	Removes CIAB filter-key expansion; passes selected keys through unchanged.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/filters/domain/GetOrderStatusFilterOptions.kt	Removes CIAB option grouping/mapping; returns raw options list.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/details/OrderDetailViewModel.kt	Removes CIAB status mapping when resolving order status.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/details/OrderDetailFragment.kt	Always initializes status view in editable mode (no CIAB gating).
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/creation/OrderCreateEditViewModel.kt	Removes CIAB status mapping when observing status data.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/creation/OrderCreateEditFormFragment.kt	Always initializes order status view as editable in edit mode.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/dashboard/orders/DashboardOrdersViewModel.kt	Removes CIAB status mapping + “open” color special-casing; uses raw status/options.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/aiassistant/AiAssistantOrderCardRenderer.kt	Removes CIAB “open” status special-case color mapping.
WooCommerce/src/main/kotlin/com/woocommerce/android/ciab/CIABOrderStatusMapper.kt	Deletes mapper implementation (no longer used).
WooCommerce/src/main/kotlin/com/woocommerce/android/ciab/CIABAffectedFeature.kt	Removes OrderStatusEditing enum entry (no longer used).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[dangermattic]

	1 Warning
⚠️	View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

[irfano]

LGTM! 👍🏻 Thanks for the changes.