Skip to content

Commit 1f8f644

Browse files
authored
Merge pull request #1182 from wordpress-mobile/static-framework
Compatibility with both CocoaPods dynamic and static frameworks
2 parents 81fe4db + 912e1ab commit 1f8f644

4 files changed

Lines changed: 25 additions & 3 deletions

File tree

Aztec.xcodeproj/project.pbxproj

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
objects = {
88

99
/* Begin PBXBuildFile section */
10+
1A830346228583B200798076 /* NSBundle+AztecBundle.swift in Sources */ = {isa = PBXBuildFile; fileRef = 1A830345228583B200798076 /* NSBundle+AztecBundle.swift */; };
1011
40359F261FD88A5F00B1C1D2 /* HRElementConverter.swift in Sources */ = {isa = PBXBuildFile; fileRef = 40359F251FD88A5F00B1C1D2 /* HRElementConverter.swift */; };
1112
40359F281FD88A7900B1C1D2 /* BRElementConverter.swift in Sources */ = {isa = PBXBuildFile; fileRef = 40359F271FD88A7900B1C1D2 /* BRElementConverter.swift */; };
1213
40A2986D1FD61B0C00AEDF3B /* ElementConverter.swift in Sources */ = {isa = PBXBuildFile; fileRef = 40A2986C1FD61B0C00AEDF3B /* ElementConverter.swift */; };
@@ -272,6 +273,7 @@
272273
/* End PBXCopyFilesBuildPhase section */
273274

274275
/* Begin PBXFileReference section */
276+
1A830345228583B200798076 /* NSBundle+AztecBundle.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "NSBundle+AztecBundle.swift"; sourceTree = "<group>"; };
275277
40359F251FD88A5F00B1C1D2 /* HRElementConverter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = HRElementConverter.swift; sourceTree = "<group>"; };
276278
40359F271FD88A7900B1C1D2 /* BRElementConverter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BRElementConverter.swift; sourceTree = "<group>"; };
277279
40A2986C1FD61B0C00AEDF3B /* ElementConverter.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ElementConverter.swift; sourceTree = "<group>"; };
@@ -733,6 +735,7 @@
733735
F10BE6191EA7AE9D002E4625 /* NSAttributedString+ReplaceOcurrences.swift */,
734736
F12328761FB638C6001E35EF /* NSAttributedStringKey+Aztec.swift */,
735737
B574F4A31FB0CF3A0048F355 /* NSAttributedStringKey+Conversion.swift */,
738+
1A830345228583B200798076 /* NSBundle+AztecBundle.swift */,
736739
FFD0FEB61DAE59A700430586 /* NSLayoutManager+Attachments.swift */,
737740
F1584795203C9B4C00EE05A1 /* NSMutableAttributedString+ParagraphProperty.swift */,
738741
F10BE6171EA7ADA6002E4625 /* NSMutableAttributedString+ReplaceOcurrences.swift */,
@@ -1576,6 +1579,7 @@
15761579
F15BA60D215159A600424120 /* ItalicStringAttributeConverter.swift in Sources */,
15771580
F1656FDC2152A00E009C7E3A /* ConditionalStringAttributeConverter.swift in Sources */,
15781581
599F25541D8BC9A1002871D6 /* TextView.swift in Sources */,
1582+
1A830346228583B200798076 /* NSBundle+AztecBundle.swift in Sources */,
15791583
F1E1D5801FEC44B30086B339 /* AttachmentElementConverter.swift in Sources */,
15801584
F1BDDDE520603C18000714E1 /* FigcaptionFormatter.swift in Sources */,
15811585
B524228D1F30C039002E7C6C /* HTMLDiv.swift in Sources */,
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
import Foundation
2+
3+
extension Bundle {
4+
@objc public class var aztecBundle: Bundle {
5+
let defaultBundle = Bundle(for: EditorView.self)
6+
// If installed with CocoaPods, resources will be in WordPress-Aztec-iOS.bundle
7+
if let bundleURL = defaultBundle.resourceURL,
8+
let resourceBundle = Bundle(url: bundleURL.appendingPathComponent("WordPress-Aztec-iOS")) {
9+
return resourceBundle
10+
}
11+
// Otherwise, the default bundle is used for resources
12+
return defaultBundle
13+
}
14+
}

Aztec/Classes/GUI/Assets.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ import UIKit
44
class Assets {
55

66
public static var playIcon: UIImage {
7-
let bundle = Bundle(for: self)
7+
let bundle = Bundle.aztecBundle
88
let playImage = UIImage(named: "play", in: bundle, compatibleWith: nil)!
99
return playImage
1010
}
1111

1212
public static var imageIcon: UIImage {
13-
let bundle = Bundle(for: self)
13+
let bundle = Bundle.aztecBundle
1414
let playImage = UIImage(named: "image", in: bundle, compatibleWith: nil)!
1515
return playImage
1616
}

WordPress-Aztec-iOS.podspec

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,11 @@ Pod::Spec.new do |s|
3232

3333
s.module_name = "Aztec"
3434
s.source_files = 'Aztec/Classes/**/*'
35-
s.resources = 'Aztec/Assets/**/*'
35+
s.resource_bundles = {
36+
'WordPress-Aztec-iOS': [
37+
"Aztec/Assets/**/*"
38+
]
39+
}
3640

3741
s.xcconfig = {'OTHER_LDFLAGS' => '-lxml2',
3842
'HEADER_SEARCH_PATHS' => '/usr/include/libxml2'}

0 commit comments

Comments
 (0)