Fix crash in CommentAttachmentRenderer when attempting to render Gutenberg comments

itsmeichigo · itsmeichigo · commit cf10e7b63f20 · 2024-01-31T15:12:58.000+07:00
diff --git a/Aztec/Classes/Renderers/CommentAttachmentRenderer.swift b/Aztec/Classes/Renderers/CommentAttachmentRenderer.swift
@@ -36,15 +36,15 @@ extension CommentAttachmentRenderer: TextViewAttachmentImageProvider {
     }
 
     public func textView(_ textView: TextView, imageFor attachment: NSTextAttachment, with size: CGSize) -> UIImage? {
-        UIGraphicsBeginImageContextWithOptions(size, false, 0)
-
         // Either this is a comment attachment, or the logic is broken.
         let commentAttachment = attachment as! CommentAttachment
 
         guard !isGutenbergComment(commentAttachment) else {
             return nil
         }
 
+        UIGraphicsBeginImageContextWithOptions(size, false, 0)
+
         let message = messageAttributedString()
         let targetRect = boundingRect(for: message, size: size)
 

Original file line number	Diff line number	Diff line change
`@@ -36,15 +36,15 @@ extension CommentAttachmentRenderer: TextViewAttachmentImageProvider {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`public func textView(_ textView: TextView, imageFor attachment: NSTextAttachment, with size: CGSize) -> UIImage? {`
`39`		`- UIGraphicsBeginImageContextWithOptions(size, false, 0)`
`40`		`-`
`41`	`39`	`// Either this is a comment attachment, or the logic is broken.`
`42`	`40`	`let commentAttachment = attachment as! CommentAttachment`
`43`	`41`
`44`	`42`	`guard !isGutenbergComment(commentAttachment) else {`
`45`	`43`	`return nil`
`46`	`44`	`}`
`47`	`45`
	`46`	`+ UIGraphicsBeginImageContextWithOptions(size, false, 0)`
	`47`	`+`
`48`	`48`	`let message = messageAttributedString()`
`49`	`49`	`let targetRect = boundingRect(for: message, size: size)`
`50`	`50`