Add explanatory comments to the conditional HTMLParser imports

mokagio · mokagio · commit d06fadb3e534 · 2025-06-16T14:24:34.000+10:00
diff --git a/Tests/AztecTests/Converters/AttributesToStringAttributes/BoldElementAttributeConverterTests.swift b/Tests/AztecTests/Converters/AttributesToStringAttributes/BoldElementAttributeConverterTests.swift
@@ -1,5 +1,9 @@
 import XCTest
 @testable import Aztec
+// This test exercises sources from the Aztec target, but also uses internal APIs from HTMLParser.
+//
+// The HTMLParser target exists only when building for Swift package manager.
+// Otherwise, such as when building via CocoaPods, its sources are part of Aztec.
 #if SWIFT_PACKAGE
 @testable import HTMLParser
 #endif
diff --git a/Tests/AztecTests/Converters/AttributesToStringAttributes/ItalicElementAttributeConverterTests.swift b/Tests/AztecTests/Converters/AttributesToStringAttributes/ItalicElementAttributeConverterTests.swift
@@ -1,5 +1,6 @@
 import XCTest
 @testable import Aztec
+// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
 #if SWIFT_PACKAGE
 @testable import HTMLParser
 #endif
diff --git a/Tests/AztecTests/Converters/AttributesToStringAttributes/UnderlineElementAttributeConverterTests.swift b/Tests/AztecTests/Converters/AttributesToStringAttributes/UnderlineElementAttributeConverterTests.swift
@@ -1,5 +1,6 @@
 import XCTest
 @testable import Aztec
+// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
 #if SWIFT_PACKAGE
 @testable import HTMLParser
 #endif
diff --git a/Tests/AztecTests/Converters/StringAttributesToAttributes/BoldStringAttributeConverterTests.swift b/Tests/AztecTests/Converters/StringAttributesToAttributes/BoldStringAttributeConverterTests.swift
@@ -1,5 +1,6 @@
 import XCTest
 @testable import Aztec
+// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
 #if SWIFT_PACKAGE
 @testable import HTMLParser
 #endif
diff --git a/Tests/AztecTests/Converters/StringAttributesToAttributes/ItalicStringAttributeConverterTests.swift b/Tests/AztecTests/Converters/StringAttributesToAttributes/ItalicStringAttributeConverterTests.swift
@@ -1,5 +1,6 @@
 import XCTest
 @testable import Aztec
+// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
 #if SWIFT_PACKAGE
 @testable import HTMLParser
 #endif
diff --git a/Tests/AztecTests/Importer/InAttributeConverterTests.swift b/Tests/AztecTests/Importer/InAttributeConverterTests.swift
@@ -1,5 +1,6 @@
 import XCTest
 import libxml2
+// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
 #if SWIFT_PACKAGE
 @testable import HTMLParser
 #else
diff --git a/Tests/AztecTests/Importer/InNodeConverterTests.swift b/Tests/AztecTests/Importer/InNodeConverterTests.swift
@@ -1,5 +1,6 @@
 import XCTest
 import libxml2
+// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
 #if SWIFT_PACKAGE
 @testable import HTMLParser
 #else
diff --git a/Tests/AztecTests/NSAttributedString/Conversions/AttributedStringSerializerTests.swift b/Tests/AztecTests/NSAttributedString/Conversions/AttributedStringSerializerTests.swift
@@ -1,5 +1,6 @@
 import XCTest
 @testable import Aztec
+// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
 #if SWIFT_PACKAGE
 @testable import HTMLParser
 #endif
diff --git a/Tests/HTMLParserTests/HTML/Conversions/CSSParserTests.swift b/Tests/HTMLParserTests/HTML/Conversions/CSSParserTests.swift
@@ -1,4 +1,5 @@
 import XCTest
+// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
 #if SWIFT_PACKAGE
 @testable import HTMLParser
 #else
diff --git a/Tests/HTMLParserTests/HTML/Conversions/DefaultHTMLSerializerTests.swift b/Tests/HTMLParserTests/HTML/Conversions/DefaultHTMLSerializerTests.swift
@@ -1,4 +1,5 @@
 import XCTest
+// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
 #if SWIFT_PACKAGE
 @testable import HTMLParser
 #else
diff --git a/Tests/HTMLParserTests/HTML/Conversions/HTMLParserTests.swift b/Tests/HTMLParserTests/HTML/Conversions/HTMLParserTests.swift
@@ -1,4 +1,5 @@
 import XCTest
+// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
 #if SWIFT_PACKAGE
 @testable import HTMLParser
 #else
diff --git a/Tests/HTMLParserTests/HTML/Nodes/ElementNodeTests.swift b/Tests/HTMLParserTests/HTML/Nodes/ElementNodeTests.swift
@@ -1,4 +1,5 @@
 import XCTest
+// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
 #if SWIFT_PACKAGE
 @testable import HTMLParser
 #else
diff --git a/Tests/HTMLParserTests/HTML/Nodes/TextNodeTests.swift b/Tests/HTMLParserTests/HTML/Nodes/TextNodeTests.swift
@@ -1,4 +1,5 @@
 import XCTest
+// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
 #if SWIFT_PACKAGE
 @testable import HTMLParser
 #else

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`import XCTest`
	`2`	`+// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.`
`2`	`3`	`#if SWIFT_PACKAGE`
`3`	`4`	`@testable import HTMLParser`
`4`	`5`	`#else`