Merge pull request #1186 from wordpress-mobile/issue/make_s_default_for_striketrough

SergioEstevao · web-flow · commit f71dd29a41f1 · 2019-05-16T12:18:05.000+01:00
Make default HTML elements to represent striketrough to be s
diff --git a/Aztec/Classes/NSAttributedString/Conversions/AttributedStringParser.swift b/Aztec/Classes/NSAttributedString/Conversions/AttributedStringParser.swift
@@ -899,7 +899,7 @@ private extension AttributedStringParser {
             return representationElement.toElementNode()
         }
 
-        return ElementNode(type: .strike)
+        return ElementNode(type: .s)
     }
 
     /// Extracts all of the Code Elements contained within a collection of Attributes.
diff --git a/AztecTests/NSAttributedString/Conversions/AttributedStringParserTests.swift b/AztecTests/NSAttributedString/Conversions/AttributedStringParserTests.swift
@@ -134,7 +134,7 @@ class AttributedStringParserTests: XCTestCase {
             XCTFail()
             return
         }
-        XCTAssertEqual(strike.name, Element.strike.rawValue)
+        XCTAssertEqual(strike.name, Element.s.rawValue)
         XCTAssertEqual(strike.children.count, 1)
 
         guard let text = strike.children.first as? TextNode else {

Original file line number	Diff line number	Diff line change
`@@ -899,7 +899,7 @@ private extension AttributedStringParser {`
`899`	`899`	`return representationElement.toElementNode()`
`900`	`900`	`}`
`901`	`901`
`902`		`- return ElementNode(type: .strike)`
	`902`	`+ return ElementNode(type: .s)`
`903`	`903`	`}`
`904`	`904`
`905`	`905`	`/// Extracts all of the Code Elements contained within a collection of Attributes.`
Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ class AttributedStringParserTests: XCTestCase {`
`134`	`134`	`XCTFail()`
`135`	`135`	`return`
`136`	`136`	`}`
`137`		`- XCTAssertEqual(strike.name, Element.strike.rawValue)`
	`137`	`+ XCTAssertEqual(strike.name, Element.s.rawValue)`
`138`	`138`	`XCTAssertEqual(strike.children.count, 1)`
`139`	`139`
`140`	`140`	`guard let text = strike.children.first as? TextNode else {`