Skip to content

Commit 00c516b

Browse files
committed
Draw background image behind large text using paint modifier
This is a better approach since the image is decorative and we don't need a separate composable for it
1 parent 20198c9 commit 00c516b

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

WordPress/src/jetpack/java/org/wordpress/android/ui/accounts/login/components/LoopingTextWithBackground.kt

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
11
package org.wordpress.android.ui.accounts.login.components
22

33
import android.content.res.Configuration
4-
import androidx.compose.foundation.Image
54
import androidx.compose.foundation.background
65
import androidx.compose.foundation.layout.Box
76
import androidx.compose.foundation.layout.fillMaxSize
87
import androidx.compose.foundation.layout.padding
98
import androidx.compose.runtime.Composable
109
import androidx.compose.ui.Modifier
10+
import androidx.compose.ui.draw.paint
1111
import androidx.compose.ui.layout.ContentScale
1212
import androidx.compose.ui.res.colorResource
1313
import androidx.compose.ui.res.painterResource
14-
import androidx.compose.ui.res.stringResource
1514
import androidx.compose.ui.tooling.preview.Devices
1615
import androidx.compose.ui.tooling.preview.Preview
1716
import androidx.compose.ui.unit.dp
@@ -23,13 +22,15 @@ fun LoopingTextWithBackground(
2322
modifier: Modifier = Modifier,
2423
textModifier: Modifier = Modifier,
2524
) {
26-
Box(modifier.background(colorResource(R.color.bg_jetpack_login_splash))) {
27-
Image(
28-
painter = painterResource(R.drawable.bg_jetpack_login_splash),
29-
contentDescription = stringResource(R.string.login_prologue_revamped_content_description_bg),
30-
contentScale = ContentScale.FillBounds,
31-
modifier = Modifier.matchParentSize(),
32-
)
25+
Box(
26+
modifier
27+
.background(colorResource(R.color.bg_jetpack_login_splash))
28+
.paint(
29+
painter = painterResource(R.drawable.bg_jetpack_login_splash),
30+
sizeToIntrinsics = true,
31+
contentScale = ContentScale.FillBounds,
32+
)
33+
) {
3334
LoopingText(
3435
modifier = Modifier
3536
.fillMaxSize()

WordPress/src/jetpack/res/values/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
<string name="app_tagline">Site security and performance from your pocket</string>
1414
<string name="continue_with_wpcom_no_signup">Continue with WordPress.com</string>
1515
<string name="login_prologue_revamped_content_description_jetpack_logo">Jetpack logo</string>
16-
<string name="login_prologue_revamped_content_description_bg">Jetpack background</string>
1716
<string name="login_prologue_revamped_content_description_top_bg">Jetpack top background fade</string>
1817

1918
<string name="login_prologue_revamped_jetpack_feature_text_1">Update a plugin</string>

0 commit comments

Comments
 (0)