Implement unit tests for ClientVerification

Author: RenanLukas

WordPress/src/main/java/org/wordpress/android/util/publicdata/ClientVerification.kt

@@ -10,13 +10,13 @@ class ClientVerification @Inject constructor(
     private val contextProvider: ContextProvider,
 ) {
 
-    fun canTrust(callingPackage: String?): Boolean {
-        if (callingPackage == null) {
+    fun canTrust(callerPackage: String?): Boolean {
+        if (callerPackage == null) {
             return false
         }
         val callerExpectedPackageId = jetpackPublicData.currentPackageId()
         val callerSignatureHash = signatureUtils.getSignatureHash(contextProvider.getContext(), callerExpectedPackageId)
         val callerExpectedSignatureHash = jetpackPublicData.currentPublicKeyHash()
-        return callingPackage == callerExpectedPackageId && callerSignatureHash == callerExpectedSignatureHash
+        return callerPackage == callerExpectedPackageId && callerSignatureHash == callerExpectedSignatureHash
     }
 }

WordPress/src/test/java/org/wordpress/android/util/publicdata/ClientVerificationTest.kt

@@ -0,0 +1,76 @@
+package org.wordpress.android.util.publicdata
+
+import com.nhaarman.mockitokotlin2.mock
+import com.nhaarman.mockitokotlin2.verify
+import com.nhaarman.mockitokotlin2.whenever
+import org.junit.Assert
+import org.junit.Before
+import org.junit.Test
+import org.wordpress.android.util.signature.SignatureUtils
+import org.wordpress.android.viewmodel.ContextProvider
+
+class ClientVerificationTest {
+    private val jetpackPublicData: JetpackPublicData = mock()
+    private val signatureUtils: SignatureUtils = mock()
+    private val contextProvider: ContextProvider = mock()
+    private val classToTest = ClientVerification(jetpackPublicData, signatureUtils, contextProvider)
+
+    private val expectedPackage = "match"
+    private val expectedSignatureHash = "signatureHash"
+
+    @Before
+    fun setup() {
+        whenever(jetpackPublicData.currentPackageId()).thenReturn(expectedPackage)
+        whenever(jetpackPublicData.currentPublicKeyHash()).thenReturn(expectedSignatureHash)
+        whenever(signatureUtils.getSignatureHash(contextProvider.getContext(), expectedPackage))
+                .thenReturn(expectedSignatureHash)
+    }
+
+    @Test
+    fun `Should return false if calling package is null when canTrust is called`() {
+        val expected = false
+        val actual = classToTest.canTrust(null)
+        Assert.assertEquals(expected, actual)
+    }
+
+    @Test
+    fun `Should return false if caller package does not match the expected when canTrust is called`() {
+        val expected = false
+        val actual = classToTest.canTrust("no_match")
+        Assert.assertEquals(expected, actual)
+    }
+
+    @Test
+    fun `Should return false if caller signature hash does not match the expected when canTrust is called`() {
+        whenever(signatureUtils.getSignatureHash(contextProvider.getContext(), expectedPackage))
+                .thenReturn("no_match")
+        val expected = false
+        val actual = classToTest.canTrust(expectedPackage)
+        Assert.assertEquals(expected, actual)
+    }
+
+    @Test
+    fun `Should return true if caller package and signature hash match the expected when canTrust is called`() {
+        val expected = true
+        val actual = classToTest.canTrust(expectedPackage)
+        Assert.assertEquals(expected, actual)
+    }
+
+    @Test
+    fun `Should call jetpackPublicData currentPackageId when canTrust is called`() {
+        classToTest.canTrust(expectedPackage)
+        verify(jetpackPublicData).currentPackageId()
+    }
+
+    @Test
+    fun `Should call signatureUtils getSignatureHash when canTrust is called`() {
+        classToTest.canTrust(expectedPackage)
+        verify(signatureUtils).getSignatureHash(contextProvider.getContext(), expectedPackage)
+    }
+
+    @Test
+    fun `Should call jetpackPublicData currentPublicKeyHash when canTrust is called`() {
+        classToTest.canTrust(expectedPackage)
+        verify(jetpackPublicData).currentPublicKeyHash()
+    }
+}