Merge pull request #17293 from wordpress-mobile/analysis/wordpress-main-other-warnings

[Compile Warnings As Errors] WordPress Module - Resolve Other Warnings

Author: zwarm

WordPress/src/main/java/org/wordpress/android/AppInitializer.kt

@@ -533,7 +533,7 @@ class AppInitializer @Inject constructor(
         }
     }
 
-    @SuppressWarnings("unused")
+    @Suppress("unused", "UNUSED_PARAMETER")
     @Subscribe(threadMode = ThreadMode.MAIN)
     fun onAuthenticationChanged(event: OnAuthenticationChanged) {
         if (accountStore.hasAccessToken()) {

WordPress/src/main/java/org/wordpress/android/WordPress.kt

@@ -54,15 +54,15 @@ abstract class WordPress : MultiDexApplication() {
         @JvmStatic
         fun getRestClientUtils() = AppInitializer.restClientUtils
 
-        @SuppressWarnings("FunctionNaming")
+        @Suppress("FunctionNaming")
         @JvmStatic
         fun getRestClientUtilsV1_1() = AppInitializer.restClientUtilsV1_1
 
-        @SuppressWarnings("FunctionNaming")
+        @Suppress("FunctionNaming")
         @JvmStatic
         fun getRestClientUtilsV1_2() = AppInitializer.restClientUtilsV1_2
 
-        @SuppressWarnings("FunctionNaming")
+        @Suppress("FunctionNaming")
         @JvmStatic
         fun getRestClientUtilsV1_3() = AppInitializer.restClientUtilsV1_3
 

WordPress/src/main/java/org/wordpress/android/ui/JetpackRemoteInstallViewModel.kt

@@ -147,8 +147,8 @@ class JetpackRemoteInstallViewModel
     }
 
     // Network Callbacks
+    @Suppress("unused")
     @Subscribe(threadMode = ThreadMode.BACKGROUND)
-    @SuppressWarnings("unused")
     fun onEventsUpdated(event: OnJetpackInstalled) {
         val site = siteModel ?: return
         if (event.isError) {

WordPress/src/main/java/org/wordpress/android/ui/domains/DomainsDashboardViewModel.kt

@@ -224,7 +224,6 @@ class DomainsDashboardViewModel @Inject constructor(
                 TODO("Not yet implemented")
             }
         }
-        return true
     }
 
     fun onSuccessfulDomainRegistration() {

WordPress/src/main/java/org/wordpress/android/ui/engagement/GetLikesUseCase.kt

@@ -46,10 +46,8 @@ import kotlin.coroutines.suspendCoroutine
 class GetLikesUseCase @Inject constructor(
     private val networkUtilsWrapper: NetworkUtilsWrapper,
     private val dispatcher: Dispatcher,
-    @SuppressWarnings("Unused")
-    val commentStore: CommentStore,
-    @SuppressWarnings("Unused")
-    val postStore: PostStore,
+    @Suppress("Unused") val commentStore: CommentStore,
+    @Suppress("Unused") val postStore: PostStore,
     val accountStore: AccountStore
 ) {
     private var getLikesContinuations = mutableMapOf<String, Continuation<OnChanged<*>>>()
@@ -76,7 +74,7 @@ class GetLikesUseCase @Inject constructor(
         getLikes(COMMENT_LIKE, this, fingerPrint, paginationParams)
     }
 
-    @SuppressWarnings("ComplexMethod", "NestedBlockDepth", "LoopWithTooManyJumpStatements")
+    @Suppress("ComplexMethod", "NestedBlockDepth", "LoopWithTooManyJumpStatements")
     private suspend fun getLikes(
         category: LikeCategory,
         flow: FlowCollector<GetLikesState>,

WordPress/src/main/java/org/wordpress/android/ui/jetpack/JetpackCapabilitiesUseCase.kt

@@ -96,8 +96,8 @@ class JetpackCapabilitiesUseCase @Inject constructor(
         )
     }
 
+    @Suppress("unused")
     @Subscribe(threadMode = ThreadMode.MAIN)
-    @SuppressWarnings("unused")
     fun onJetpackCapabilitiesFetched(event: OnJetpackCapabilitiesFetched) {
         continuation[event.remoteSiteId]?.let {
             continuation.remove(event.remoteSiteId)

WordPress/src/main/java/org/wordpress/android/ui/main/MeFragment.kt

@@ -586,7 +586,7 @@ class MeFragment : Fragment(R.layout.me_fragment), OnScrollToTopListener {
         }
     }
 
-    @SuppressWarnings("unused")
+    @Suppress("unused", "UNUSED_PARAMETER")
     @Subscribe(threadMode = ThreadMode.MAIN)
     fun onAccountChanged(event: OnAccountChanged?) {
         binding?.refreshAccountDetails()

WordPress/src/main/java/org/wordpress/android/ui/mediapicker/loader/DeviceMediaLoader.kt

@@ -2,7 +2,6 @@ package org.wordpress.android.ui.mediapicker.loader
 
 import android.content.ContentResolver
 import android.content.Context
-import android.database.Cursor
 import android.net.Uri
 import android.os.Build.VERSION
 import android.os.Build.VERSION_CODES
@@ -42,7 +41,6 @@ class DeviceMediaLoader
         }
         val result = mutableListOf<DeviceMediaItem>()
         val projection = arrayOf(ID_COL, ID_DATE_MODIFIED, ID_TITLE)
-        var cursor: Cursor? = null
         val dateCondition = if (limitDate != null && limitDate != 0L) {
             "$ID_DATE_MODIFIED <= \'$limitDate\'"
         } else {
@@ -55,11 +53,8 @@ class DeviceMediaLoader
             dateCondition ?: filterCondition
         }
 
-        cursor = getCursor(condition, pageSize, baseUri, projection)
+        val cursor = getCursor(condition, pageSize, baseUri, projection) ?: return DeviceMediaList(listOf(), null)
 
-        if (cursor == null) {
-            return DeviceMediaList(listOf(), null)
-        }
         try {
             val idIndex = cursor.getColumnIndexOrThrow(ID_COL)
             val dateIndex = cursor.getColumnIndexOrThrow(ID_DATE_MODIFIED)

WordPress/src/main/java/org/wordpress/android/ui/notifications/NotificationsDetailListFragment.kt

@@ -301,7 +301,7 @@ class NotificationsDetailListFragment : ListFragment(), NotificationFragment {
             }
         }
     }
-    private val mOnGravatarClickedListener = OnGravatarClickedListener { siteId, userId, siteUrl ->
+    private val mOnGravatarClickedListener = OnGravatarClickedListener { siteId, _, siteUrl ->
         if (!isAdded || activity !is NotificationsDetailActivity) {
             return@OnGravatarClickedListener
         }

WordPress/src/main/java/org/wordpress/android/ui/notifications/NotificationsListFragmentPage.kt

@@ -443,7 +443,7 @@ class NotificationsListFragmentPage : ViewPagerFragment(R.layout.notifications_l
         notesAdapter!!.addAll(event.notes, true)
     }
 
-    @SuppressWarnings("unused")
+    @Suppress("unused", "UNUSED_PARAMETER")
     @Subscribe(threadMode = MAIN)
     fun onEventMainThread(error: NotificationsRefreshError?) {
         if (isAdded) {