Merge pull request #19656 from wordpress-mobile/fix/19557-remove-categories-from-page-publishing

Removes category selection from page pre-publishing options

Author: Artyom Vlasov

WordPress/src/main/java/org/wordpress/android/ui/posts/prepublishing/home/PrepublishingHomeViewModel.kt

@@ -123,16 +123,18 @@ class PrepublishingHomeViewModel @Inject constructor(
                 site
             )
 
-            add(HomeUiState(
-                navigationAction = PrepublishingScreenNavigation.Categories,
-                actionResult = if (categoriesString.isNotEmpty()) {
-                    UiStringText(categoriesString)
-                } else {
-                    run { UiStringRes(R.string.prepublishing_nudges_home_categories_not_set) }
-                },
-                actionClickable = true,
-                onNavigationActionClicked = ::onActionClicked
-            ))
+            if (!editPostRepository.isPage) {
+                add(HomeUiState(
+                    navigationAction = PrepublishingScreenNavigation.Categories,
+                    actionResult = if (categoriesString.isNotEmpty()) {
+                        UiStringText(categoriesString)
+                    } else {
+                        run { UiStringRes(R.string.prepublishing_nudges_home_categories_not_set) }
+                    },
+                    actionClickable = true,
+                    onNavigationActionClicked = ::onActionClicked
+                ))
+            }
 
             add(SocialUiState.Hidden)
 

WordPress/src/test/java/org/wordpress/android/ui/posts/PrepublishingHomeViewModelTest.kt

@@ -112,7 +112,7 @@ class PrepublishingHomeViewModelTest : BaseUnitTest() {
     @Test
     fun `verify that page home actions are propagated to prepublishingHomeUiState once the viewModel is started`() {
         // arrange
-        val expectedActionsAmount = 2
+        val expectedActionsAmount = 1
         whenever(editPostRepository.isPage).thenReturn(true)
 
         // act
@@ -148,6 +148,30 @@ class PrepublishingHomeViewModelTest : BaseUnitTest() {
         assertThat(getHomeUiState(PrepublishingScreenNavigation.Tags)).isNull()
     }
 
+    @Test
+    fun `verify that categories actions is propagated to prepublishingHomeUiState once post is not a page`() {
+        // arrange
+        whenever(editPostRepository.isPage).thenReturn(false)
+
+        // act
+        viewModel.start(editPostRepository, site, false)
+
+        // assert
+        assertThat(getHomeUiState(PrepublishingScreenNavigation.Categories)).isNotNull()
+    }
+
+    @Test
+    fun `verify that categories actions is not propagated to prepublishingHomeUiState once post is a page`() {
+        // arrange
+        whenever(editPostRepository.isPage).thenReturn(true)
+
+        // act
+        viewModel.start(editPostRepository, site, false)
+
+        // assert
+        assertThat(getHomeUiState(PrepublishingScreenNavigation.Categories)).isNull()
+    }
+
     @Test
     fun `verify that header ui state is propagated to prepublishingHomeUiState once the viewModel is started`() {
         // arrange