Fix rounding issue on most popular time stats card

Author: irfano

WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/lists/sections/insights/usecases/MostPopularInsightsUseCase.kt

@@ -24,6 +24,7 @@ import org.wordpress.android.ui.stats.refresh.utils.ItemPopupMenuHandler
 import org.wordpress.android.ui.stats.refresh.utils.StatsSiteProvider
 import org.wordpress.android.util.text.PercentFormatter
 import org.wordpress.android.viewmodel.ResourceProvider
+import java.math.RoundingMode
 import javax.inject.Inject
 import javax.inject.Named
 import kotlin.math.roundToInt
@@ -75,11 +76,17 @@ class MostPopularInsightsUseCase
         } else {
             val highestDayPercent = resourceProvider.getString(
                     R.string.stats_most_popular_percent_views,
-                    percentFormatter.format(domainModel.highestDayPercent.roundToInt())
+                    percentFormatter.format(
+                            value = domainModel.highestDayPercent.roundToInt(),
+                            rounding = RoundingMode.HALF_UP
+                    )
             )
             val highestHourPercent = resourceProvider.getString(
                     R.string.stats_most_popular_percent_views,
-                    percentFormatter.format(domainModel.highestHourPercent.roundToInt())
+                    percentFormatter.format(
+                            value = domainModel.highestHourPercent.roundToInt(),
+                            rounding = RoundingMode.HALF_UP
+                    )
             )
             items.add(
                     QuickScanItem(

WordPress/src/test/java/org/wordpress/android/ui/stats/refresh/lists/sections/insights/usecases/MostPopularInsightsUseCaseTest.kt

@@ -32,6 +32,8 @@ import org.wordpress.android.ui.stats.refresh.utils.ItemPopupMenuHandler
 import org.wordpress.android.ui.stats.refresh.utils.StatsSiteProvider
 import org.wordpress.android.util.text.PercentFormatter
 import org.wordpress.android.viewmodel.ResourceProvider
+import java.math.RoundingMode
+import java.math.RoundingMode.HALF_UP
 import kotlin.math.roundToInt
 
 class MostPopularInsightsUseCaseTest : BaseUnitTest() {
@@ -66,8 +68,18 @@ class MostPopularInsightsUseCaseTest : BaseUnitTest() {
                 actionCardHandler,
                 percentFormatter
         )
-        whenever(percentFormatter.format(highestDayPercent.roundToInt())).thenReturn("10%")
-        whenever(percentFormatter.format(highestHourPercent.roundToInt())).thenReturn("20%")
+        whenever(
+                percentFormatter.format(
+                        value = highestDayPercent.roundToInt(),
+                        rounding = RoundingMode.HALF_UP
+                )
+        ).thenReturn("10%")
+        whenever(
+                percentFormatter.format(
+                        value = highestHourPercent.roundToInt(),
+                        rounding = RoundingMode.HALF_UP
+                )
+        ).thenReturn("20%")
         whenever(statsSiteProvider.siteModel).thenReturn(site)
         whenever(dateUtils.getWeekDay(day)).thenReturn(dayString)
 
@@ -127,8 +139,14 @@ class MostPopularInsightsUseCaseTest : BaseUnitTest() {
     @Test
     fun `when buildUiModel is called, should call PercentFormatter`() = test {
         useCase.buildUiModel(InsightsMostPopularModel(0, day, hour, highestDayPercent, highestHourPercent))
-        verify(percentFormatter).format(highestDayPercent.roundToInt())
-        verify(percentFormatter).format(highestHourPercent.roundToInt())
+        verify(percentFormatter).format(
+                value = highestDayPercent.roundToInt(),
+                rounding = HALF_UP
+        )
+        verify(percentFormatter).format(
+                value = highestHourPercent.roundToInt(),
+                rounding = HALF_UP
+        )
     }
 
     private fun assertTitle(item: BlockListItem) {