Guard connectivity observers against LiveData replay side effects

LiveData replays the current value to each new observer, so a side effect that
should only run on an offline->online transition also fired on open.

- SuggestionActivity: only call viewModel.onConnectionChanged (which refreshes
  suggestions) on a genuine offline->online transition. The initial replay was
  triggering a redundant fetch on top of the one started in viewModel.init().
- ReaderPostListFragment: initialise lastConnected to true so the first replayed
  "connected" value doesn't re-run the search (e.g. on a restored fragment with
  an active search); only a real transition resubmits.

Author: nbradbury

WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.kt

@@ -208,7 +208,9 @@ class ReaderPostListFragment : ViewPagerFragment(), OnPostSelectedListener, OnFo
     @Inject
     lateinit var networkConnectionMonitor: NetworkConnectionMonitor
 
-    private var lastConnected = false
+    // Initialised to true so the first LiveData replay of "connected" (e.g. on a freshly restored fragment
+    // with an active search) doesn't re-fire the search; only a genuine offline->online transition should.
+    private var lastConnected = true
 
     private var readerPostAdapter: ReaderPostAdapter? = null
     private var siteSearchAdapter: ReaderSiteSearchAdapter? = null

WordPress/src/main/java/org/wordpress/android/ui/suggestion/SuggestionActivity.kt

@@ -38,6 +38,8 @@ class SuggestionActivity : BaseAppCompatActivity() {
     lateinit var networkConnectionMonitor: NetworkConnectionMonitor
     private lateinit var binding: SuggestUsersActivityBinding
 
+    private var lastConnected = true
+
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         (application as WordPress).component().inject(this)
@@ -180,7 +182,12 @@ class SuggestionActivity : BaseAppCompatActivity() {
         })
 
         networkConnectionMonitor.isConnected.observe(this) { connected ->
-            viewModel.onConnectionChanged(connected)
+            // Only refresh on a genuine offline->online transition; the initial LiveData replay would
+            // otherwise trigger a redundant fetch on top of the one already started in viewModel.init().
+            if (connected && !lastConnected) {
+                viewModel.onConnectionChanged(connected)
+            }
+            lastConnected = connected
             updateEmptyView()
         }
     }

gradle.properties

@@ -6,3 +6,6 @@ org.gradle.configuration-cache=true
 # Dependency Analysis Plugin
 dependency.analysis.android.ignored.variants=release,wordpressRelease,jetpackRelease
 dependency.analysis.test.analysis=false
+
+# Enabled parallel sync for Gradle 9.4+
+org.gradle.tooling.parallel=true