Skip to content

Commit 4666d5d

Browse files
committed
Analysis: Resolve check for instance test warnings
Warning Message: "Check for instance is always 'false'" Also, as part of this commit, one other minor warning got resolved too.
1 parent c740332 commit 4666d5d

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

WordPress/src/test/java/org/wordpress/android/ui/comments/usecases/BatchModerateCommentsUseCaseTest.kt

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import org.junit.Before
1515
import org.junit.Test
1616
import org.junit.runner.notification.Failure
1717
import org.mockito.Mock
18-
import org.mockito.Mockito.*
18+
import org.mockito.Mockito.`when`
1919
import org.wordpress.android.BaseUnitTest
2020
import org.wordpress.android.fluxc.model.CommentStatus.APPROVED
2121
import org.wordpress.android.fluxc.model.CommentStatus.DELETED
@@ -273,7 +273,7 @@ class BatchModerateCommentsUseCaseTest : BaseUnitTest() {
273273
)
274274
)
275275

276-
assertThat(result.any { it is Failure }).isFalse() // no errors
276+
result.forEach { assertThat(it).isNotInstanceOf(Failure::class.java) }
277277

278278
verify(commentStore, times(1)).getCommentByLocalSiteAndRemoteId(site.id, 1)
279279
verify(commentStore, times(1)).getCommentByLocalSiteAndRemoteId(site.id, 3)
@@ -347,7 +347,7 @@ class BatchModerateCommentsUseCaseTest : BaseUnitTest() {
347347
)
348348
)
349349

350-
assertThat(result.any { it is Failure }).isFalse() // no errors
350+
result.forEach { assertThat(it).isNotInstanceOf(Failure::class.java) }
351351

352352
verify(commentStore, times(1)).getCommentByLocalSiteAndRemoteId(site.id, 1)
353353
verify(commentStore, times(1)).getCommentByLocalSiteAndRemoteId(site.id, 3)
@@ -429,7 +429,9 @@ class BatchModerateCommentsUseCaseTest : BaseUnitTest() {
429429
)
430430

431431
assertThat(result.size).isEqualTo(2)
432-
assertThat(result.filter { it is UseCaseResult.Failure }.size).isEqualTo(2)
432+
result.filterIsInstance<UseCaseResult.Failure<CommentsUseCaseType, CommentError, DoNotCare>>().let {
433+
assertThat(it.size).isEqualTo(2)
434+
}
433435

434436
// getting a backup from DB
435437

0 commit comments

Comments
 (0)