Analysis: Resolve name shadowed warnings

Warning Message: "Name shadowed: xyz"

Renaming the shadowed and/or the shadowing 'xyz' name is the recommended
action to resolve this kind of deprecated warnings.

Author: ParaskP7

WordPress/src/main/java/org/wordpress/android/ui/notifications/utils/FormattableContentClickHandler.kt

@@ -64,9 +64,9 @@ class FormattableContentClickHandler @Inject constructor(
                 showPostActivity(activity, siteId, id)
             COMMENT -> {
                 // Load the comment in the reader list if it exists, otherwise show a webview
-                val postId = clickedSpan.postId ?: clickedSpan.rootId ?: 0
-                if (ReaderUtils.postAndCommentExists(siteId, postId, id)) {
-                    showReaderCommentsList(activity, siteId, postId, id, ACTIVITY_LOG_DETAIL)
+                val rootId = clickedSpan.postId ?: clickedSpan.rootId ?: 0
+                if (ReaderUtils.postAndCommentExists(siteId, rootId, id)) {
+                    showReaderCommentsList(activity, siteId, rootId, id, ACTIVITY_LOG_DETAIL)
                 } else {
                     showWebViewActivityForUrl(activity, clickedSpan.url, rangeType)
                 }

WordPress/src/main/java/org/wordpress/android/ui/sitecreation/verticals/VerticalsSearchResultsProvider.kt

@@ -11,7 +11,7 @@ class VerticalsSearchResultsProvider @Inject constructor(localeManagerWrapper: L
 
     fun search(items: List<IntentListItemUiState>, query: String) = if (query.isEmpty()) items else items.filter {
         val text = it.verticalText.lowercase(locale)
-        val query = query.lowercase(locale)
-        text.contains(query)
+        val lowercasedQuery = query.lowercase(locale)
+        text.contains(lowercasedQuery)
     }
 }