Merge pull request #17287 from wordpress-mobile/analysis/wordpress-main-deprecated-warnings-part-2

[Compile Warnings As Errors] WordPress Module - Resolve Deprecated Warnings - Part.2

Author: ParaskP7

WordPress/src/debug/java/org/wordpress/android/WPWellSqlConfig.kt

@@ -19,6 +19,7 @@ class WPWellSqlConfig(context: Context) : WellSqlConfig(context) {
      * and show a toast alerting to the downgrade. The sole purpose of this is to avoid the hassle of devs switching
      * branches and having to clear storage and login again due to a version downgrade.
      */
+    @Suppress("DEPRECATION")
     override fun onDowngrade(db: SQLiteDatabase?, helper: WellTableManager?, oldVersion: Int, newVersion: Int) {
         if (BuildConfig.RESET_DB_ON_DOWNGRADE.toBoolean()) {
             // note: don't call super() here because it throws an exception

WordPress/src/jetpack/java/org/wordpress/android/ui/accounts/login/LoginPrologueFragment.kt

@@ -27,6 +27,7 @@ class LoginPrologueFragment : Fragment(R.layout.jetpack_login_prologue_screen) {
         loginPrologueListener = context
     }
 
+    @Suppress("DEPRECATION")
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
 
@@ -79,7 +80,7 @@ class LoginPrologueFragment : Fragment(R.layout.jetpack_login_prologue_screen) {
         viewModel.onFragmentResume()
     }
 
-    @Suppress("DEPRECATION")
+    @Suppress("DEPRECATION", "OVERRIDE_DEPRECATION")
     override fun onActivityCreated(savedInstanceState: Bundle?) {
         super.onActivityCreated(savedInstanceState)
         // important for accessibility - talkback
@@ -91,6 +92,7 @@ class LoginPrologueFragment : Fragment(R.layout.jetpack_login_prologue_screen) {
         updateSystemBars(showDarkStatusAndNavBarInLightMode = false)
     }
 
+    @Suppress("DEPRECATION")
     private fun updateSystemBars(showDarkStatusAndNavBarInLightMode: Boolean) {
         activity?.let {
             WPActivityUtils.setLightStatusBar(it.window, !showDarkStatusAndNavBarInLightMode)

WordPress/src/main/java/org/wordpress/android/AppInitializer.kt

@@ -1,3 +1,5 @@
+@file:Suppress("DEPRECATION")
+
 package org.wordpress.android
 
 import android.annotation.SuppressLint
@@ -163,7 +165,7 @@ class AppInitializer @Inject constructor(
     lateinit var storyNotificationTrackerProvider: StoryNotificationTrackerProvider
         private set
 
-    private lateinit var credentialsClient: GoogleApiClient
+    @Suppress("DEPRECATION") private lateinit var credentialsClient: GoogleApiClient
 
     private var startDate: Long
 
@@ -341,6 +343,7 @@ class AppInitializer @Inject constructor(
         }
     }
 
+    @Suppress("DEPRECATION")
     private fun setupCredentialsClient() {
         credentialsClient = GoogleApiClient.Builder(application)
                 .addConnectionCallbacks(object : GoogleApiClient.ConnectionCallbacks {
@@ -553,6 +556,7 @@ class AppInitializer @Inject constructor(
         AppLog.d(T.API, "Receiving OnUnexpectedError event, message: " + event.exception.message)
     }
 
+    @Suppress("DEPRECATION")
     private fun removeWpComUserRelatedData(context: Context) {
         // cancel all Volley requests - do this before unregistering push since that uses a Volley request
         VolleyUtils.cancelAllRequests(requestQueue)
@@ -764,6 +768,7 @@ class AppInitializer @Inject constructor(
          * 1. the app starts (but it's not opened by a service or a broadcast receiver, i.e. an activity is resumed)
          * 2. the app was in background and is now foreground
          */
+        @Suppress("DEPRECATION")
         fun onAppComesFromBackground() {
             readerTracker.setupTrackers()
             AppLog.i(T.UTILS, "App comes from background")

WordPress/src/main/java/org/wordpress/android/support/ZendeskHelper.kt

@@ -475,7 +475,7 @@ private fun buildZendeskTags(
  * could prove useful for the Happiness Engineers while debugging the users' issues.
  */
 private fun getNetworkInformation(context: Context): String {
-    val networkType = when (NetworkUtils.getActiveNetworkInfo(context)?.type) {
+    @Suppress("DEPRECATION") val networkType = when (NetworkUtils.getActiveNetworkInfo(context)?.type) {
         ConnectivityManager.TYPE_WIFI -> ZendeskConstants.networkWifi
         ConnectivityManager.TYPE_MOBILE -> ZendeskConstants.networkWWAN
         else -> ZendeskConstants.unknownValue
@@ -486,7 +486,7 @@ private fun getNetworkInformation(context: Context): String {
     return listOf(
             "${ZendeskConstants.networkTypeLabel} $networkType",
             "${ZendeskConstants.networkCarrierLabel} $carrierName",
-            "${ZendeskConstants.networkCountryCodeLabel} ${countryCodeLabel.toUpperCase(context.currentLocale)}"
+            "${ZendeskConstants.networkCountryCodeLabel} ${countryCodeLabel.uppercase(context.currentLocale)}"
     ).joinToString(separator = "\n")
 }
 

WordPress/src/main/java/org/wordpress/android/ui/JetpackRemoteInstallFragment.kt

@@ -131,7 +131,7 @@ class JetpackRemoteInstallFragment : Fragment(R.layout.jetpack_remote_install_fr
         })
     }
 
-    @Suppress("DEPRECATION")
+    @Suppress("DEPRECATION", "OVERRIDE_DEPRECATION")
     override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) {
         super.onActivityResult(requestCode, resultCode, data)
         if (requestCode == JETPACK_LOGIN && resultCode == Activity.RESULT_OK) {

WordPress/src/main/java/org/wordpress/android/ui/accounts/signup/SignupUtils.kt

@@ -3,8 +3,7 @@ package org.wordpress.android.ui.accounts.signup
 import java.util.Locale
 import javax.inject.Inject
 
-class SignupUtils
-@Inject constructor() {
+class SignupUtils @Inject constructor() {
     /**
      * Create a display name from the email address by taking everything before the "@" symbol,
      * removing all non-letters and non-periods, replacing periods with spaces, and capitalizing
@@ -18,7 +17,7 @@ class SignupUtils
         val builder = StringBuilder()
         for (item in usernameArray) {
             if (item.isNotEmpty()) {
-                builder.append(item.substring(0, 1).toUpperCase(Locale.ROOT))
+                builder.append(item.substring(0, 1).uppercase(Locale.ROOT))
                 if (item.length > 1) {
                     builder.append(item.substring(1))
                 }
@@ -38,6 +37,6 @@ class SignupUtils
     fun createUsernameFromEmail(emailAddress: String): String? {
         return emailAddress.split("@".toRegex())[0]
                 .replace("[^A-Za-z0-9]".toRegex(), "")
-                .toLowerCase(Locale.ROOT)
+                .lowercase(Locale.ROOT)
     }
 }

WordPress/src/main/java/org/wordpress/android/ui/activitylog/detail/ActivityLogDetailActivity.kt

@@ -31,7 +31,7 @@ class ActivityLogDetailActivity : LocaleAwareActivity() {
         return super.onOptionsItemSelected(item)
     }
 
-    @Suppress("DEPRECATION")
+    @Suppress("DEPRECATION", "OVERRIDE_DEPRECATION")
     override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) {
         super.onActivityResult(requestCode, resultCode, data)
         when (requestCode) {

WordPress/src/main/java/org/wordpress/android/ui/activitylog/list/ActivityLogListActivity.kt

@@ -95,7 +95,7 @@ class ActivityLogListActivity : LocaleAwareActivity(), ScrollableViewInitialized
         return super.onOptionsItemSelected(item)
     }
 
-    @Suppress("DEPRECATION")
+    @Suppress("DEPRECATION", "OVERRIDE_DEPRECATION")
     override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) {
         super.onActivityResult(requestCode, resultCode, data)
         when (requestCode) {

WordPress/src/main/java/org/wordpress/android/ui/bloggingreminders/DayLabelUtils.kt

@@ -26,7 +26,7 @@ class DayLabelUtils
 
     fun buildLowercaseNTimesLabel(bloggingRemindersModel: BloggingRemindersUiModel?): String? {
         val counts = resourceProvider.getStringArray(R.array.blogging_reminders_count).map {
-            it.toLowerCase(Locale.getDefault())
+            it.lowercase(Locale.getDefault())
         }
         val size = bloggingRemindersModel?.enabledDays?.size ?: 0
         return counts.getOrNull(size - 1)

WordPress/src/main/java/org/wordpress/android/ui/comments/CommentDetailFragment.java

@@ -635,6 +635,7 @@ public void onPause() {
     }
 
     @Override
+    @SuppressWarnings("deprecation")
     public void onActivityResult(int requestCode, int resultCode, Intent data) {
         super.onActivityResult(requestCode, resultCode, data);
         if (requestCode == INTENT_COMMENT_EDITOR && resultCode == Activity.RESULT_OK) {