Simplify connectivity transition guards to primitive booleans

Author: nbradbury

WordPress/src/main/java/org/wordpress/android/ui/prefs/BlogPreferencesActivity.java

@@ -43,7 +43,7 @@ public class BlogPreferencesActivity extends BaseAppCompatActivity {
     @Inject Dispatcher mDispatcher;
     @Inject NetworkConnectionMonitor mNetworkConnectionMonitor;
 
-    private Boolean mLastConnected;
+    private boolean mLastConnected;
 
     @Override
     public void onCreate(@Nullable Bundle savedInstanceState) {
@@ -124,7 +124,7 @@ private void onConnectionChanged(boolean connected) {
         if (siteSettingsFragment != null) {
             // Toast only on a genuine transition to disconnected, so LiveData replay on re-foregrounding
             // doesn't spuriously toast.
-            if (!connected && mLastConnected != null && mLastConnected) {
+            if (!connected && mLastConnected) {
                 ToastUtils.showToast(this, getString(R.string.site_settings_disconnected_toast), Duration.LONG);
             }
             siteSettingsFragment.setEditingEnabled(connected);

WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.kt

@@ -208,7 +208,7 @@ class ReaderPostListFragment : ViewPagerFragment(), OnPostSelectedListener, OnFo
     @Inject
     lateinit var networkConnectionMonitor: NetworkConnectionMonitor
 
-    private var lastConnected: Boolean? = null
+    private var lastConnected = false
 
     private var readerPostAdapter: ReaderPostAdapter? = null
     private var siteSearchAdapter: ReaderSiteSearchAdapter? = null
@@ -581,7 +581,7 @@ class ReaderPostListFragment : ViewPagerFragment(), OnPostSelectedListener, OnFo
         networkConnectionMonitor.isConnected.observe(viewLifecycleOwner) { connected ->
             // Only resubmit the search when connectivity actually transitions to connected, so LiveData replay
             // on re-foregrounding doesn't re-fire the search.
-            if (connected && lastConnected != connected) {
+            if (connected && !lastConnected) {
                 currentSearchQuery?.let { submitSearchQuery(it) }
             }
             lastConnected = connected