Fix search results bottom padding remaining when jetpack banner slides out of view

Author: ovitrif

WordPress/src/main/java/org/wordpress/android/ui/FilteredRecyclerView.java

@@ -87,6 +87,11 @@ public RecyclerView getInternalRecyclerView() {
         return mRecyclerView;
     }
 
+    public RecyclerView getSearchSuggestionsRecyclerView() {
+        return mSearchSuggestionsRecyclerView;
+    }
+
+
     public void setRefreshing(boolean refreshing) {
         mSwipeToRefreshHelper.setRefreshing(refreshing);
     }

WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java

@@ -503,7 +503,7 @@ public void onCreate(Bundle savedInstanceState) {
     }
 
     private void toggleJetpackBannerIfEnabled(final boolean forceShow) {
-        if (!isAdded() || getView() == null) return;
+        if (!isAdded() || getView() == null || !isSearching()) return;
 
         if (forceShow && mJetpackBrandingUtils.shouldShowJetpackBranding()) {
             showJetpackBanner();
@@ -523,15 +523,19 @@ private void showJetpackBanner() {
                         .show(getChildFragmentManager(), JetpackPoweredBottomSheetFragment.TAG);
             });
         }
-        // Add bottom margin to post list and empty view.
-        int jetpackBannerHeight = getResources().getDimensionPixelSize(R.dimen.jetpack_banner_height);
-        ((MarginLayoutParams) mRecyclerView.getLayoutParams()).bottomMargin = jetpackBannerHeight;
-        ((MarginLayoutParams) mActionableEmptyView.getLayoutParams()).bottomMargin = jetpackBannerHeight;
+
+        if (!isSearching()) {
+            // Add bottom margin to search suggestions post list and empty view.
+            int jetpackBannerHeight = getResources().getDimensionPixelSize(R.dimen.jetpack_banner_height);
+            ((MarginLayoutParams) mRecyclerView.getSearchSuggestionsRecyclerView().getLayoutParams()).bottomMargin
+                    = jetpackBannerHeight;
+            ((MarginLayoutParams) mActionableEmptyView.getLayoutParams()).bottomMargin = jetpackBannerHeight;
+        }
     }
 
     private void hideJetpackBanner() {
         mJetpackBanner.setVisibility(View.GONE);
-        // Remove bottom margin from post list and empty view.
+        // Remove bottom margin from search suggestions post list and empty view
         ((MarginLayoutParams) mRecyclerView.getLayoutParams()).bottomMargin = 0;
         ((MarginLayoutParams) mActionableEmptyView.getLayoutParams()).bottomMargin = 0;
     }