Remove setting prefs for My Site Dashboard default tab experiment.

Author: zwarm

WordPress/src/main/java/org/wordpress/android/ui/prefs/AppPrefs.java

@@ -1386,17 +1386,6 @@ public static List<JetpackCapability> getSiteJetpackCapabilities(long remoteSite
         return capabilities;
     }
 
-    public static boolean isMySiteDefaultTabExperimentVariantAssigned() {
-        return getBoolean(
-                DeletablePrefKey.MY_SITE_DEFAULT_TAB_EXPERIMENT_VARIANT_ASSIGNED,
-                false
-        );
-    }
-
-    public static void setMySiteDefaultTabExperimentVariantAssigned() {
-        setBoolean(DeletablePrefKey.MY_SITE_DEFAULT_TAB_EXPERIMENT_VARIANT_ASSIGNED, true);
-    }
-
     public static Date getSkippedPromptDay(int siteId) {
         long promptSkippedMillis = prefs().getLong(getSkippedBloggingPromptDayConfigKey(siteId), 0);
         if (promptSkippedMillis == 0) {
@@ -1417,16 +1406,6 @@ public static void setSkippedPromptDay(@Nullable Date date, int siteId) {
         return DeletablePrefKey.SKIPPED_BLOGGING_PROMPT_DAY.name() + siteId;
     }
 
-    public static void setInitialScreenFromMySiteDefaultTabExperimentVariant(String variant) {
-        // This supports the MySiteDefaultTab AB Experiment.
-        // AppSettings are undeletable across logouts and keys are all lower case.
-        // This method will be removed when the experiment has completed and thus
-        // the settings will be maintained only from the AppSettings view{
-        String initialScreen = variant.equals(MySiteTabType.SITE_MENU.getTrackingLabel())
-                ? MySiteTabType.SITE_MENU.getLabel() : MySiteTabType.DASHBOARD.getLabel();
-        setString(UndeletablePrefKey.wp_pref_initial_screen, initialScreen);
-    }
-
     public static String getMySiteInitialScreen() {
         return getString(
                 UndeletablePrefKey.wp_pref_initial_screen,

WordPress/src/main/java/org/wordpress/android/ui/prefs/AppPrefsWrapper.kt

@@ -220,13 +220,6 @@ class AppPrefsWrapper @Inject constructor() {
     fun setLastSelectedQuickStartTypeForSite(quickStartType: QuickStartType, siteLocalId: Long) =
             AppPrefs.setLastSelectedQuickStartTypeForSite(quickStartType, siteLocalId)
 
-    fun isMySiteDefaultTabExperimentVariantAssigned() = AppPrefs.isMySiteDefaultTabExperimentVariantAssigned()
-
-    fun setMySiteDefaultTabExperimentVariantAssigned() = AppPrefs.setMySiteDefaultTabExperimentVariantAssigned()
-
-    fun setInitialScreenFromMySiteDefaultTabExperimentVariant(variant: String) =
-            AppPrefs.setInitialScreenFromMySiteDefaultTabExperimentVariant(variant)
-
     fun getMySiteInitialScreen(): String = AppPrefs.getMySiteInitialScreen()
 
     fun setSkippedPromptDay(date: Date?, siteId: Int) = AppPrefs.setSkippedPromptDay(date, siteId)

WordPress/src/main/java/org/wordpress/android/ui/prefs/AppSettingsFragment.java

@@ -46,7 +46,6 @@
 import org.wordpress.android.ui.about.UnifiedAboutActivity;
 import org.wordpress.android.ui.debug.DebugSettingsActivity;
 import org.wordpress.android.ui.mysite.jetpackbadge.JetpackPoweredBottomSheetFragment;
-import org.wordpress.android.ui.mysite.tabs.MySiteDefaultTabExperiment;
 import org.wordpress.android.ui.mysite.tabs.MySiteTabType;
 import org.wordpress.android.ui.prefs.language.LocalePickerBottomSheet;
 import org.wordpress.android.ui.prefs.language.LocalePickerBottomSheet.LocalePickerCallback;
@@ -105,7 +104,6 @@ public class AppSettingsFragment extends PreferenceFragment
     @Inject BuildConfigWrapper mBuildConfigWrapper;
     @Inject UnifiedAboutFeatureConfig mUnifiedAboutFeatureConfig;
     @Inject MySiteDashboardTabsFeatureConfig mMySiteDashboardTabsFeatureConfig;
-    @Inject MySiteDefaultTabExperiment mMySiteDefaultTabExperiment;
     @Inject JetpackBrandingUtils mJetpackBrandingUtils;
 
     private static final String TRACK_STYLE = "style";
@@ -474,7 +472,6 @@ public boolean onPreferenceChange(Preference preference, Object newValue) {
             Map<String, Object> properties = new HashMap<>();
             properties.put("selected", trackValue);
             AnalyticsTracker.track(Stat.APP_SETTINGS_INITIAL_SCREEN_CHANGED, properties);
-            mMySiteDefaultTabExperiment.changeExperimentVariantAssignmentIfNeeded(trackValue);
         } else if (preference == mReportCrashPref) {
             AnalyticsTracker.track(Stat.PRIVACY_SETTINGS_REPORT_CRASHES_TOGGLED, Collections
                     .singletonMap(TRACK_ENABLED, newValue));