Merge pull request #17311 from wordpress-mobile/issue/17310-post-list-scroll-crash-in-debug-mode

antonis · web-flow · commit 773955a2223b · 2022-10-12T11:27:46.000+03:00
Make LoadingItem assertion an optional type
diff --git a/WordPress/src/main/java/org/wordpress/android/ui/posts/adapters/PostListAdapter.kt b/WordPress/src/main/java/org/wordpress/android/ui/posts/adapters/PostListAdapter.kt
@@ -95,7 +95,7 @@ class PostListAdapter(
         }
         if (holder is LoadingViewHolder) {
             val item = getItem(position)
-            assert(item is LoadingItem) {
+            assert(item is LoadingItem?) {
                 "If we are presenting LoadingViewHolder, the item has to be of type LoadingItem " +
                         "for position: $position"
             }

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ class PostListAdapter(`
`95`	`95`	`}`
`96`	`96`	`if (holder is LoadingViewHolder) {`
`97`	`97`	`val item = getItem(position)`
`98`		`- assert(item is LoadingItem) {`
	`98`	`+ assert(item is LoadingItem?) {`
`99`	`99`	`"If we are presenting LoadingViewHolder, the item has to be of type LoadingItem " +`
`100`	`100`	`"for position: $position"`
`101`	`101`	`}`