Skip to content

Commit 8f6f0f2

Browse files
committed
fix lint checks
1 parent 0061035 commit 8f6f0f2

3 files changed

Lines changed: 24 additions & 5 deletions

File tree

WordPress/src/main/res/layout-land/jetpack_powered_expanded_bottom_sheet.xml

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,23 @@
1818
app:layout_constraintStart_toStartOf="parent"
1919
app:layout_constraintTop_toTopOf="parent" />
2020

21+
<androidx.constraintlayout.widget.Barrier
22+
android:id="@+id/topBarrier"
23+
android:layout_width="wrap_content"
24+
android:layout_height="wrap_content"
25+
app:barrierDirection="top"
26+
app:constraint_referenced_ids="illustration_view"
27+
app:layout_constraintEnd_toEndOf="parent"
28+
app:layout_constraintStart_toStartOf="parent"
29+
app:layout_constraintTop_toBottomOf="@id/handle" />
30+
2131
<com.airbnb.lottie.LottieAnimationView
2232
android:id="@+id/illustration_view"
2333
android:layout_width="wrap_content"
2434
android:layout_height="wrap_content"
2535
android:layout_marginTop="@dimen/margin_extra_large"
2636
android:scaleType="centerCrop"
27-
app:layout_constraintTop_toBottomOf="@id/handle"
37+
app:layout_constraintTop_toBottomOf="@id/topBarrier"
2838
app:layout_constraintStart_toStartOf="parent"
2939
app:layout_constraintBottom_toTopOf="@id/title"
3040
app:lottie_rawRes="@raw/wp2jp"
@@ -53,9 +63,20 @@
5363
android:layout_height="wrap_content"
5464
android:layout_marginTop="@dimen/margin_extra_large"
5565
app:layout_constraintTop_toBottomOf="@id/title"
66+
app:layout_constraintBottom_toTopOf="@id/bottomBarrier"
5667
app:layout_constraintStart_toStartOf="parent"
5768
app:layout_constraintEnd_toEndOf="parent"/>
5869

70+
<androidx.constraintlayout.widget.Barrier
71+
android:id="@+id/bottomBarrier"
72+
android:layout_width="wrap_content"
73+
android:layout_height="wrap_content"
74+
app:barrierDirection="top"
75+
app:constraint_referenced_ids="primary_button"
76+
app:layout_constraintBottom_toTopOf="@id/primary_button"
77+
app:layout_constraintEnd_toEndOf="parent"
78+
app:layout_constraintStart_toStartOf="parent" />
79+
5980
<com.google.android.material.button.MaterialButton
6081
android:id="@+id/primary_button"
6182
android:layout_width="match_parent"

WordPress/src/main/res/layout/jetpack_powered_expanded_bottom_sheet.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,10 @@
6262
android:layout_marginTop="@dimen/margin_extra_medium_large"
6363
android:layout_marginBottom="@dimen/margin_theme_browser_top"
6464
android:text="@string/wp_jetpack_powered_reader_powered_by_jetpack_caption"
65+
app:layout_constraintTop_toBottomOf="@id/title"
6566
app:layout_constraintBottom_toTopOf="@id/bottomBarrier"
66-
app:layout_constraintEnd_toEndOf="parent"
6767
app:layout_constraintStart_toStartOf="parent"
68-
app:layout_constraintTop_toBottomOf="@id/title"
69-
app:layout_constraintVertical_bias="0.0" />
68+
app:layout_constraintEnd_toEndOf="parent" />
7069

7170
<androidx.constraintlayout.widget.Barrier
7271
android:id="@+id/bottomBarrier"

WordPress/src/main/res/values/dimens.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@
116116
<dimen name="margin_extra_extra_large">48dp</dimen>
117117
<dimen name="margin_64dp">64dp</dimen>
118118
<dimen name="margin_68dp">68dp</dimen>
119-
<dimen name="margin_200dp">200dp</dimen>
120119
<dimen name="margin_filter_spinner">16dp</dimen>
121120
<dimen name="margin_theme_browser_top">160dp</dimen>
122121
<dimen name="negative_margin_medium">-8dp</dimen>

0 commit comments

Comments
 (0)