Skip to content

Commit 9b21ea0

Browse files
committed
Add reminders synced parameter to reminders sync success analytics event
1 parent e7489ed commit 9b21ea0

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

WordPress/src/main/java/org/wordpress/android/bloggingreminders/BloggingRemindersSyncAnalyticsTracker.kt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@ class BloggingRemindersSyncAnalyticsTracker @Inject constructor(
1010
) {
1111
fun trackStart() = analyticsTracker.track(Stat.BLOGGING_REMINDERS_SYNC_START)
1212

13-
fun trackSuccess() = analyticsTracker.track(Stat.BLOGGING_REMINDERS_SYNC_SUCCESS)
13+
fun trackSuccess(remindersSyncedCount: Int) = analyticsTracker.track(
14+
Stat.BLOGGING_REMINDERS_SYNC_SUCCESS, mapOf(REMINDERS_SYNCED_COUNT to remindersSyncedCount)
15+
)
1416

1517
fun trackFailed(errorType: ErrorType) =
1618
analyticsTracker.track(Stat.BLOGGING_REMINDERS_SYNC_FAILED, mapOf(ERROR_TYPE to errorType.value))
1719

1820
sealed class ErrorType(val value: String) {
19-
object NoBloggingRemindersFoundError : ErrorType("no_blogging_reminders_found_error")
20-
2121
object QueryBloggingRemindersError : ErrorType("query_blogging_reminders_error")
2222

2323
object UpdateBloggingRemindersError : ErrorType("update_blogging_reminders_error")
@@ -27,3 +27,5 @@ class BloggingRemindersSyncAnalyticsTracker @Inject constructor(
2727
}
2828
}
2929
}
30+
31+
const val REMINDERS_SYNCED_COUNT = "reminders_synced_count"

WordPress/src/main/java/org/wordpress/android/bloggingreminders/resolver/BloggingRemindersResolver.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class BloggingRemindersResolver @Inject constructor(
5555
val success = syncBloggingReminders(siteModelBloggingReminderMap)
5656
if (success) onSuccess() else onFailure()
5757
} else {
58-
bloggingRemindersSyncAnalyticsTracker.trackFailed(ErrorType.NoBloggingRemindersFoundError)
58+
bloggingRemindersSyncAnalyticsTracker.trackSuccess(0)
5959
onFailure()
6060
}
6161
} else {
@@ -85,11 +85,12 @@ class BloggingRemindersResolver @Inject constructor(
8585
val isBloggingReminderAlreadySet = bloggingRemindersStore.bloggingRemindersModel(siteLocalId)
8686
.first().enabledDays.isNotEmpty()
8787
if (siteLocalId != 0 && !isBloggingReminderAlreadySet) {
88+
remindersSyncedCount = ++remindersSyncedCount
8889
bloggingRemindersStore.updateBloggingReminders(bloggingReminder.copy(siteId = siteLocalId))
8990
}
9091
}
92+
bloggingRemindersSyncAnalyticsTracker.trackSuccess(remindersSyncedCount)
9193
}
92-
bloggingRemindersSyncAnalyticsTracker.trackSuccess()
9394
return true
9495
} catch (exception: Exception) {
9596
bloggingRemindersSyncAnalyticsTracker.trackFailed(ErrorType.UpdateBloggingRemindersError)

0 commit comments

Comments
 (0)