Route wordpress-rs request errors to AppLog

Bump wordpress-rs to the PR #1398 build that adds RequestErrorLogger, and
wire RequestErrorLogger { AppLog.e(T.API, it) } into every WpComApiClient and
WpApiClient construction site. Failed requests are now logged under the API
tag (and crash-reporting breadcrumbs) instead of going unlogged.

Author: oguzkocer

WordPress/src/main/java/org/wordpress/android/networking/restapi/WpComApiClientProvider.kt

@@ -2,6 +2,8 @@ package org.wordpress.android.networking.restapi
 
 import okhttp3.OkHttpClient
 import org.wordpress.android.fluxc.network.rest.wpapi.rs.WpNetworkAvailabilityProvider
+import org.wordpress.android.util.AppLog
+import rs.wordpress.api.kotlin.RequestErrorLogger
 import rs.wordpress.api.kotlin.WpComApiClient
 import rs.wordpress.api.kotlin.WpHttpClient
 import rs.wordpress.api.kotlin.WpRequestExecutor
@@ -29,7 +31,8 @@ class WpComApiClientProvider @Inject constructor(
                 networkAvailabilityProvider = networkAvailabilityProvider
             ),
             authProvider = WpAuthenticationProvider.staticWithAuth(WpAuthentication.Bearer(token = accessToken)
-            )
+            ),
+            errorLogger = RequestErrorLogger { AppLog.e(AppLog.T.API, it) }
         )
     }
 }

WordPress/src/main/java/org/wordpress/android/ui/dataview/DataViewViewModel.kt

@@ -24,6 +24,7 @@ import org.wordpress.android.util.NetworkUtilsWrapper
 import org.wordpress.android.fluxc.network.TrackNetworkRequestsInterceptor
 import org.wordpress.android.fluxc.network.rest.wpapi.rs.WpNetworkAvailabilityProvider
 import org.wordpress.android.viewmodel.ScopedViewModel
+import rs.wordpress.api.kotlin.RequestErrorLogger
 import rs.wordpress.api.kotlin.WpComApiClient
 import uniffi.wp_api.WpApiParamOrder
 import uniffi.wp_api.WpAuthentication
@@ -91,7 +92,8 @@ open class DataViewViewModel @Inject constructor(
                 }
             ),
             interceptors = listOf(trackNetworkRequestsInterceptor),
-            networkAvailabilityProvider = networkAvailabilityProvider
+            networkAvailabilityProvider = networkAvailabilityProvider,
+            errorLogger = RequestErrorLogger { AppLog.e(AppLog.T.API, it) }
         )
     }
 

WordPress/src/main/java/org/wordpress/android/ui/subscribers/AddSubscribersViewModel.kt

@@ -17,6 +17,7 @@ import org.wordpress.android.ui.mysite.SelectedSiteRepository
 import org.wordpress.android.util.AppLog
 import org.wordpress.android.util.ToastUtilsWrapper
 import org.wordpress.android.viewmodel.ScopedViewModel
+import rs.wordpress.api.kotlin.RequestErrorLogger
 import rs.wordpress.api.kotlin.WpComApiClient
 import rs.wordpress.api.kotlin.WpRequestResult
 import uniffi.wp_api.AddSubscribersParams
@@ -53,7 +54,8 @@ class AddSubscribersViewModel @Inject constructor(
                 WpAuthentication.Bearer(token = accountStore.accessToken!!)
             ),
             interceptors = listOf(trackNetworkRequestsInterceptor),
-            networkAvailabilityProvider = networkAvailabilityProvider
+            networkAvailabilityProvider = networkAvailabilityProvider,
+            errorLogger = RequestErrorLogger { AppLog.e(AppLog.T.API, it) }
         )
     }
 

gradle/libs.versions.toml

@@ -101,7 +101,7 @@ wellsql = '2.0.0'
 wordpress-aztec = 'v2.1.4'
 wordpress-lint = '2.2.0'
 wordpress-persistent-edittext = '1.0.2'
-wordpress-rs = 'trunk-96105487c29b4205f25ff722ec80704ef8baa263'
+wordpress-rs = 'trunk-97d62ffff2983c0c71f2bbf95254156eba9aa57c'
 wordpress-utils = '3.14.0'
 automattic-ucrop = '2.2.11'
 zendesk = '5.5.3'

libs/fluxc/src/main/java/org/wordpress/android/fluxc/network/rest/wpapi/rs/WpApiClientProvider.kt

@@ -9,6 +9,8 @@ import org.wordpress.android.fluxc.model.SiteModel
 import org.wordpress.android.fluxc.module.OkHttpClientQualifiers
 import org.wordpress.android.fluxc.network.rest.wpapi.applicationpasswords.WpAppNotifierHandler
 import org.wordpress.android.fluxc.store.AccountStore
+import org.wordpress.android.util.AppLog
+import rs.wordpress.api.kotlin.RequestErrorLogger
 import rs.wordpress.api.kotlin.WpApiClient
 import rs.wordpress.api.kotlin.WpHttpClient
 import rs.wordpress.api.kotlin.WpRequestExecutor
@@ -36,6 +38,8 @@ class WpApiClientProvider @Inject constructor(
     private val wpComClients = mutableMapOf<Long, WpApiClient>()
     private val selfHostedClients = mutableMapOf<Int, WpApiClient>()
 
+    private val errorLogger = RequestErrorLogger { AppLog.e(AppLog.T.API, it) }
+
     /** Removes all cached API clients (e.g. on sign-out). */
     @Synchronized
     fun clearAllClients() {
@@ -116,6 +120,7 @@ class WpApiClientProvider @Inject constructor(
                         )
                 }
             },
+            errorLogger = errorLogger,
         )
     }
 
@@ -155,7 +160,8 @@ class WpApiClientProvider @Inject constructor(
                 override suspend fun requestedWithInvalidAuthentication(requestUrl: String) {
                     wpAppNotifierHandler.notifyRequestedWithInvalidAuthentication(site)
                 }
-            }
+            },
+            errorLogger = errorLogger
         )
         return client
     }
@@ -175,7 +181,8 @@ class WpApiClientProvider @Inject constructor(
                     override suspend fun requestedWithInvalidAuthentication(requestUrl: String) {
                         wpAppNotifierHandler.notifyRequestedWithInvalidAuthentication(site)
                     }
-                }
+                },
+                errorLogger = errorLogger
             )
         }
     }