Update tests for the new AppReviewsManager

Author: irfano

WordPress/src/main/java/org/wordpress/android/ui/notifications/NotificationsListViewModel.kt

@@ -35,7 +35,7 @@ import org.wordpress.android.util.NetworkUtilsWrapper
 import org.wordpress.android.util.ToastUtilsWrapper
 import org.wordpress.android.viewmodel.Event
 import org.wordpress.android.viewmodel.ScopedViewModel
-import org.wordpress.android.widgets.AppReviewManager
+import org.wordpress.android.widgets.AppReviewsManagerWrapper
 import javax.inject.Inject
 import javax.inject.Named
 
@@ -49,6 +49,7 @@ class NotificationsListViewModel @Inject constructor(
     private val networkUtilsWrapper: NetworkUtilsWrapper,
     private val toastUtilsWrapper: ToastUtilsWrapper,
     private val notificationsUtilsWrapper: NotificationsUtilsWrapper,
+    private val appReviewsManagerWrapper: AppReviewsManagerWrapper,
     private val appLogWrapper: AppLogWrapper,
     private val siteStore: SiteStore,
     private val commentStore: CommentsStore,
@@ -142,7 +143,7 @@ class NotificationsListViewModel @Inject constructor(
         openDetailView: () -> Unit
     ) {
         val note = noteId?.let { notificationsUtilsWrapper.getNoteById(noteId) }
-        note?.let { AppReviewManager.onNotificationReceived(it) }
+        note?.let { appReviewsManagerWrapper.onNotificationReceived(it) }
         if (note != null && note.isCommentType && !note.canModerate()) {
             val readerPost = readerPostTableWrapper.getBlogPost(note.siteId.toLong(), note.postId.toLong(), false)
             if (readerPost != null) {

WordPress/src/main/java/org/wordpress/android/ui/reader/discover/ReaderPostCardActionsHandler.kt

@@ -78,7 +78,7 @@ import org.wordpress.android.util.AppLog
 import org.wordpress.android.util.AppLog.T
 import org.wordpress.android.viewmodel.Event
 import org.wordpress.android.viewmodel.ResourceProvider
-import org.wordpress.android.widgets.AppRatingDialogWrapper
+import org.wordpress.android.widgets.AppReviewsManagerWrapper
 import javax.inject.Inject
 import javax.inject.Named
 
@@ -97,7 +97,7 @@ class ReaderPostCardActionsHandler @Inject constructor(
     private val dispatcher: Dispatcher,
     private val resourceProvider: ResourceProvider,
     private val htmlMessageUtils: HtmlMessageUtils,
-    private val appRatingDialogWrapper: AppRatingDialogWrapper,
+    private val appReviewsManagerWrapper: AppReviewsManagerWrapper,
     private val seenStatusToggleUseCase: ReaderSeenStatusToggleUseCase,
     private val readerBlogTableWrapper: ReaderBlogTableWrapper,
     @Named(BG_THREAD) private val bgDispatcher: CoroutineDispatcher
@@ -207,7 +207,7 @@ class ReaderPostCardActionsHandler @Inject constructor(
         source: String
     ) {
         withContext(bgDispatcher) {
-            appRatingDialogWrapper.incrementInteractions(
+            appReviewsManagerWrapper.incrementInteractions(
                 AnalyticsTracker.Stat.APP_REVIEWS_EVENT_INCREMENTED_BY_OPENING_READER_POST
             )
 

WordPress/src/main/java/org/wordpress/android/widgets/AppReviewManager.kt

@@ -151,7 +151,7 @@ object AppReviewManager {
     }
 
     /**
-     * Check whether the in-app reviews prompt should be shown or not.
+     * Check whether the in-app reviews prompt should be shown or not.it after its last sh
      * @return true if the prompt should be shown
      */
     fun shouldShowInAppReviewsPrompt(): Boolean {

…ndroid/widgets/AppRatingDialogWrapper.kt …roid/widgets/AppReviewsManagerWrapper.ktWordPress/src/main/java/org/wordpress/android/widgets/AppRatingDialogWrapper.kt renamed to WordPress/src/main/java/org/wordpress/android/widgets/AppReviewsManagerWrapper.kt WordPress/src/main/java/org/wordpress/android/widgets/AppRatingDialogWrapper.kt renamed to WordPress/src/main/java/org/wordpress/android/widgets/AppReviewsManagerWrapper.kt

@@ -1,11 +1,13 @@
 package org.wordpress.android.widgets
 
 import org.wordpress.android.analytics.AnalyticsTracker
+import org.wordpress.android.models.Note
 import javax.inject.Inject
 
 /**
  * Mockable wrapper created for testing purposes.
  */
-class AppRatingDialogWrapper @Inject constructor() {
+class AppReviewsManagerWrapper @Inject constructor() {
+    fun onNotificationReceived(note: Note) = AppReviewManager.onNotificationReceived(note)
     fun incrementInteractions(tracker: AnalyticsTracker.Stat) = AppReviewManager.incrementInteractions(tracker)
 }

WordPress/src/test/java/org/wordpress/android/ui/notifications/NotificationsListViewModelTest.kt

@@ -36,6 +36,7 @@ import org.wordpress.android.ui.reader.actions.ReaderPostActionsWrapper
 import org.wordpress.android.util.EventBusWrapper
 import org.wordpress.android.util.NetworkUtilsWrapper
 import org.wordpress.android.util.ToastUtilsWrapper
+import org.wordpress.android.widgets.AppReviewsManagerWrapper
 
 private const val REQUEST_BLOG_LISTENER_PARAM_POSITION = 2
 
@@ -72,6 +73,9 @@ class NotificationsListViewModelTest : BaseUnitTest() {
     @Mock
     private lateinit var appLogWrapper: AppLogWrapper
 
+    @Mock
+    private lateinit var appReviewsManagerWrapper: AppReviewsManagerWrapper
+
     @Mock
     private lateinit var siteStore: SiteStore
 
@@ -103,6 +107,7 @@ class NotificationsListViewModelTest : BaseUnitTest() {
             networkUtilsWrapper,
             toastUtilsWrapper,
             notificationsUtilsWrapper,
+            appReviewsManagerWrapper,
             appLogWrapper,
             siteStore,
             commentStore,