Analysis: Suppress parameter is never used warnings

Warning Message: "Parameter 'xyz' is never used"

Notice that for 'Event Bus' related functions this warning should be
suppressed instead. This is because this is how the 'Event bus'
mechanism works as it need the parameter to be present on a function,
even if that parameter is unused.

Author: ParaskP7

WordPress/src/main/java/org/wordpress/android/AppInitializer.kt

@@ -533,7 +533,7 @@ class AppInitializer @Inject constructor(
         }
     }
 
-    @Suppress("unused")
+    @Suppress("unused", "UNUSED_PARAMETER")
     @Subscribe(threadMode = ThreadMode.MAIN)
     fun onAuthenticationChanged(event: OnAuthenticationChanged) {
         if (accountStore.hasAccessToken()) {

WordPress/src/main/java/org/wordpress/android/ui/main/MeFragment.kt

@@ -586,7 +586,7 @@ class MeFragment : Fragment(R.layout.me_fragment), OnScrollToTopListener {
         }
     }
 
-    @Suppress("unused")
+    @Suppress("unused", "UNUSED_PARAMETER")
     @Subscribe(threadMode = ThreadMode.MAIN)
     fun onAccountChanged(event: OnAccountChanged?) {
         binding?.refreshAccountDetails()

WordPress/src/main/java/org/wordpress/android/ui/notifications/NotificationsListFragmentPage.kt

@@ -443,7 +443,7 @@ class NotificationsListFragmentPage : ViewPagerFragment(R.layout.notifications_l
         notesAdapter!!.addAll(event.notes, true)
     }
 
-    @Suppress("unused")
+    @Suppress("unused", "UNUSED_PARAMETER")
     @Subscribe(threadMode = MAIN)
     fun onEventMainThread(error: NotificationsRefreshError?) {
         if (isAdded) {

WordPress/src/main/java/org/wordpress/android/ui/posts/editor/StorePostViewModel.kt

@@ -187,13 +187,13 @@ class StorePostViewModel
         _onFinish.postValue(Event(state))
     }
 
-    @Suppress("unused")
+    @Suppress("unused", "UNUSED_PARAMETER")
     @Subscribe
     fun onPostUploaded(event: OnPostUploaded) {
         hideSavingProgressDialog()
     }
 
-    @Suppress("unused")
+    @Suppress("unused", "UNUSED_PARAMETER")
     @Subscribe
     fun onPostChanged(event: OnPostChanged) {
         hideSavingProgressDialog()

WordPress/src/main/java/org/wordpress/android/ui/posts/editor/StoriesEventListener.kt

@@ -18,7 +18,6 @@ import com.wordpress.stories.compose.story.StoryIndex
 import org.greenrobot.eventbus.Subscribe
 import org.greenrobot.eventbus.ThreadMode
 import org.wordpress.android.R
-import org.wordpress.android.R.string
 import org.wordpress.android.analytics.AnalyticsTracker
 import org.wordpress.android.analytics.AnalyticsTracker.Stat.EDITOR_UPLOAD_MEDIA_RETRIED
 import org.wordpress.android.editor.EditorMediaUploadListener
@@ -348,8 +347,8 @@ class StoriesEventListener @Inject constructor(
                     val builder: Builder = MaterialAlertDialogBuilder(
                             activity
                     )
-                    builder.setTitle(activity.getString(string.cannot_retry_deleted_media_item_fatal))
-                    builder.setPositiveButton(string.ok) { dialog, id -> dialog.dismiss() }
+                    builder.setTitle(activity.getString(R.string.cannot_retry_deleted_media_item_fatal))
+                    builder.setPositiveButton(R.string.ok) { dialog, id -> dialog.dismiss() }
                     val dialog = builder.create()
                     dialog.show()
                     return
@@ -380,7 +379,7 @@ class StoriesEventListener @Inject constructor(
         AnalyticsTracker.track(EDITOR_UPLOAD_MEDIA_RETRIED)
     }
 
-    @Suppress("unused")
+    @Suppress("unused", "UNUSED_PARAMETER")
     fun onCancelSaveForMediaCollection(mediaFiles: ArrayList<Any>) {
         // TODO implement cancelling save process for media collection
     }

WordPress/src/main/java/org/wordpress/android/ui/prefs/categories/list/CategoriesListViewModel.kt

@@ -107,7 +107,7 @@ class CategoriesListViewModel @Inject constructor(
         _navigation.postValue(CreateCategory)
     }
 
-    @Suppress("unused")
+    @Suppress("unused", "UNUSED_PARAMETER")
     fun onCategoryClicked(categoryNode: CategoryNode) {
         // todo implement the logic of navigation to category detail page
     }

WordPress/src/main/java/org/wordpress/android/ui/reader/discover/ReaderDiscoverViewModel.kt

@@ -369,7 +369,7 @@ class ReaderDiscoverViewModel @Inject constructor(
         }
     }
 
-    @Suppress("unused")
+    @Suppress("unused", "UNUSED_PARAMETER")
     private fun onDiscoverClicked(postId: Long, blogId: Long) {
         // TODO malinjir: add on discover clicked listener
     }

WordPress/src/main/java/org/wordpress/android/ui/reader/repository/ReaderDiscoverDataProvider.kt

@@ -186,7 +186,7 @@ class ReaderDiscoverDataProvider @Inject constructor(
     }
 
     // Event bus events
-    @Suppress("unused")
+    @Suppress("unused", "UNUSED_PARAMETER")
     @Subscribe(threadMode = BACKGROUND)
     fun onReaderPostTableAction(event: ReaderPostTableActionEnded) {
         if (_discoverFeed.hasObservers()) {
@@ -208,7 +208,7 @@ class ReaderDiscoverDataProvider @Inject constructor(
         }
     }
 
-    @Suppress("unused")
+    @Suppress("unused", "UNUSED_PARAMETER")
     @Subscribe(threadMode = BACKGROUND)
     fun onFollowedTagsChanged(event: FollowedTagsChanged) {
         launch {

WordPress/src/main/java/org/wordpress/android/ui/reader/subfilter/SubFilterViewModel.kt

@@ -355,14 +355,14 @@ class SubFilterViewModel @Inject constructor(
         outState.putBoolean(ARG_IS_FIRST_LOAD, isFirstLoad)
     }
 
-    @Suppress("unused")
+    @Suppress("unused", "UNUSED_PARAMETER")
     @Subscribe(threadMode = ThreadMode.MAIN)
     fun onEventMainThread(event: ReaderEvents.FollowedTagsChanged) {
         AppLog.d(T.READER, "Subfilter bottom sheet > followed tags changed")
         loadSubFilters()
     }
 
-    @Suppress("unused")
+    @Suppress("unused", "UNUSED_PARAMETER")
     @Subscribe(threadMode = ThreadMode.MAIN)
     fun onEventMainThread(event: ReaderEvents.FollowedBlogsChanged) {
         AppLog.d(T.READER, "Subfilter bottom sheet > followed blogs changed")

WordPress/src/main/java/org/wordpress/android/ui/reader/viewmodels/ReaderViewModel.kt

@@ -239,7 +239,7 @@ class ReaderViewModel @Inject constructor(
 
     private fun ReaderTag.isDefaultSelectedTab(): Boolean = this.isDiscover
 
-    @Suppress("unused")
+    @Suppress("unused", "UNUSED_PARAMETER")
     @Subscribe(threadMode = MAIN)
     fun onTagsUpdated(event: ReaderEvents.FollowedTagsChanged) {
         loadTabs()