Drop the redundant empty-domain guard in onDomainClick

oguzkocer · oguzkocer · commit bd8d6b87acd9 · 2026-07-28T00:55:35.000-04:00
`getDomainDetailsUrl()` already returns null when `domain` is empty, so the
`?: return` on the following argument covers the case.
diff --git a/WordPress/src/main/java/org/wordpress/android/ui/domains/DomainsDashboardViewModel.kt b/WordPress/src/main/java/org/wordpress/android/ui/domains/DomainsDashboardViewModel.kt
@@ -242,7 +242,7 @@ class DomainsDashboardViewModel @Inject constructor(
     private fun onDomainClick(allDomainItem: AllDomainItem) {
         _onNavigation.value = Event(
             OpenDomainManagement(
-                allDomainItem.domain.ifEmpty { return },
+                allDomainItem.domain,
                 allDomainItem.getDomainDetailsUrl() ?: return
             )
         )

Original file line number	Diff line number	Diff line change
`@@ -242,7 +242,7 @@ class DomainsDashboardViewModel @Inject constructor(`
`242`	`242`	`private fun onDomainClick(allDomainItem: AllDomainItem) {`
`243`	`243`	`_onNavigation.value = Event(`
`244`	`244`	`OpenDomainManagement(`
`245`		`- allDomainItem.domain.ifEmpty { return },`
	`245`	`+ allDomainItem.domain,`
`246`	`246`	`allDomainItem.getDomainDetailsUrl() ?: return`
`247`	`247`	`)`
`248`	`248`	`)`