Skip to content

Commit c3e0c83

Browse files
committed
Remove references related to My Site Dashboard default tab experiment.
1 parent 76174e8 commit c3e0c83

6 files changed

Lines changed: 3 additions & 31 deletions

File tree

WordPress/src/main/java/org/wordpress/android/AppInitializer.kt

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ import org.wordpress.android.support.ZendeskHelper
8181
import org.wordpress.android.ui.ActivityId
8282
import org.wordpress.android.ui.debug.cookies.DebugCookieManager
8383
import org.wordpress.android.ui.mysite.SelectedSiteRepository
84-
import org.wordpress.android.ui.mysite.tabs.MySiteDefaultTabExperiment
8584
import org.wordpress.android.ui.notifications.SystemNotificationsTracker
8685
import org.wordpress.android.ui.notifications.services.NotificationsUpdateServiceStarter
8786
import org.wordpress.android.ui.notifications.utils.NotificationsUtils
@@ -154,7 +153,6 @@ class AppInitializer @Inject constructor(
154153
@Inject lateinit var debugCookieManager: DebugCookieManager
155154
@Inject @Named(APPLICATION_SCOPE) lateinit var appScope: CoroutineScope
156155
@Inject lateinit var selectedSiteRepository: SelectedSiteRepository
157-
@Inject lateinit var mySiteDefaultTabExperiment: MySiteDefaultTabExperiment
158156

159157
// For development and production `AnalyticsTrackerNosara`, for testing a mocked `Tracker` will be injected.
160158
@Inject lateinit var tracker: Tracker
@@ -308,8 +306,6 @@ class AppInitializer @Inject constructor(
308306

309307
debugCookieManager.sync()
310308

311-
initAnalyticsExperimentPropertiesIfNeeded()
312-
313309
initialized = true
314310
}
315311

@@ -683,11 +679,6 @@ class AppInitializer @Inject constructor(
683679
EmojiCompat.init(config)
684680
}
685681

686-
/* If default tab experiment is running, pass along to tracker */
687-
private fun initAnalyticsExperimentPropertiesIfNeeded() {
688-
mySiteDefaultTabExperiment.checkAndSetTrackingPropertiesIfNeeded()
689-
}
690-
691682
@Suppress("unused")
692683
@OnLifecycleEvent(Lifecycle.Event.ON_START)
693684
fun onAppComesFromBackground() {

WordPress/src/main/java/org/wordpress/android/ui/accounts/LoginEpilogueViewModel.kt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import androidx.lifecycle.LiveData
44
import androidx.lifecycle.MediatorLiveData
55
import androidx.lifecycle.ViewModel
66
import org.wordpress.android.fluxc.store.SiteStore
7-
import org.wordpress.android.ui.mysite.tabs.MySiteDefaultTabExperiment
87
import org.wordpress.android.ui.prefs.AppPrefsWrapper
98
import org.wordpress.android.util.BuildConfigWrapper
109
import org.wordpress.android.viewmodel.Event
@@ -14,8 +13,7 @@ import javax.inject.Inject
1413
class LoginEpilogueViewModel @Inject constructor(
1514
private val appPrefsWrapper: AppPrefsWrapper,
1615
private val buildConfigWrapper: BuildConfigWrapper,
17-
private val siteStore: SiteStore,
18-
private val mySiteDefaultTabExperiment: MySiteDefaultTabExperiment
16+
private val siteStore: SiteStore
1917
) : ViewModel() {
2018
private val _navigationEvents = MediatorLiveData<Event<LoginNavigationEvents>>()
2119
val navigationEvents: LiveData<Event<LoginNavigationEvents>> = _navigationEvents
@@ -32,10 +30,6 @@ class LoginEpilogueViewModel @Inject constructor(
3230
if (!siteStore.hasSite()) handleNoSitesFound() else handleSitesFound()
3331
}
3432

35-
fun checkAndSetVariantForMySiteDefaultTabExperiment() {
36-
mySiteDefaultTabExperiment.checkAndSetVariantIfNeeded()
37-
}
38-
3933
private fun handleNoSitesFound() {
4034
if (buildConfigWrapper.isJetpackApp && !buildConfigWrapper.isSiteCreationEnabled) {
4135
_navigationEvents.postValue(Event(LoginNavigationEvents.ShowNoJetpackSites))

WordPress/src/main/java/org/wordpress/android/ui/accounts/login/LoginEpilogueFragment.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,6 @@ public void onViewCreated(View view, @Nullable Bundle savedInstanceState) {
173173
public void onActivityCreated(@Nullable Bundle savedInstanceState) {
174174
super.onActivityCreated(savedInstanceState);
175175
if (savedInstanceState == null) {
176-
mParentViewModel.checkAndSetVariantForMySiteDefaultTabExperiment();
177176
AnalyticsTracker.track(AnalyticsTracker.Stat.LOGIN_EPILOGUE_VIEWED);
178177
mUnifiedLoginTracker.track(Step.SUCCESS);
179178
}

WordPress/src/main/java/org/wordpress/android/ui/main/WPMainActivity.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1380,7 +1380,6 @@ public void onAuthenticationChanged(OnAuthenticationChanged event) {
13801380
// We'll handle it in onAccountChanged so we know we have
13811381
// updated account info.
13821382
AppPrefs.setShouldTrackMagicLinkSignup(true);
1383-
mViewModel.checkAndSetVariantForMySiteDefaultTabExperiment();
13841383
mDispatcher.dispatch(AccountActionBuilder.newFetchAccountAction());
13851384
if (mJetpackConnectSource != null) {
13861385
ActivityLauncher.continueJetpackConnect(this, mJetpackConnectSource, getSelectedSite());

WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/CardsBuilder.kt

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import org.wordpress.android.ui.mysite.cards.dashboard.CardsBuilder
1111
import org.wordpress.android.ui.mysite.cards.quickactions.QuickActionsCardBuilder
1212
import org.wordpress.android.ui.mysite.cards.quicklinksribbon.QuickLinkRibbonBuilder
1313
import org.wordpress.android.ui.mysite.cards.quickstart.QuickStartCardBuilder
14-
import org.wordpress.android.ui.mysite.tabs.MySiteDefaultTabExperiment
1514
import org.wordpress.android.ui.utils.ListItemInteraction
1615
import org.wordpress.android.util.BuildConfigWrapper
1716
import org.wordpress.android.util.config.QuickStartDynamicCardsFeatureConfig
@@ -24,8 +23,7 @@ class CardsBuilder @Inject constructor(
2423
private val quickActionsCardBuilder: QuickActionsCardBuilder,
2524
private val quickStartCardBuilder: QuickStartCardBuilder,
2625
private val quickLinkRibbonBuilder: QuickLinkRibbonBuilder,
27-
private val dashboardCardsBuilder: CardsBuilder,
28-
private val mySiteDefaultTabExperiment: MySiteDefaultTabExperiment
26+
private val dashboardCardsBuilder: CardsBuilder
2927
) {
3028
fun build(
3129
quickActionsCardBuilderParams: QuickActionsCardBuilderParams,
@@ -55,10 +53,7 @@ class CardsBuilder @Inject constructor(
5553
}
5654

5755
private fun shouldShowQuickActionsCard(isMySiteTabsEnabled: Boolean): Boolean {
58-
val isDefaultTabVariantAssignedInExperiment =
59-
mySiteDefaultTabExperiment.isExperimentRunning() && mySiteDefaultTabExperiment.isVariantAssigned()
60-
return buildConfigWrapper.isQuickActionEnabled &&
61-
(!isMySiteTabsEnabled || !isDefaultTabVariantAssignedInExperiment)
56+
return buildConfigWrapper.isQuickActionEnabled && !isMySiteTabsEnabled
6257
}
6358

6459
private fun trackAndBuildDomainRegistrationCard(

WordPress/src/main/java/org/wordpress/android/viewmodel/main/WPMainActivityViewModel.kt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ import org.wordpress.android.ui.main.MainFabUiState
3232
import org.wordpress.android.ui.mysite.SelectedSiteRepository
3333
import org.wordpress.android.ui.mysite.cards.dashboard.bloggingprompts.BloggingPromptAttribution
3434
import org.wordpress.android.ui.mysite.cards.quickstart.QuickStartRepository
35-
import org.wordpress.android.ui.mysite.tabs.MySiteDefaultTabExperiment
3635
import org.wordpress.android.ui.prefs.AppPrefsWrapper
3736
import org.wordpress.android.ui.utils.UiString.UiStringText
3837
import org.wordpress.android.ui.whatsnew.FeatureAnnouncementProvider
@@ -65,7 +64,6 @@ class WPMainActivityViewModel @Inject constructor(
6564
private val selectedSiteRepository: SelectedSiteRepository,
6665
private val accountStore: AccountStore,
6766
private val siteStore: SiteStore,
68-
private val mySiteDefaultTabExperiment: MySiteDefaultTabExperiment,
6967
private val bloggingPromptsFeatureConfig: BloggingPromptsFeatureConfig,
7068
private val bloggingPromptsStore: BloggingPromptsStore,
7169
@Named(UI_THREAD) private val mainDispatcher: CoroutineDispatcher
@@ -298,10 +296,6 @@ class WPMainActivityViewModel @Inject constructor(
298296
_switchToMySite.value = Event(Unit)
299297
}
300298

301-
fun checkAndSetVariantForMySiteDefaultTabExperiment() {
302-
mySiteDefaultTabExperiment.checkAndSetVariantIfNeeded()
303-
}
304-
305299
fun onResume(site: SiteModel?, isOnMySitePageWithValidSite: Boolean) {
306300
val showFab = if (buildConfigWrapper.isCreateFabEnabled) isOnMySitePageWithValidSite else false
307301
setMainFabUiState(showFab, site)

0 commit comments

Comments
 (0)