Skip to content

Commit c851ebf

Browse files
committed
Merge branch 'trunk' into analysis/use-updated-and-null-proof-theme-model-class
# Conflicts: # build.gradle
2 parents 24c597d + 1ef03c0 commit c851ebf

324 files changed

Lines changed: 6957 additions & 2536 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,38 @@
11
Fixes #
22

3-
To test:
3+
-----
4+
5+
## To Test:
6+
7+
<!-- Test instructions per dependency update: https://github.com/wordpress-mobile/WordPress-Android/blob/trunk/docs/test_instructions_per_dependency_update.md -->
8+
9+
-----
410

511
## Regression Notes
12+
613
1. Potential unintended areas of impact
714

15+
- TODO
816

917
2. What I did to test those areas of impact (or what existing automated tests I relied on)
1018

19+
- TODO
1120

1221
3. What automated tests I added (or what prevented me from doing so)
1322

14-
PR submission checklist:
23+
- TODO
24+
25+
-----
26+
27+
## PR Submission Checklist:
1528

1629
- [ ] I have completed the Regression Notes.
1730
- [ ] I have considered adding accessibility improvements for my changes.
1831
- [ ] I have considered if this change warrants user-facing release notes and have added them to `RELEASE-NOTES.txt` if necessary.
1932

20-
UI Changes testing checklist:
33+
-----
34+
35+
## UI Changes Testing Checklist:
2136

2237
- [ ] Portrait and landscape orientations.
2338
- [ ] Light and dark modes.

.idea/checkstyle-idea.xml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Gemfile.lock

Lines changed: 26 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
GIT
22
remote: https://github.com/Automattic/dangermattic
3-
revision: 078aa57c084790327da4cb401f18b350a4d1e329
3+
revision: 9ba0e5824e66e16526897a4583c9b900f9b8635c
44
specs:
55
danger-dangermattic (0.0.1)
66
danger (~> 9.3)
@@ -16,7 +16,7 @@ GEM
1616
specs:
1717
CFPropertyList (3.0.6)
1818
rexml
19-
activesupport (7.1.1)
19+
activesupport (7.1.2)
2020
base64
2121
bigdecimal
2222
concurrent-ruby (~> 1.0, >= 1.0.2)
@@ -31,24 +31,24 @@ GEM
3131
artifactory (3.0.15)
3232
ast (2.4.2)
3333
atomos (0.1.3)
34-
aws-eventstream (1.2.0)
35-
aws-partitions (1.844.0)
36-
aws-sdk-core (3.186.0)
34+
aws-eventstream (1.3.0)
35+
aws-partitions (1.855.0)
36+
aws-sdk-core (3.188.0)
3737
aws-eventstream (~> 1, >= 1.0.2)
3838
aws-partitions (~> 1, >= 1.651.0)
3939
aws-sigv4 (~> 1.5)
4040
jmespath (~> 1, >= 1.6.1)
41-
aws-sdk-kms (1.72.0)
42-
aws-sdk-core (~> 3, >= 3.184.0)
41+
aws-sdk-kms (1.73.0)
42+
aws-sdk-core (~> 3, >= 3.188.0)
4343
aws-sigv4 (~> 1.1)
44-
aws-sdk-s3 (1.136.0)
45-
aws-sdk-core (~> 3, >= 3.181.0)
44+
aws-sdk-s3 (1.139.0)
45+
aws-sdk-core (~> 3, >= 3.188.0)
4646
aws-sdk-kms (~> 1)
4747
aws-sigv4 (~> 1.6)
48-
aws-sigv4 (1.6.1)
48+
aws-sigv4 (1.7.0)
4949
aws-eventstream (~> 1, >= 1.0.2)
5050
babosa (1.0.4)
51-
base64 (0.1.1)
51+
base64 (0.2.0)
5252
bigdecimal (3.1.4)
5353
buildkit (1.5.0)
5454
sawyer (>= 0.6)
@@ -66,7 +66,7 @@ GEM
6666
connection_pool (2.4.1)
6767
cork (0.3.0)
6868
colored2 (~> 3.1)
69-
danger (9.3.2)
69+
danger (9.4.0)
7070
claide (~> 1.0)
7171
claide-plugins (>= 0.9.2)
7272
colored2 (~> 3.1)
@@ -77,7 +77,7 @@ GEM
7777
kramdown (~> 2.3)
7878
kramdown-parser-gfm (~> 1.0)
7979
no_proxy_fix
80-
octokit (~> 6.0)
80+
octokit (>= 6.0, < 8.0)
8181
terminal-table (>= 1, < 4)
8282
danger-junit (1.0.2)
8383
danger (> 2.0)
@@ -87,7 +87,7 @@ GEM
8787
danger-rubocop (0.12.0)
8888
danger
8989
rubocop (~> 1.0)
90-
danger-swiftlint (0.33.0)
90+
danger-swiftlint (0.34.0)
9191
danger
9292
rake (> 10)
9393
thor (~> 0.19)
@@ -98,10 +98,9 @@ GEM
9898
diffy (3.4.2)
9999
digest-crc (0.6.5)
100100
rake (>= 12.0.0, < 14.0.0)
101-
domain_name (0.5.20190701)
102-
unf (>= 0.0.5, < 1.0.0)
101+
domain_name (0.6.20231109)
103102
dotenv (2.8.1)
104-
drb (2.1.1)
103+
drb (2.2.0)
105104
ruby2_keywords
106105
emoji_regex (3.2.3)
107106
excon (0.104.0)
@@ -136,7 +135,7 @@ GEM
136135
faraday_middleware (1.2.0)
137136
faraday (~> 1.0)
138137
fastimage (2.2.7)
139-
fastlane (2.216.0)
138+
fastlane (2.217.0)
140139
CFPropertyList (>= 2.3, < 4.0.0)
141140
addressable (>= 2.8, < 3.0.0)
142141
artifactory (~> 3.0)
@@ -197,7 +196,7 @@ GEM
197196
git (1.18.0)
198197
addressable (~> 2.8)
199198
rchardet (~> 1.8)
200-
google-apis-androidpublisher_v3 (0.51.0)
199+
google-apis-androidpublisher_v3 (0.53.0)
201200
google-apis-core (>= 0.11.0, < 2.a)
202201
google-apis-core (0.11.2)
203202
addressable (~> 2.5, >= 2.5.1)
@@ -212,19 +211,19 @@ GEM
212211
google-apis-core (>= 0.11.0, < 2.a)
213212
google-apis-playcustomapp_v1 (0.13.0)
214213
google-apis-core (>= 0.11.0, < 2.a)
215-
google-apis-storage_v1 (0.19.0)
216-
google-apis-core (>= 0.9.0, < 2.a)
214+
google-apis-storage_v1 (0.29.0)
215+
google-apis-core (>= 0.11.0, < 2.a)
217216
google-cloud-core (1.6.0)
218217
google-cloud-env (~> 1.0)
219218
google-cloud-errors (~> 1.0)
220219
google-cloud-env (1.6.0)
221220
faraday (>= 0.17.3, < 3.0)
222221
google-cloud-errors (1.3.1)
223-
google-cloud-storage (1.44.0)
222+
google-cloud-storage (1.45.0)
224223
addressable (~> 2.8)
225224
digest-crc (~> 0.4)
226225
google-apis-iamcredentials_v1 (~> 0.1)
227-
google-apis-storage_v1 (~> 0.19.0)
226+
google-apis-storage_v1 (~> 0.29.0)
228227
google-cloud-core (~> 1.6)
229228
googleauth (>= 0.16.2, < 2.a)
230229
mini_mime (~> 1.0)
@@ -255,12 +254,12 @@ GEM
255254
minitest (5.20.0)
256255
multi_json (1.15.0)
257256
multipart-post (2.3.0)
258-
mutex_m (0.1.2)
257+
mutex_m (0.2.0)
259258
nanaimo (0.3.0)
260259
nap (1.1.0)
261260
naturally (2.2.1)
262261
no_proxy_fix (0.1.2)
263-
nokogiri (1.15.4)
262+
nokogiri (1.15.5)
264263
mini_portile2 (~> 2.8.2)
265264
racc (~> 1.4)
266265
octokit (6.1.1)
@@ -279,8 +278,8 @@ GEM
279278
progress_bar (1.3.3)
280279
highline (>= 1.6, < 3)
281280
options (~> 2.3.0)
282-
public_suffix (5.0.3)
283-
racc (1.7.2)
281+
public_suffix (5.0.4)
282+
racc (1.7.3)
284283
rainbow (3.1.1)
285284
rake (13.1.0)
286285
rake-compiler (1.2.5)
@@ -335,9 +334,6 @@ GEM
335334
tzinfo (2.0.6)
336335
concurrent-ruby (~> 1.0)
337336
uber (0.1.0)
338-
unf (0.1.4)
339-
unf_ext
340-
unf_ext (0.0.8.2)
341337
unicode-display_width (2.5.0)
342338
webrick (1.8.1)
343339
word_wrap (1.0.0)

RELEASE-NOTES.txt

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,24 @@
11
*** PLEASE FOLLOW THIS FORMAT: [<priority indicator, more stars = higher priority>] <description> [<PR URL>]
22

3+
23.9
4+
-----
5+
6+
7+
23.8
8+
-----
9+
* [*] [Jetpack-only] Block Editor: Ensure text is always visible within Contact Info block [https://github.com/Automattic/jetpack/pull/33873]
10+
* [*] Block Editor: Ensure uploaded audio is always visible within Audio block [https://github.com/WordPress/gutenberg/pull/55627]
11+
* [*] Block Editor: In the deeply nested block warning, only display the ungroup option for blocks that support it [https://github.com/WordPress/gutenberg/pull/56445]
12+
* [**] Enable Optimize Image setting (via Me → App Settings) by default, and change default compression and resolution values. [https://github.com/wordpress-mobile/WordPress-Android/pull/19581]
13+
* [*] Fixed an issue that prevented theme installation on atomic sites [https://github.com/wordpress-mobile/WordPress-Android/pull/19668]
14+
315
23.7
416
-----
17+
* [***] [Jetpack-only] Added the All Domains screen enabling the users to manage their domains from within the app [https://github.com/wordpress-mobile/WordPress-Android/pull/19599]
18+
* [*] Block Editor: Fix error when pasting deeply nested structure content [https://github.com/WordPress/gutenberg/pull/55613]
19+
* [*] Block Editor: Fix crash related to accessing undefined value in `TextColorEdit` [https://github.com/WordPress/gutenberg/pull/55664]
20+
* [**] Posts & Pages: Redesigned the posts and pages screen. We’ve consolidated the “default” and “compact” display options [https://github.com/wordpress-mobile/WordPress-Android/issues/19341] & [https://github.com/wordpress-mobile/WordPress-Android/issues/19348]
21+
* [*] Posts & Pages: Moved actions to a context menu and added new actions such as “comment”, “settings” [https://github.com/wordpress-mobile/WordPress-Android/issues/19343] & [https://github.com/wordpress-mobile/WordPress-Android/issues/19356]
522

623
23.6
724
-----

WordPress/build.gradle

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,11 +138,11 @@ android {
138138
buildConfigField "boolean", "ENABLE_BLAZE_FEATURE", "false"
139139
buildConfigField "boolean", "WP_INDIVIDUAL_PLUGIN_OVERLAY", "false"
140140
buildConfigField "boolean", "SITE_EDITOR_MVP", "false"
141-
buildConfigField "boolean", "JETPACK_SOCIAL", "false"
142141
buildConfigField "boolean", "CONTACT_SUPPORT_CHATBOT", "false"
143142
buildConfigField "boolean", "ENABLE_DOMAIN_MANAGEMENT_FEATURE", "false"
144143
buildConfigField "boolean", "PLANS_IN_SITE_CREATION", "false"
145144
buildConfigField "boolean", "READER_IMPROVEMENTS", "false"
145+
buildConfigField "boolean", "BLOGANUARY_DASHBOARD_NUDGE", "false"
146146

147147
// Override these constants in jetpack product flavor to enable/ disable features
148148
buildConfigField "boolean", "ENABLE_SITE_CREATION", "true"
@@ -423,6 +423,7 @@ dependencies {
423423
implementation "com.google.android.gms:play-services-auth:$googlePlayServicesAuthVersion"
424424
implementation "com.google.android.gms:play-services-code-scanner:$googlePlayServicesCodeScannerVersion"
425425
implementation "com.google.mlkit:barcode-scanning-common:$googleMLKitBarcodeScanningVersion"
426+
426427
implementation "com.android.installreferrer:installreferrer:$androidInstallReferrerVersion"
427428
implementation "com.github.chrisbanes:PhotoView:$chrisbanesPhotoviewVersion"
428429
implementation "org.greenrobot:eventbus:$eventBusVersion"

WordPress/jetpack_metadata/PlayStoreStrings.po

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,20 +10,20 @@ msgstr ""
1010
"X-Generator: VsCode\n"
1111
"Project-Id-Version: Jetpack - Apps - Android - Release Notes\n"
1212

13-
msgctxt "release_note_236"
13+
msgctxt "release_note_238"
1414
msgid ""
15-
"23.6:\n"
16-
"- New domain/plan options and checkout screens in site creation process\n"
17-
"- My Site navigation has links to common sections\n"
18-
"- Inactive social icons and Synced Pattern titles are visible in dark mode for block-based themes\n"
19-
"- Content can be converted into blocks in the Classic editor\n"
15+
"23.8:\n"
16+
"- Block editor only shows the “ungroup” option for nested blocks that support it.\n"
17+
"- Optimize Images setting uses optimal size and quality by default.\n"
18+
"- Themes install properly for sites on Business and Commerce plans.\n"
2019
msgstr ""
2120

22-
msgctxt "release_note_235"
21+
msgctxt "release_note_237"
2322
msgid ""
24-
"23.5:\n"
25-
"We’ve made some visual changes to the reader, including feed cards, headers, buttons, recommendations, and more.\n"
26-
"In the block editor, you can now split or exit a formatted block by pressing the “enter” key three times. The left-hand border is always visible for quote blocks, too.\n"
23+
"23.7:\n"
24+
"- The All Domains screen lets you manage all your domains in the app.\n"
25+
"- Posts & Pages has improved display options and an expanded context menu.\n"
26+
"- We fixed block editor issues caused by pasting deeply nested content, or using text colors in older site themes.\n"
2727
msgstr ""
2828

2929
#. translators: Release notes for this version to be displayed in the Play Store. Limit to 500 characters including spaces and commas!
Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
- New domain/plan options and checkout screens in site creation process
2-
- My Site navigation has links to common sections
3-
- Inactive social icons and Synced Pattern titles are visible in dark mode for block-based themes
4-
- Content can be converted into blocks in the Classic editor
1+
- Block editor only shows the “ungroup” option for nested blocks that support it.
2+
- Optimize Images setting uses optimal size and quality by default.
3+
- Themes install properly for sites on Business and Commerce plans.

WordPress/metadata/PlayStoreStrings.po

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,19 @@ msgstr ""
1010
"X-Generator: VsCode\n"
1111
"Project-Id-Version: Release Notes & Play Store Descriptions\n"
1212

13-
msgctxt "release_note_236"
13+
msgctxt "release_note_238"
1414
msgid ""
15-
"23.6:\n"
16-
"- Inactive social icons and Synced Pattern titles are no longer invisible in block-based themes using dark mode. Good try, fellas, but you’re not as ninja as you think.\n"
17-
"- In the Classic editor, you can now convert your content into blocks with the click of a button.\n"
15+
"23.8:\n"
16+
"- Block editor only shows the “ungroup” option for nested blocks that support it.\n"
17+
"- Optimize Images setting uses optimal size and quality by default.\n"
18+
"- Themes install properly for sites on Business and Commerce plans.\n"
1819
msgstr ""
1920

20-
msgctxt "release_note_235"
21+
msgctxt "release_note_237"
2122
msgid ""
22-
"23.5:\n"
23-
"In the block editor, you can now split or exit a formatted block by pressing the “enter” key three times.\n"
24-
"The left-hand border is always visible for quote blocks, too, even in block-based themes on dark mode. And you can quote us on that.\n"
23+
"23.7:\n"
24+
"- The Posts & Pages screen now has clean, simple display options. The context menu also lets you access comments, settings, and other actions for a post or page.\n"
25+
"- We fixed block editor issues caused by pasting deeply nested content, or using text colors in older site themes.\n"
2526
msgstr ""
2627

2728
#. translators: Release notes for this version to be displayed in the Play Store. Limit to 500 characters including spaces and commas!
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
1-
- Inactive social icons and Synced Pattern titles are no longer invisible in block-based themes using dark mode. Good try, fellas, but you’re not as ninja as you think.
2-
- In the Classic editor, you can now convert your content into blocks with the click of a button.
1+
- Block editor only shows the “ungroup” option for nested blocks that support it.
2+
- Optimize Images setting uses optimal size and quality by default.
3+
- Themes install properly for sites on Business and Commerce plans.

WordPress/src/androidTest/java/org/wordpress/android/support/MockingInterceptor.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class MockingInterceptor : Interceptor {
1212
val request = chain.request()
1313

1414
// Redirect all WordPress.com API requests to local mock server
15-
if (request.url.host == "public-api.wordpress.com") {
15+
if (request.url.host == "public-api.wordpress.com" || request.url.host == "wordpress.com") {
1616
val newUrl = request.url.newBuilder()
1717
.scheme("http")
1818
.host("localhost")

0 commit comments

Comments
 (0)