Merge pull request #17383 from wordpress-mobile/fix/long-title-issue-on-stats

Make all stats card titles multiline

Author: ravishanker

WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/lists/sections/viewholders/TitleWithMoreViewHolder.kt

@@ -17,21 +17,12 @@ class TitleWithMoreViewHolder(parent: ViewGroup) : BlockListItemViewHolder(
     private val viewMore = itemView.findViewById<MaterialButton>(id.view_more_button)
 
     fun bind(item: TitleWithMore) {
-        title.multiLineText(item)
-        title.setTextOrHide(item.textResource,item.text)
+        title.setTextOrHide(item.textResource, item.text)
         if (item.navigationAction != null) {
             viewMore.isVisible = true
             viewMore.setOnClickListener { item.navigationAction.click() }
         } else {
             viewMore.visibility = View.GONE
         }
     }
-
-    fun TextView.multiLineText(item: TitleWithMore) {
-        this.visibility = View.VISIBLE
-        if(item.navigationAction == null){
-            this.ellipsize = null
-            this.maxLines = Int.MAX_VALUE
-        }
-    }
 }

WordPress/src/main/res/layout/stats_block_title_with_more_item.xml

@@ -10,12 +10,12 @@
 
     <com.google.android.material.textview.MaterialTextView
         android:id="@+id/text"
-        android:layout_width="0dp"
         style="@style/StatsBlockTitle"
-        android:layout_marginEnd="@dimen/margin_medium"
+        android:layout_width="0dp"
         android:layout_height="wrap_content"
-        android:text="@string/unknown"
+        android:layout_marginEnd="@dimen/margin_medium"
         android:layout_weight="1"
+        android:text="@string/unknown"
         tools:text="@string/stats_insights_views_and_visitors" />
 
     <com.google.android.material.button.MaterialButton

WordPress/src/main/res/values/stats_styles.xml

@@ -46,10 +46,7 @@
         <item name="android:paddingStart">@dimen/margin_extra_large</item>
     </style>
 
-    <style name="StatsBlockTitle" parent="TextAppearance.MaterialComponents.Headline6">
-        <item name="android:maxLines">1</item>
-        <item name="android:ellipsize">end</item>
-    </style>
+    <style name="StatsBlockTitle" parent="TextAppearance.MaterialComponents.Headline6"/>
 
     <style name="StatsDateSelectorTitle" parent="TextAppearance.MaterialComponents.Subtitle1">
         <item name="android:textStyle">bold</item>