Skip to content

Commit c97c1cd

Browse files
committed
Bind StatsListFragment to StatsFragment instead StatsActivity
This fixes not calling onScrollableViewInitialized in StatsFragment.
1 parent a337904 commit c97c1cd

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/StatsFragment.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ class StatsFragment : Fragment(R.layout.stats_fragment), ScrollableViewInitializ
7575
}
7676
}
7777
initializeViewModels(nonNullActivity, savedInstanceState == null, savedInstanceState)
78-
initializeViews(nonNullActivity)
78+
initializeViews()
7979
}
8080
}
8181

@@ -85,8 +85,8 @@ class StatsFragment : Fragment(R.layout.stats_fragment), ScrollableViewInitializ
8585
super.onSaveInstanceState(outState)
8686
}
8787

88-
private fun StatsFragmentBinding.initializeViews(activity: FragmentActivity) {
89-
val adapter = StatsPagerAdapter(activity)
88+
private fun StatsFragmentBinding.initializeViews() {
89+
val adapter = StatsPagerAdapter(this@StatsFragment)
9090
statsPager.adapter = adapter
9191
statsPager.setPageTransformer(
9292
MarginPageTransformer(resources.getDimensionPixelSize(R.dimen.margin_extra_large))
@@ -256,15 +256,15 @@ class StatsFragment : Fragment(R.layout.stats_fragment), ScrollableViewInitializ
256256
}
257257
}
258258

259-
class StatsPagerAdapter(val activity: FragmentActivity) : FragmentStateAdapter(activity) {
259+
class StatsPagerAdapter(private val parent: Fragment) : FragmentStateAdapter(parent) {
260260
override fun getItemCount(): Int = statsSections.size
261261

262262
override fun createFragment(position: Int): Fragment {
263263
return StatsListFragment.newInstance(statsSections[position])
264264
}
265265

266266
fun getTabTitle(position: Int): CharSequence {
267-
return activity.getString(statsSections[position].titleRes)
267+
return parent.context?.getString(statsSections[position].titleRes).orEmpty()
268268
}
269269
}
270270

0 commit comments

Comments
 (0)