Merge pull request #17034 from wordpress-mobile/issue/bottom-navigation-bar-and-notification-badge-colors

Fixes bottom navigation bar color and notification badge color

Author: zwarm

WordPress/src/main/AndroidManifest.xml

@@ -90,7 +90,7 @@
         <!-- Main tab activity -->
         <activity
             android:name=".ui.main.WPMainActivity"
-            android:theme="@style/WordPress.NoActionBar"
+            android:theme="@style/Wordpress.BottomBar"
             android:label="" />
 
         <!-- Account activities -->

WordPress/src/main/res/drawable/bg_nav_badge.xml

@@ -4,5 +4,5 @@
     <solid android:color="@color/accent"/>
     <stroke
         android:width="1dp"
-        android:color="@android:color/white"/>
+        android:color="@color/bottom_bar_notification_badge"/>
 </shape>

WordPress/src/main/res/values-night/colors.xml

@@ -5,6 +5,7 @@
     <!-- Switch to attribute after dropping support for api 21-23 -->
     <color name="placeholder">#1AFFFFFF</color>
     <color name="p2_author_bg_stroke">#1E1E1E</color>
+    <color name="bottom_bar_notification_badge">@color/background_dark_elevated</color>
 
     <!-- Login Prologue -->
     <color name="promo_indicator_color_default">@color/white_translucent_20</color>

WordPress/src/main/res/values-night/styles.xml

@@ -128,4 +128,8 @@
 
     <!-- Domains -->
     <style name="Domains.Button.Primary.Unelevated.OnPrimarySurface" parent="WordPress.Button.Primary.Unelevated" />
+
+    <style name="Wordpress.BottomBar" parent="WordPress.NoActionBar">
+        <item name="android:navigationBarColor">@color/background_dark_elevated</item>
+    </style>
 </resources>

WordPress/src/main/res/values/colors.xml

@@ -11,6 +11,7 @@
     <color name="background_snackbar">@color/neutral_80</color>
     <color name="link_reader">@color/primary</color>
     <color name="link_stats">@color/accent</color>
+    <color name="bottom_bar_notification_badge">@android:color/white</color>
 
     <!-- Switch to attribute after dropping support for api 21-23 -->
     <color name="placeholder">#1A000000</color>

WordPress/src/main/res/values/styles.xml

@@ -199,6 +199,8 @@
         <!-- We need to keep this here so we can override it in values-vXY -->
     </style>
 
+    <style name="Wordpress.BottomBar" parent="WordPress.NoActionBar"/>
+
     <style name="WordPress.NoActionBar" parent="WordPress">
         <item name="windowActionBar">false</item>
         <item name="windowNoTitle">true</item>