Merge pull request #17201 from wordpress-mobile/analysis/image-editor-all-warnings-as-errors

[Compile Warnings As Errors] Image Editor Module - Resolve Warnings & Enable All Warnings as Errors

Author: zwarm

libs/image-editor/build.gradle

@@ -18,6 +18,10 @@ android {
         vectorDrawables.useSupportLibrary = true
     }
 
+    kotlinOptions {
+        allWarningsAsErrors = true
+    }
+
     sourceSets {
         main.java.srcDirs += 'src/main/kotlin'
         test.java.srcDirs += 'src/test/kotlin'

libs/image-editor/src/main/kotlin/org/wordpress/android/imageeditor/crop/CropViewModel.kt

@@ -44,6 +44,7 @@ class CropViewModel : ViewModel() {
     private var shouldReturnToPreviewScreen: Boolean = false
     private var isStarted = false
 
+    @Suppress("DEPRECATION")
     private val cropOptions by lazy {
         Options().apply {
             setShowCropGrid(true)

libs/image-editor/src/main/kotlin/org/wordpress/android/imageeditor/preview/PreviewImageViewModel.kt

@@ -316,7 +316,7 @@ class PreviewImageViewModel : ViewModel() {
     private fun getOutputData() = (uiState.value?.viewPagerItemsStates?.map { OutputData(it.data.highResImageUrl) }
         ?: emptyList())
 
-    private fun isFileUrl(url: String): Boolean = url.toLowerCase(Locale.ROOT).startsWith(FILE_BASE)
+    private fun isFileUrl(url: String): Boolean = url.lowercase(Locale.ROOT).startsWith(FILE_BASE)
 
     data class ImageData(
         val id: Long = UUID.randomUUID().hashCode().toLong(),