Merge pull request #19583 from wordpress-mobile/analysis/use-updated-and-null-proof-theme-model-class

antonis · web-flow · commit e50da1d1101d · 2023-12-04T17:45:05.000+02:00
[Nullability Annotations to Java Classes] Use Updated and Null Proof `ThemeModel` Class (`breaking`)
diff --git a/WordPress/src/main/java/org/wordpress/android/ui/themes/ThemeBrowserActivity.java b/WordPress/src/main/java/org/wordpress/android/ui/themes/ThemeBrowserActivity.java
@@ -410,7 +410,7 @@ private void fetchInstalledThemesIfJetpackSite() {
         }
     }
 
-    private void activateTheme(String themeId) {
+    private void activateTheme(@NonNull String themeId) {
         if (!mSite.isUsingWpComRestApi()) {
             AppLog.i(T.THEMES, "Theme activation requires a site using WP.com REST API. Aborting request.");
             return;
diff --git a/WordPress/src/main/java/org/wordpress/android/ui/themes/ThemeBrowserAdapter.java b/WordPress/src/main/java/org/wordpress/android/ui/themes/ThemeBrowserAdapter.java
@@ -170,7 +170,10 @@ public View getView(int position, View convertView, ViewGroup parent) {
     }
 
     @SuppressWarnings("deprecation")
-    private void configureCardView(ThemeViewHolder themeViewHolder, boolean isCurrent) {
+    private void configureCardView(
+            @NonNull ThemeViewHolder themeViewHolder,
+            boolean isCurrent
+    ) {
         if (isCurrent) {
             ColorStateList color = ContextExtensionsKt.getColorStateListFromAttribute(
                     mContext,
@@ -200,10 +203,18 @@ private void configureCardView(ThemeViewHolder themeViewHolder, boolean isCurren
         }
     }
 
-    private void configureImageView(ThemeViewHolder themeViewHolder, String screenshotURL, final String themeId,
-                                    final boolean isCurrent) {
-        mImageManager.load(themeViewHolder.mImageView, ImageType.THEME, getUrlWithWidth(screenshotURL),
-                ScaleType.FIT_CENTER);
+    private void configureImageView(
+            @NonNull ThemeViewHolder themeViewHolder,
+            @NonNull String screenshotURL,
+            @NonNull final String themeId,
+            final boolean isCurrent
+    ) {
+        mImageManager.load(
+                themeViewHolder.mImageView,
+                ImageType.THEME,
+                getUrlWithWidth(screenshotURL),
+                ScaleType.FIT_CENTER
+        );
 
         themeViewHolder.mCardView.setOnClickListener(new View.OnClickListener() {
             @Override
@@ -217,16 +228,21 @@ public void onClick(View v) {
         });
     }
 
-    private String getUrlWithWidth(String screenshotURL) {
+    @NonNull
+    private String getUrlWithWidth(@NonNull String screenshotURL) {
         if (screenshotURL.contains("?")) {
             return screenshotURL + "&" + THEME_IMAGE_PARAMETER + mViewWidth;
         } else {
             return screenshotURL + "?" + THEME_IMAGE_PARAMETER + mViewWidth;
         }
     }
 
-    private void configureImageButton(ThemeViewHolder themeViewHolder, final String themeId, final boolean isPremium,
-                                      boolean isCurrent) {
+    private void configureImageButton(
+            @NonNull ThemeViewHolder themeViewHolder,
+            @NonNull final String themeId,
+            final boolean isPremium,
+            boolean isCurrent
+    ) {
         final PopupMenu popupMenu = new PopupMenu(mContext, themeViewHolder.mImageButton);
         popupMenu.getMenuInflater().inflate(R.menu.theme_more, popupMenu.getMenu());
 
diff --git a/WordPress/src/main/java/org/wordpress/android/ui/themes/ThemeBrowserFragment.kt b/WordPress/src/main/java/org/wordpress/android/ui/themes/ThemeBrowserFragment.kt
@@ -242,7 +242,7 @@ class ThemeBrowserFragment : Fragment(), AbsListView.RecyclerListener,
         }
     }
 
-    fun setCurrentThemeId(currentThemeId: String?) {
+    fun setCurrentThemeId(currentThemeId: String) {
         this.currentThemeId = currentThemeId
         refreshView()
     }
diff --git a/WordPress/src/main/java/org/wordpress/android/ui/themes/ThemeWebActivity.java b/WordPress/src/main/java/org/wordpress/android/ui/themes/ThemeWebActivity.java
@@ -54,8 +54,12 @@ public static String getSiteLoginUrl(SiteModel site) {
         return WPWebViewActivity.getSiteLoginUrl(site);
     }
 
-    public static void openTheme(Activity activity, @NonNull SiteModel site, @NonNull ThemeModel theme,
-                                 @NonNull ThemeWebActivityType type) {
+    public static void openTheme(
+            Activity activity,
+            @NonNull SiteModel site,
+            @NonNull ThemeModel theme,
+            @NonNull ThemeWebActivityType type
+    ) {
         String url = getUrl(site, theme, type, !theme.isFree());
         if (TextUtils.isEmpty(url)) {
             ToastUtils.showToast(activity, R.string.could_not_load_theme);
@@ -72,7 +76,12 @@ public static void openTheme(Activity activity, @NonNull SiteModel site, @NonNul
         }
     }
 
-    private static void openWPCOMURL(Activity activity, String url, ThemeModel theme, SiteModel site) {
+    private static void openWPCOMURL(
+            Activity activity,
+            String url,
+            @NonNull ThemeModel theme,
+            SiteModel site
+    ) {
         if (activity == null) {
             AppLog.e(AppLog.T.UTILS, "ThemeWebActivity requires a non-null activity");
             return;
@@ -95,6 +104,7 @@ private static void openWPCOMURL(Activity activity, String url, ThemeModel theme
         activity.startActivityForResult(intent, ThemeBrowserActivity.ACTIVATE_THEME);
     }
 
+    @Nullable
     public static String getIdentifierForCustomizer(@NonNull SiteModel site, @NonNull ThemeModel theme) {
         if (site.isJetpackConnected()) {
             return theme.getThemeId();
@@ -103,8 +113,13 @@ public static String getIdentifierForCustomizer(@NonNull SiteModel site, @NonNul
         }
     }
 
-    public static String getUrl(@NonNull SiteModel site, @NonNull ThemeModel theme, @NonNull ThemeWebActivityType type,
-                                boolean isPremium) {
+    @Nullable
+    public static String getUrl(
+            @NonNull SiteModel site,
+            @NonNull ThemeModel theme,
+            @NonNull ThemeWebActivityType type,
+            boolean isPremium
+    ) {
         if (theme.isWpComTheme()) {
             switch (type) {
                 case PREVIEW:
@@ -113,10 +128,14 @@ public static String getUrl(@NonNull SiteModel site, @NonNull ThemeModel theme,
                             .format(THEME_URL_PREVIEW, UrlUtils.getHost(site.getUrl()), domain, theme.getThemeId());
                 case DEMO:
                     String url = theme.getDemoUrl();
-                    if (url.contains("?")) {
-                        return url + "&" + THEME_URL_DEMO_PARAMETER;
+                    if (url != null) {
+                        if (url.contains("?")) {
+                            return url + "&" + THEME_URL_DEMO_PARAMETER;
+                        } else {
+                            return url + "?" + THEME_URL_DEMO_PARAMETER;
+                        }
                     } else {
-                        return url + "?" + THEME_URL_DEMO_PARAMETER;
+                        return null;
                     }
                 case DETAILS:
                     return String.format(THEME_URL_DETAILS, theme.getThemeId());
@@ -126,7 +145,12 @@ public static String getUrl(@NonNull SiteModel site, @NonNull ThemeModel theme,
         } else {
             switch (type) {
                 case PREVIEW:
-                    return site.getAdminUrl() + "customize.php?theme=" + getIdentifierForCustomizer(site, theme);
+                    String identifier = getIdentifierForCustomizer(site, theme);
+                    if (identifier != null) {
+                        return site.getAdminUrl() + "customize.php?theme=" + identifier;
+                    } else {
+                        return null;
+                    }
                 case DEMO:
                     return site.getAdminUrl() + "themes.php?theme=" + theme.getThemeId();
                 case DETAILS:
diff --git a/build.gradle b/build.gradle
@@ -22,7 +22,7 @@ ext {
     automatticTracksVersion = '3.3.0'
     gutenbergMobileVersion = 'v1.109.1'
     wordPressAztecVersion = 'v1.8.0'
-    wordPressFluxCVersion = 'trunk-cdc8effb2affbb1c6bcf01f6606c847f87071d28'
+    wordPressFluxCVersion = 'trunk-b4e51008f7200eba1dfdd22ca370fce450ce93b0'
     wordPressLoginVersion = '1.10.0'
     wordPressPersistentEditTextVersion = '1.0.2'
     wordPressUtilsVersion = '3.10.0'

Original file line number	Diff line number	Diff line change
`@@ -410,7 +410,7 @@ private void fetchInstalledThemesIfJetpackSite() {`
`410`	`410`	`}`
`411`	`411`	`}`
`412`	`412`
`413`		`- private void activateTheme(String themeId) {`
	`413`	`+ private void activateTheme(@NonNull String themeId) {`
`414`	`414`	`if (!mSite.isUsingWpComRestApi()) {`
`415`	`415`	`AppLog.i(T.THEMES, "Theme activation requires a site using WP.com REST API. Aborting request.");`
`416`	`416`	`return;`
Original file line number	Diff line number	Diff line change
`@@ -242,7 +242,7 @@ class ThemeBrowserFragment : Fragment(), AbsListView.RecyclerListener,`
`242`	`242`	`}`
`243`	`243`	`}`
`244`	`244`
`245`		`- fun setCurrentThemeId(currentThemeId: String?) {`
	`245`	`+ fun setCurrentThemeId(currentThemeId: String) {`
`246`	`246`	`this.currentThemeId = currentThemeId`
`247`	`247`	`refreshView()`
`248`	`248`	`}`