Commit e909423
committed
Fix Sentry JETPACK-ANDROID-1G9S and 1J82: avoid openUrl with empty url
ReaderActivityLauncher.openUrl() guards null/empty urls by reporting to
Sentry and returning, so these two issues are handled reports rather than
crashes. The root cause is two call sites passing empty urls, which also
left the user with a button that silently does nothing.
CommentDetailFragment only checked getAuthorUrl() != null, so an empty
author url still wired up a dead click listener. WPWebViewActivity's
"open in external browser" used mWebView.getUrl(), which is null until
the first page load finishes; it now falls back to the URL_TO_LOAD extra.
Fixes JETPACK-ANDROID-1G9S
Fixes JETPACK-ANDROID-1J821 parent 3ab17e4 commit e909423
2 files changed
Lines changed: 12 additions & 3 deletions
File tree
- WordPress/src/main/java/org/wordpress/android/ui
- comments
Lines changed: 11 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
348 | 348 | | |
349 | 349 | | |
350 | 350 | | |
351 | | - | |
352 | | - | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
353 | 362 | | |
354 | 363 | | |
355 | 364 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
831 | 831 | | |
832 | 832 | | |
833 | 833 | | |
834 | | - | |
| 834 | + | |
835 | 835 | | |
836 | 836 | | |
837 | 837 | | |
| |||
0 commit comments