Skip to content

Commit ed65f17

Browse files
authored
Merge pull request #16994 from wordpress-mobile/issue/16874-site-creation-skip-buttons-green
Color site creation skip buttons green in Jetpack App
2 parents 506c774 + 38654d7 commit ed65f17

8 files changed

Lines changed: 18 additions & 14 deletions

File tree

RELEASE-NOTES.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
20.5
44
-----
55
* [*] Use larger thumbnail previews for recommended themes during site creation [https://github.com/wordpress-mobile/WordPress-Android/pull/16848]
6-
6+
* [*] Jetpack App: Use the Jetpack green color for the skip buttons text in site creation [https://github.com/wordpress-mobile/WordPress-Android/pull/16994]
77

88
20.4
99
-----
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
3+
<resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="UnusedResources">
4+
5+
<!-- Site creation -->
6+
<color name="site_creation_skip_button_text">@color/jetpack_green_40</color>
7+
</resources>

WordPress/src/main/java/org/wordpress/android/ui/sitecreation/domains/SiteCreationDomainsFragment.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ class SiteCreationDomainsFragment : SiteCreationBaseFormFragment() {
8686
searchInputWithHeader?.updateSearchInput(requireActivity(), uiState.searchInputUiState)
8787
updateContentUiState(uiState.contentState)
8888
uiHelpers.updateVisibility(createSiteButtonContainer, uiState.createSiteButtonContainerVisibility)
89-
uiHelpers.updateVisibility(createSiteButtonShaddow, uiState.createSiteButtonContainerVisibility)
89+
uiHelpers.updateVisibility(createSiteButtonShadow, uiState.createSiteButtonContainerVisibility)
9090
updateTitleVisibility(uiState.headerUiState == null)
9191
}
9292
})

WordPress/src/main/res/layout/home_page_picker_titlebar.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
<Button
2727
android:id="@+id/skipButton"
28-
style="@style/HomePagePickerSkipButton"
28+
style="@style/SiteCreationSkipButton"
2929
android:layout_width="wrap_content"
3030
android:layout_height="wrap_content"
3131
android:layout_gravity="end"

WordPress/src/main/res/layout/site_creation_domains_screen.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
app:layout_constraintTop_toBottomOf="@id/site_creation_search_input_item" />
5858

5959
<View
60-
android:id="@+id/create_site_button_shaddow"
60+
android:id="@+id/create_site_button_shadow"
6161
android:layout_width="match_parent"
6262
android:layout_height="@dimen/mlp_bottom_shadow_height"
6363
android:background="@drawable/modal_layout_picker_bottom_shadow"

WordPress/src/main/res/layout/site_creation_intents_titlebar.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,7 @@
2323

2424
<Button
2525
android:id="@+id/skipButton"
26-
style="@style/Widget.MaterialComponents.Button.TextButton"
27-
android:textColor="@color/blue_50"
28-
android:textSize="@dimen/text_sz_medium"
26+
style="@style/SiteCreationSkipButton"
2927
android:layout_width="wrap_content"
3028
android:layout_height="wrap_content"
3129
android:layout_gravity="end"

WordPress/src/main/res/values/colors.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,5 +123,6 @@
123123
<color name="grey_900">#ff212121</color>
124124

125125
<!-- Site creation -->
126+
<color name="site_creation_skip_button_text">@color/blue_50</color>
126127
<color name="site_creation_intent_item_emoji_bg">@color/grey_lighten_30</color>
127128
</resources>

WordPress/src/main/res/values/styles.xml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1512,7 +1512,11 @@
15121512
<item name="android:paddingBottom">@dimen/margin_small_medium</item>
15131513
</style>
15141514

1515-
<!-- Site Creation Header Styles -->
1515+
<!-- Site Creation Styles -->
1516+
<style name="SiteCreationSkipButton" parent="Widget.MaterialComponents.Button.TextButton">
1517+
<item name="android:textColor">@color/site_creation_skip_button_text</item>
1518+
<item name="android:textSize">@dimen/text_sz_medium</item>
1519+
</style>
15161520

15171521
<style name="SiteCreationHeaderV2Text">
15181522
<item name="android:layout_width">match_parent</item>
@@ -1647,12 +1651,6 @@
16471651
<item name="android:textAllCaps">true</item>
16481652
</style>
16491653

1650-
<!-- Home Page Picker Styles -->
1651-
<style name="HomePagePickerSkipButton" parent="Widget.MaterialComponents.Button.TextButton">
1652-
<item name="android:textColor">@color/blue_50</item>
1653-
<item name="android:textSize">@dimen/text_sz_medium</item>
1654-
</style>
1655-
16561654
<!-- Invite Links -->
16571655
<style name="WordPress.Invite.Button.Primary" parent="Widget.MaterialComponents.Button.UnelevatedButton">
16581656
<item name="materialThemeOverlay">@style/ThemeOverlay.Invite.Button.Secondary</item>

0 commit comments

Comments
 (0)