Merge pull request #19658 from wordpress-mobile/task/remove-ImageSettingsDialogFragment

Removes ImageSettingsDialogFragment which is not used anymore

Author: antonis

WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java

@@ -71,7 +71,6 @@
 import org.wordpress.android.editor.EditorMediaUtils;
 import org.wordpress.android.editor.EditorThemeUpdateListener;
 import org.wordpress.android.editor.ExceptionLogger;
-import org.wordpress.android.editor.ImageSettingsDialogFragment;
 import org.wordpress.android.editor.gutenberg.DialogVisibility;
 import org.wordpress.android.editor.gutenberg.GutenbergEditorFragment;
 import org.wordpress.android.editor.gutenberg.GutenbergPropsBuilder;
@@ -1487,17 +1486,6 @@ public void onRequestPermissionsResult(int requestCode,
     }
 
     private boolean handleBackPressed() {
-        Fragment fragment = getSupportFragmentManager().findFragmentByTag(
-                ImageSettingsDialogFragment.IMAGE_SETTINGS_DIALOG_TAG);
-        if (fragment != null && fragment.isVisible()) {
-            if (fragment instanceof ImageSettingsDialogFragment) {
-                ImageSettingsDialogFragment imFragment = (ImageSettingsDialogFragment) fragment;
-                imFragment.dismissFragment();
-            }
-
-            return false;
-        }
-
         if (mViewPager.getCurrentItem() == PAGE_PUBLISH_SETTINGS) {
             mViewPager.setCurrentItem(PAGE_SETTINGS);
             invalidateOptionsMenu();

libs/editor/src/main/java/org/wordpress/android/editor/ImageSettingsDialogFragment.java

@@ -29,17 +29,13 @@
     <dimen name="sourceview_top_margin">15dp</dimen>
     <dimen name="sourceview_title_bottom_margin">15dp</dimen>
 
-    <dimen name="image_settings_dialog_padding">16dp</dimen>
     <dimen name="image_settings_dialog_extra_margin">0dp</dimen>
     <dimen name="image_settings_dialog_extra_margin_tablet">84dp</dimen>
     <dimen name="image_settings_dialog_label_indent">4dp</dimen>
     <dimen name="image_settings_dialog_label_margin_bottom">4dp</dimen>
     <dimen name="image_settings_dialog_input_margin_bottom">16dp</dimen>
-    <dimen name="image_settings_dialog_input_field_start_margin">-4dp</dimen>
     <dimen name="image_settings_dialog_top_separator_margin_top">16dp</dimen>
-    <dimen name="image_settings_dialog_thumbnail_container_margin_bottom">8dp</dimen>
     <dimen name="image_settings_dialog_thumbnail_size">100dp</dimen>
-    <dimen name="image_settings_dialog_thumbnail_progress_size">50dp</dimen>
     <dimen name="image_settings_dialog_thumbnail_left_margin">4dp</dimen>
     <dimen name="image_settings_dialog_thumbnail_right_margin">8dp</dimen>
     <dimen name="image_settings_dialog_filename_margin_left">16dp</dimen>

libs/editor/src/main/res/layout/dialog_image_options.xml

@@ -1,5 +1,4 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
     <bool name="is_large_tablet_landscape">false</bool>
-    <bool name="show_extra_side_padding">false</bool>
 </resources>

libs/editor/src/main/res/layout/image_settings_formatbar.xml

@@ -39,16 +39,4 @@
         <item name="android:layout_marginStart">@dimen/format_bar_button_group_tablet</item>
         <item name="android:layout_marginEnd">@dimen/format_bar_button_group_tablet</item>
     </style>
-
-    <style name="ImageOptionsDialogLabel">
-        <item name="android:textColor">@color/image_options_label</item>
-        <item name="android:textStyle">bold</item>
-        <item name="android:paddingLeft">@dimen/image_settings_dialog_label_indent</item>
-        <item name="android:paddingStart">@dimen/image_settings_dialog_label_indent</item>
-        <item name="android:layout_marginBottom">@dimen/image_settings_dialog_label_margin_bottom</item>
-    </style>
-
-    <style name="ImageOptionsDialogInput">
-        <item name="android:layout_marginBottom">@dimen/image_settings_dialog_input_margin_bottom</item>
-    </style>
 </resources>