Don't show featured image when none exists (#22738)

* Start reader improvements feature branch

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Remove content-scanning fallbacks for Reader featured image

Only use editorial.image, featured_image, or featured_media.uri
as featured image sources instead of scanning post content for
suitable images or videos.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Move featured image above title and excerpt in Reader post cards

Reorder ConstraintLayout constraints so the visual hierarchy is:
blog header → featured image → title → excerpt → interactions → footer

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Fix grammar in code comments

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: nbradbury

WordPress/src/main/java/org/wordpress/android/models/ReaderCardType.java

@@ -47,7 +47,7 @@ && new ReaderImageScanner(post.getText(), post.isPrivate)
     }
 
     /*
-     * returns true if the post's content is 100 characters or less
+     * returns true if the post's content is 100 characters or fewer
      */
     private static boolean hasMinContent(@NonNull ReaderPost post) {
         if (post.getExcerpt().length() > MIN_CONTENT_CHARS) {

WordPress/src/main/java/org/wordpress/android/models/ReaderPost.java

@@ -8,8 +8,6 @@
 import org.wordpress.android.ui.Organization;
 import org.wordpress.android.ui.reader.ReaderConstants;
 import org.wordpress.android.ui.reader.models.ReaderBlogIdPostId;
-import org.wordpress.android.ui.reader.utils.ReaderIframeScanner;
-import org.wordpress.android.ui.reader.utils.ReaderImageScanner;
 import org.wordpress.android.ui.reader.utils.ReaderUtils;
 import org.wordpress.android.util.DateTimeUtilsWrapper;
 import org.wordpress.android.util.HtmlUtils;
@@ -204,21 +202,6 @@ public static ReaderPost fromJson(JSONObject json) {
             }
         }
 
-        // if the post doesn't have a featured image but it contains an IMG tag, check whether
-        // we can find a suitable image from the content
-        if (!post.hasFeaturedImage() && post.hasImages()) {
-            post.mFeaturedImage = new ReaderImageScanner(post.mText, post.isPrivate)
-                    .getLargestImage(ReaderConstants.MIN_FEATURED_IMAGE_WIDTH);
-        }
-
-        // if there's no featured image or featured video and the post contains an iframe, scan
-        // the content for a suitable featured video
-        if (!post.hasFeaturedImage()
-            && !post.hasFeaturedVideo()
-            && post.getText().contains("<iframe")) {
-            post.setFeaturedVideo(new ReaderIframeScanner(post.getText()).getFirstUsableVideo());
-        }
-
         // "railcar" data - currently used in search streams, used by TrainTracks
         JSONObject jsonRailcar = json.optJSONObject("railcar");
         if (jsonRailcar != null) {

WordPress/src/main/java/org/wordpress/android/ui/reader/utils/ReaderImageScanner.kt

@@ -62,7 +62,7 @@ class ReaderImageScanner(private val content: String, private val isPrivate: Boo
     }
 
     /*
-     * returns true if there at least `minImageCount` images in the post content that are at
+     * returns true if there is at least `minImageCount` images in the post content that are at
      * least `minImageWidth` in size
      */
     fun hasUsableImageCount(minImageCount: Int, minImageWidth: Int): Boolean {

WordPress/src/main/res/layout/reader_cardview_post_new.xml

@@ -36,7 +36,7 @@
             android:layout_marginTop="@dimen/margin_medium"
             app:layout_constraintStart_toStartOf="parent"
             app:layout_constraintEnd_toEndOf="parent"
-            app:layout_constraintTop_toBottomOf="@id/layout_blog_section"
+            app:layout_constraintTop_toBottomOf="@id/reader_card_images_bottom_barrier"
             app:layout_constraintBottom_toTopOf="@+id/text_excerpt"
             tools:text="This the tile of this post - Lorem ipsum dolor sit amet, consectetur adipiscing elit" />
 
@@ -63,7 +63,7 @@
             app:layout_constraintDimensionRatio="16:9"
             app:layout_constraintEnd_toEndOf="parent"
             app:layout_constraintStart_toStartOf="parent"
-            app:layout_constraintTop_toBottomOf="@id/text_excerpt"
+            app:layout_constraintTop_toBottomOf="@id/layout_blog_section"
             tools:src="@color/blue_light" />
 
         <ImageView
@@ -90,7 +90,7 @@
             android:layout_marginTop="@dimen/margin_medium"
             app:layout_constraintStart_toStartOf="parent"
             app:layout_constraintEnd_toEndOf="parent"
-            app:layout_constraintTop_toBottomOf="@id/text_excerpt"
+            app:layout_constraintTop_toBottomOf="@id/layout_blog_section"
             tools:visibility="visible"
             tools:layout_height="150dp" />
 
@@ -112,7 +112,7 @@
             app:layout_constraintHorizontal_bias="0"
             app:layout_constraintStart_toStartOf="parent"
             app:layout_constraintEnd_toStartOf="@id/reader_card_dot_separator"
-            app:layout_constraintTop_toBottomOf="@id/reader_card_images_bottom_barrier"
+            app:layout_constraintTop_toBottomOf="@id/text_excerpt"
             app:layout_constrainedWidth="true"
             tools:text="15 likes" />
 
@@ -127,7 +127,7 @@
             android:importantForAccessibility="no"
             app:layout_constraintStart_toEndOf="@id/reader_card_like_count"
             app:layout_constraintEnd_toStartOf="@id/reader_card_comment_count"
-            app:layout_constraintTop_toBottomOf="@id/reader_card_images_bottom_barrier"
+            app:layout_constraintTop_toBottomOf="@id/text_excerpt"
             app:layout_constrainedWidth="true" />
 
         <com.google.android.material.textview.MaterialTextView
@@ -138,7 +138,7 @@
             android:layout_marginTop="@dimen/margin_medium"
             app:layout_constraintStart_toEndOf="@id/reader_card_dot_separator"
             app:layout_constraintEnd_toEndOf="parent"
-            app:layout_constraintTop_toBottomOf="@id/reader_card_images_bottom_barrier"
+            app:layout_constraintTop_toBottomOf="@id/text_excerpt"
             app:layout_constrainedWidth="true"
             tools:text="4 comments" />