Analysis: Resolve test function name characters test warnings

ParaskP7 · ParaskP7 · commit f36f0639e7ad · 2022-10-11T18:17:08.000+03:00
Warning Message: "Name contains characters which can cause problems on
Windows: "

Renaming '"xyz"' to ''xyz'' resolves this kind of 'name character'
warnings.

Also, as part of this commit, a few other minor warnings, including
imports, got resolved too.
diff --git a/WordPress/src/test/java/org/wordpress/android/ui/posts/PostSettingsUtilsTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/posts/PostSettingsUtilsTest.kt
@@ -71,7 +71,7 @@ class PostSettingsUtilsTest : BaseUnitTest() {
     }
 
     @Test
-    fun `returns "scheduled for" for scheduled post`() {
+    fun `returns 'scheduled for' for scheduled post`() {
         postModel.setStatus(PostStatus.SCHEDULED.toString())
         postModel.setDateCreated(dateCreated)
 
@@ -81,7 +81,7 @@ class PostSettingsUtilsTest : BaseUnitTest() {
     }
 
     @Test
-    fun `returns "published on" for published post`() {
+    fun `returns 'published on' for published post`() {
         postModel.setStatus(PostStatus.PUBLISHED.toString())
         postModel.setDateCreated(dateCreated)
 
@@ -91,7 +91,7 @@ class PostSettingsUtilsTest : BaseUnitTest() {
     }
 
     @Test
-    fun `returns "published on" for private post`() {
+    fun `returns 'published on' for private post`() {
         postModel.setStatus(PostStatus.PRIVATE.toString())
         postModel.setDateCreated(dateCreated)
 
@@ -101,7 +101,7 @@ class PostSettingsUtilsTest : BaseUnitTest() {
     }
 
     @Test
-    fun `returns "scheduled for" for private post that is local and scheduled`() {
+    fun `returns 'scheduled for' for private post that is local and scheduled`() {
         postModel.setStatus(PostStatus.PRIVATE.toString())
         postModel.setIsLocalDraft(true)
 
@@ -115,7 +115,7 @@ class PostSettingsUtilsTest : BaseUnitTest() {
     }
 
     @Test
-    fun `returns "backdated for" for local draft when publish date in the past`() {
+    fun `returns 'backdated for' for local draft when publish date in the past`() {
         postModel.setIsLocalDraft(true)
         postModel.setDateCreated(dateCreated)
 
@@ -125,7 +125,7 @@ class PostSettingsUtilsTest : BaseUnitTest() {
     }
 
     @Test
-    fun `returns "immediately" for local draft when should publish immediately`() {
+    fun `returns 'immediately' for local draft when should publish immediately`() {
         postModel.setIsLocalDraft(true)
         postModel.setStatus(PostStatus.DRAFT.toString())
         postModel.setDateCreated(currentDate)
@@ -136,7 +136,7 @@ class PostSettingsUtilsTest : BaseUnitTest() {
     }
 
     @Test
-    fun `returns "immediately" for local private post that should publish immediately`() {
+    fun `returns 'immediately' for local private post that should publish immediately`() {
         postModel.setIsLocalDraft(true)
         postModel.setStatus(PostStatus.PRIVATE.toString())
         postModel.setDateCreated(currentDate)
@@ -147,7 +147,7 @@ class PostSettingsUtilsTest : BaseUnitTest() {
     }
 
     @Test
-    fun `returns "publish on" for local draft when date within the next 30 minutes`() {
+    fun `returns 'publish on' for local draft when date within the next 30 minutes`() {
         postModel.setIsLocalDraft(true)
 
         // This date is 5 minutes before the currentDate
@@ -161,7 +161,7 @@ class PostSettingsUtilsTest : BaseUnitTest() {
     }
 
     @Test
-    fun `returns "schedule for" when post published in future`() {
+    fun `returns 'schedule for' when post published in future`() {
         // two hours ahead of the currentDate
         val futureDate = "2019-05-05T22:28:20+0200"
 
@@ -173,7 +173,7 @@ class PostSettingsUtilsTest : BaseUnitTest() {
     }
 
     @Test
-    fun `returns "immediately" when post does not have the date and is draft`() {
+    fun `returns 'immediately' when post does not have the date and is draft`() {
         postModel.setStatus(PostStatus.DRAFT.toString())
         postModel.setDateCreated("")
 
@@ -183,7 +183,7 @@ class PostSettingsUtilsTest : BaseUnitTest() {
     }
 
     @Test
-    fun `returns "immediately" in other cases`() {
+    fun `returns 'immediately' in other cases`() {
         postModel.setDateCreated("")
 
         val publishedDate = postSettingsUtils.getPublishDateLabel(postModel)
diff --git a/WordPress/src/test/java/org/wordpress/android/viewmodel/pages/CreatePageListItemLabelsUseCaseTest.kt b/WordPress/src/test/java/org/wordpress/android/viewmodel/pages/CreatePageListItemLabelsUseCaseTest.kt
@@ -308,7 +308,7 @@ class CreatePageListItemLabelsUseCaseTest {
     }
 
     @Test
-    fun `when a page is locally changed and is local draft only "Local draft" label is displayed`() {
+    fun `when a page is locally changed and is local draft only 'Local draft' label is displayed`() {
         val (labels, _) = useCase.createLabels(
                 PostModel().apply {
                     setIsLocallyChanged(true)
diff --git a/WordPress/src/test/java/org/wordpress/android/viewmodel/posts/PostListItemUiStateHelperTest.kt b/WordPress/src/test/java/org/wordpress/android/viewmodel/posts/PostListItemUiStateHelperTest.kt
@@ -13,20 +13,12 @@ import org.wordpress.android.analytics.AnalyticsTracker
 import org.wordpress.android.fluxc.model.PostModel
 import org.wordpress.android.fluxc.model.SiteModel
 import org.wordpress.android.fluxc.model.post.PostStatus
-import org.wordpress.android.fluxc.model.post.PostStatus.DRAFT
-import org.wordpress.android.fluxc.model.post.PostStatus.PENDING
-import org.wordpress.android.fluxc.model.post.PostStatus.PRIVATE
-import org.wordpress.android.fluxc.model.post.PostStatus.PUBLISHED
-import org.wordpress.android.fluxc.model.post.PostStatus.SCHEDULED
 import org.wordpress.android.fluxc.store.MediaStore.MediaError
 import org.wordpress.android.fluxc.store.MediaStore.MediaErrorType
-import org.wordpress.android.fluxc.store.MediaStore.MediaErrorType.AUTHORIZATION_REQUIRED
 import org.wordpress.android.fluxc.store.PostStore.PostError
-import org.wordpress.android.fluxc.store.PostStore.PostErrorType.GENERIC_ERROR
+import org.wordpress.android.fluxc.store.PostStore.PostErrorType
 import org.wordpress.android.fluxc.store.UploadStore.UploadError
 import org.wordpress.android.ui.posts.AuthorFilterSelection
-import org.wordpress.android.ui.posts.AuthorFilterSelection.EVERYONE
-import org.wordpress.android.ui.posts.AuthorFilterSelection.ME
 import org.wordpress.android.ui.posts.PostModelUploadStatusTracker
 import org.wordpress.android.ui.prefs.AppPrefsWrapper
 import org.wordpress.android.ui.utils.UiString.UiStringRes
@@ -45,11 +37,11 @@ import org.wordpress.android.widgets.PostListButtonType
 
 private const val FORMATTER_DATE = "January 1st, 1:35pm"
 
-private val POST_STATE_PUBLISH = PUBLISHED.toString()
-private val POST_STATE_SCHEDULED = SCHEDULED.toString()
-private val POST_STATE_PRIVATE = PRIVATE.toString()
-private val POST_STATE_PENDING = PENDING.toString()
-private val POST_STATE_DRAFT = DRAFT.toString()
+private val POST_STATE_PUBLISH = PostStatus.PUBLISHED.toString()
+private val POST_STATE_SCHEDULED = PostStatus.SCHEDULED.toString()
+private val POST_STATE_PRIVATE = PostStatus.PRIVATE.toString()
+private val POST_STATE_PENDING = PostStatus.PENDING.toString()
+private val POST_STATE_DRAFT = PostStatus.DRAFT.toString()
 private val POST_STATE_TRASHED = PostStatus.TRASHED.toString()
 
 @Suppress("LargeClass")
@@ -498,7 +490,7 @@ class PostListItemUiStateHelperTest {
                 )
         ).thenReturn(
                 createFailedUploadUiState(
-                        UploadError(MediaError(AUTHORIZATION_REQUIRED)),
+                        UploadError(MediaError(MediaErrorType.AUTHORIZATION_REQUIRED)),
                         isEligibleForAutoUpload = true
                 )
         )
@@ -606,7 +598,7 @@ class PostListItemUiStateHelperTest {
     @Test
     fun `error uploading media label shown when the media upload fails`() {
         whenever(uploadUiStateUseCase.createUploadUiState(anyOrNull(), anyOrNull(), anyOrNull())).thenReturn(
-                createFailedUploadUiState(uploadError = UploadError(MediaError(AUTHORIZATION_REQUIRED)))
+                createFailedUploadUiState(uploadError = UploadError(MediaError(MediaErrorType.AUTHORIZATION_REQUIRED)))
         )
         val state = createPostListItemUiState()
         assertThat(state.data.statuses).contains(UiStringRes(R.string.error_media_recover_post))
@@ -616,7 +608,7 @@ class PostListItemUiStateHelperTest {
     fun `generic error message shown when upload fails from unknown reason`() {
         val errorMsg = "testing error message"
         whenever(uploadUiStateUseCase.createUploadUiState(anyOrNull(), anyOrNull(), anyOrNull())).thenReturn(
-                createFailedUploadUiState(uploadError = UploadError(PostError(GENERIC_ERROR, errorMsg)))
+                createFailedUploadUiState(uploadError = UploadError(PostError(PostErrorType.GENERIC_ERROR, errorMsg)))
         )
         val state = createPostListItemUiState()
         assertThat(state.data.statuses).contains(UiStringRes(R.string.error_generic_error))
@@ -625,7 +617,7 @@ class PostListItemUiStateHelperTest {
     @Test
     fun `given a mix of info and error statuses, only the error status is shown`() {
         whenever(uploadUiStateUseCase.createUploadUiState(anyOrNull(), anyOrNull(), anyOrNull())).thenReturn(
-                createFailedUploadUiState(uploadError = UploadError(MediaError(AUTHORIZATION_REQUIRED)))
+                createFailedUploadUiState(uploadError = UploadError(MediaError(MediaErrorType.AUTHORIZATION_REQUIRED)))
         )
         val state = createPostListItemUiState(
                 post = createPostModel(isLocallyChanged = true, status = POST_STATE_PRIVATE)
@@ -643,11 +635,8 @@ class PostListItemUiStateHelperTest {
                 )
         ).thenReturn(
                 createFailedUploadUiState(
-                        uploadError = UploadError(
-                                MediaError(
-                                        AUTHORIZATION_REQUIRED
-                                )
-                        ), isEligibleForAutoUpload = true
+                        uploadError = UploadError(MediaError(MediaErrorType.AUTHORIZATION_REQUIRED)),
+                        isEligibleForAutoUpload = true
                 )
         )
         val state = createPostListItemUiState(
@@ -661,7 +650,7 @@ class PostListItemUiStateHelperTest {
     fun `media upload error shown with specific message for pending post not eligible for auto-upload`() {
         whenever(uploadUiStateUseCase.createUploadUiState(anyOrNull(), anyOrNull(), anyOrNull())).thenReturn(
                 createFailedUploadUiState(
-                        uploadError = UploadError(MediaError(AUTHORIZATION_REQUIRED)),
+                        uploadError = UploadError(MediaError(MediaErrorType.AUTHORIZATION_REQUIRED)),
                         isEligibleForAutoUpload = false,
                         retryWillPushChanges = true
                 )
@@ -676,7 +665,7 @@ class PostListItemUiStateHelperTest {
     fun `media upload error shown with specific message for scheduled post eligible for auto-upload`() {
         whenever(uploadUiStateUseCase.createUploadUiState(anyOrNull(), anyOrNull(), anyOrNull())).thenReturn(
                 createFailedUploadUiState(
-                        uploadError = UploadError(MediaError(AUTHORIZATION_REQUIRED)),
+                        uploadError = UploadError(MediaError(MediaErrorType.AUTHORIZATION_REQUIRED)),
                         isEligibleForAutoUpload = true
                 )
         )
@@ -691,7 +680,7 @@ class PostListItemUiStateHelperTest {
     fun `media upload error shown with specific message for scheduled post not eligible for auto-upload`() {
         whenever(uploadUiStateUseCase.createUploadUiState(anyOrNull(), anyOrNull(), anyOrNull())).thenReturn(
                 createFailedUploadUiState(
-                        uploadError = UploadError(MediaError(AUTHORIZATION_REQUIRED)),
+                        uploadError = UploadError(MediaError(MediaErrorType.AUTHORIZATION_REQUIRED)),
                         isEligibleForAutoUpload = false,
                         retryWillPushChanges = true
                 )
@@ -706,7 +695,7 @@ class PostListItemUiStateHelperTest {
     fun `retrying media upload shown for draft eligible for auto-upload`() {
         whenever(uploadUiStateUseCase.createUploadUiState(anyOrNull(), anyOrNull(), anyOrNull())).thenReturn(
                 createFailedUploadUiState(
-                        uploadError = UploadError(MediaError(AUTHORIZATION_REQUIRED)),
+                        uploadError = UploadError(MediaError(MediaErrorType.AUTHORIZATION_REQUIRED)),
                         isEligibleForAutoUpload = true
                 )
         )
@@ -720,7 +709,7 @@ class PostListItemUiStateHelperTest {
     fun `base media upload error shown for draft not eligible for auto-upload`() {
         whenever(uploadUiStateUseCase.createUploadUiState(anyOrNull(), anyOrNull(), anyOrNull())).thenReturn(
                 createFailedUploadUiState(
-                        uploadError = UploadError(MediaError(AUTHORIZATION_REQUIRED)),
+                        uploadError = UploadError(MediaError(MediaErrorType.AUTHORIZATION_REQUIRED)),
                         isEligibleForAutoUpload = false,
                         retryWillPushChanges = false
                 )
@@ -735,7 +724,7 @@ class PostListItemUiStateHelperTest {
     fun `base upload error shown on GENERIC ERROR and not eligible for auto upload`() {
         whenever(uploadUiStateUseCase.createUploadUiState(anyOrNull(), anyOrNull(), anyOrNull())).thenReturn(
                 createFailedUploadUiState(
-                        uploadError = UploadError(PostError(GENERIC_ERROR)),
+                        uploadError = UploadError(PostError(PostErrorType.GENERIC_ERROR)),
                         isEligibleForAutoUpload = false,
                         retryWillPushChanges = false
                 )
@@ -750,7 +739,7 @@ class PostListItemUiStateHelperTest {
     fun `retrying upload shown for draft eligible for auto-upload`() {
         whenever(uploadUiStateUseCase.createUploadUiState(anyOrNull(), anyOrNull(), anyOrNull())).thenReturn(
                 createFailedUploadUiState(
-                        uploadError = UploadError(PostError(GENERIC_ERROR)),
+                        uploadError = UploadError(PostError(PostErrorType.GENERIC_ERROR)),
                         isEligibleForAutoUpload = true,
                         retryWillPushChanges = true
                 )
@@ -823,7 +812,7 @@ class PostListItemUiStateHelperTest {
     @Test
     fun `show overlay when performing critical action`() {
         val state = createPostListItemUiState(performingCriticalAction = true)
-        assertThat(state.data.showOverlay).isTrue()
+        assertThat(state.data.showOverlay).isTrue
     }
 
     @Test
@@ -832,7 +821,7 @@ class PostListItemUiStateHelperTest {
                 UploadingPost(false)
         )
         val state = createPostListItemUiState()
-        assertThat(state.data.showOverlay).isTrue()
+        assertThat(state.data.showOverlay).isTrue
     }
 
     @Test
@@ -866,7 +855,7 @@ class PostListItemUiStateHelperTest {
     @Test
     fun `pending publish post label shown when post eligible for auto-upload`() {
         whenever(uploadUiStateUseCase.createUploadUiState(anyOrNull(), anyOrNull(), anyOrNull())).thenReturn(
-                UploadWaitingForConnection(PUBLISHED)
+                UploadWaitingForConnection(PostStatus.PUBLISHED)
         )
         val state = createPostListItemUiState(
                 post = createPostModel(isLocallyChanged = true, status = POST_STATE_PUBLISH)
@@ -878,7 +867,7 @@ class PostListItemUiStateHelperTest {
     @Test
     fun `pending schedule label shown when post eligible for auto-upload`() {
         whenever(uploadUiStateUseCase.createUploadUiState(anyOrNull(), anyOrNull(), anyOrNull())).thenReturn(
-                UploadWaitingForConnection(SCHEDULED)
+                UploadWaitingForConnection(PostStatus.SCHEDULED)
         )
         val state = createPostListItemUiState(
                 post = createPostModel(isLocallyChanged = true, status = POST_STATE_SCHEDULED)
@@ -891,7 +880,7 @@ class PostListItemUiStateHelperTest {
     @Test
     fun `pending publish private post label shown when post eligible for auto-upload`() {
         whenever(uploadUiStateUseCase.createUploadUiState(anyOrNull(), anyOrNull(), anyOrNull())).thenReturn(
-                UploadWaitingForConnection(PRIVATE)
+                UploadWaitingForConnection(PostStatus.PRIVATE)
         )
         val state = createPostListItemUiState(
                 post = createPostModel(isLocallyChanged = true, status = POST_STATE_PRIVATE)
@@ -904,7 +893,7 @@ class PostListItemUiStateHelperTest {
     @Test
     fun `pending submit post label shown when post eligible for auto-upload`() {
         whenever(uploadUiStateUseCase.createUploadUiState(anyOrNull(), anyOrNull(), anyOrNull())).thenReturn(
-                UploadWaitingForConnection(PENDING)
+                UploadWaitingForConnection(PostStatus.PENDING)
         )
         val state = createPostListItemUiState(
                 post = createPostModel(isLocallyChanged = true, status = POST_STATE_PENDING)
@@ -917,7 +906,7 @@ class PostListItemUiStateHelperTest {
     @Test
     fun `local changes post label shown when draft eligible for auto-upload`() {
         whenever(uploadUiStateUseCase.createUploadUiState(anyOrNull(), anyOrNull(), anyOrNull())).thenReturn(
-                UploadWaitingForConnection(DRAFT)
+                UploadWaitingForConnection(PostStatus.DRAFT)
         )
         val state = createPostListItemUiState(
                 post = createPostModel(isLocallyChanged = true, status = POST_STATE_DRAFT)
@@ -976,7 +965,7 @@ class PostListItemUiStateHelperTest {
         // Arrange
         val authorDisplayName = "John Novak"
         val state = createPostListItemUiState(
-                authorFilterSelection = EVERYONE,
+                authorFilterSelection = AuthorFilterSelection.EVERYONE,
                 post = createPostModel(
                         authorDisplayName = authorDisplayName
                 ), formattedDate = FORMATTER_DATE
@@ -993,7 +982,7 @@ class PostListItemUiStateHelperTest {
         // Arrange
         val authorDisplayName = "John Novak"
         val state = createPostListItemUiState(
-                authorFilterSelection = ME,
+                authorFilterSelection = AuthorFilterSelection.ME,
                 post = createPostModel(
                         authorDisplayName = authorDisplayName
                 ), formattedDate = FORMATTER_DATE
@@ -1020,7 +1009,7 @@ class PostListItemUiStateHelperTest {
     }
 
     @Test
-    fun `when a post is locally changed and is local draft only "Local draft" label is displayed`() {
+    fun `when a post is locally changed and is local draft only 'Local draft' label is displayed`() {
         // Arrange
         val state = createPostListItemUiState(
                 post = createPostModel(isLocallyChanged = true, isLocalDraft = true)
@@ -1031,7 +1020,7 @@ class PostListItemUiStateHelperTest {
     }
 
     @Test
-    fun `when a post is sticky and no errors ocurred, the "Sticky" label is displayed`() {
+    fun `when a post is sticky and no errors occurred, the 'Sticky' label is displayed`() {
         // Arrange
         val state = createPostListItemUiState(
                 post = createPostModel(sticky = true)
@@ -1042,7 +1031,7 @@ class PostListItemUiStateHelperTest {
     }
 
     @Test
-    fun `when a post is sticky and private, the labels "Private" and "Sticky" are displayed`() {
+    fun `when a post is sticky and private, the labels 'Private' and 'Sticky' are displayed`() {
         // Arrange
         val state = createPostListItemUiState(
                 post = createPostModel(status = POST_STATE_PRIVATE, sticky = true)
@@ -1070,7 +1059,7 @@ class PostListItemUiStateHelperTest {
     }
 
     private fun createPostListItemUiState(
-        authorFilterSelection: AuthorFilterSelection = EVERYONE,
+        authorFilterSelection: AuthorFilterSelection = AuthorFilterSelection.EVERYONE,
         post: PostModel = PostModel(),
         site: SiteModel = SiteModel(),
         unhandledConflicts: Boolean = false,
@@ -1110,5 +1099,5 @@ class PostListItemUiStateHelperTest {
         )
     }
 
-    private fun createGenericError(): UploadError = UploadError(PostError(GENERIC_ERROR))
+    private fun createGenericError(): UploadError = UploadError(PostError(PostErrorType.GENERIC_ERROR))
 }

Original file line number	Diff line number	Diff line change
`@@ -308,7 +308,7 @@ class CreatePageListItemLabelsUseCaseTest {`
`308`	`308`	`}`
`309`	`309`
`310`	`310`	`@Test`
`311`		- fun `when a page is locally changed and is local draft only "Local draft" label is displayed`() {
	`311`	+ fun `when a page is locally changed and is local draft only 'Local draft' label is displayed`() {
`312`	`312`	`val (labels, _) = useCase.createLabels(`
`313`	`313`	`PostModel().apply {`
`314`	`314`	`setIsLocallyChanged(true)`